Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45830/?format=api
http://patches.dpdk.org/api/patches/45830/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181002093651.24795-13-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181002093651.24795-13-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181002093651.24795-13-maxime.coquelin@redhat.com", "date": "2018-10-02T09:36:46", "name": "[v2,12/17] vhost: avoid useless VhostUserMemory copy", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a8b2e090c0caa9036bc35f090f96d33c1e7e3889", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181002093651.24795-13-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 1630, "url": "http://patches.dpdk.org/api/series/1630/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1630", "date": "2018-10-02T09:36:34", "name": "vhost: add postcopy live-migration support", "version": 2, "mbox": "http://patches.dpdk.org/series/1630/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45830/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45830/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EA6115B26;\n\tTue, 2 Oct 2018 11:38:15 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id BEB4A569B;\n\tTue, 2 Oct 2018 11:38:14 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 0FE2E356DC;\n\tTue, 2 Oct 2018 09:38:14 +0000 (UTC)", "from localhost.localdomain (ovpn-112-50.ams2.redhat.com\n\t[10.36.112.50])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E33CC79431;\n\tTue, 2 Oct 2018 09:38:10 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com,\n\tjfreimann@redhat.com, nicknickolaev@gmail.com, i.maximets@samsung.com,\n\tbruce.richardson@intel.com, alejandro.lucero@netronome.com", "Cc": "dgilbert@redhat.com, stable@dpdk.org,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Tue, 2 Oct 2018 11:36:46 +0200", "Message-Id": "<20181002093651.24795-13-maxime.coquelin@redhat.com>", "In-Reply-To": "<20181002093651.24795-1-maxime.coquelin@redhat.com>", "References": "<20181002093651.24795-1-maxime.coquelin@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]); Tue, 02 Oct 2018 09:38:14 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH v2 12/17] vhost: avoid useless VhostUserMemory\n\tcopy", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The VHOST_USER_SET_MEM_TABLE payload is copied when handled,\nwhereas it could directly be referenced.\n\nThis is not very important, but next, we'll need to update the\npayload and send it back to Qemu.\n\nSigned-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/vhost_user.c | 24 ++++++++++++------------\n 1 file changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 2f681d291..515d3c61c 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -829,7 +829,7 @@ vhost_user_set_mem_table(struct virtio_net **pdev, struct VhostUserMsg *msg,\n \t\t\tint main_fd __rte_unused)\n {\n \tstruct virtio_net *dev = *pdev;\n-\tstruct VhostUserMemory memory = msg->payload.memory;\n+\tstruct VhostUserMemory *memory = &msg->payload.memory;\n \tstruct rte_vhost_mem_region *reg;\n \tvoid *mmap_addr;\n \tuint64_t mmap_size;\n@@ -839,17 +839,17 @@ vhost_user_set_mem_table(struct virtio_net **pdev, struct VhostUserMsg *msg,\n \tint populate;\n \tint fd;\n \n-\tif (memory.nregions > VHOST_MEMORY_MAX_NREGIONS) {\n+\tif (memory->nregions > VHOST_MEMORY_MAX_NREGIONS) {\n \t\tRTE_LOG(ERR, VHOST_CONFIG,\n-\t\t\t\"too many memory regions (%u)\\n\", memory.nregions);\n+\t\t\t\"too many memory regions (%u)\\n\", memory->nregions);\n \t\treturn VH_RESULT_ERR;\n \t}\n \n-\tif (dev->mem && !vhost_memory_changed(&memory, dev->mem)) {\n+\tif (dev->mem && !vhost_memory_changed(memory, dev->mem)) {\n \t\tRTE_LOG(INFO, VHOST_CONFIG,\n \t\t\t\"(%d) memory regions not changed\\n\", dev->vid);\n \n-\t\tfor (i = 0; i < memory.nregions; i++)\n+\t\tfor (i = 0; i < memory->nregions; i++)\n \t\t\tclose(msg->fds[i]);\n \n \t\treturn VH_RESULT_OK;\n@@ -881,25 +881,25 @@ vhost_user_set_mem_table(struct virtio_net **pdev, struct VhostUserMsg *msg,\n \t}\n \n \tdev->mem = rte_zmalloc(\"vhost-mem-table\", sizeof(struct rte_vhost_memory) +\n-\t\tsizeof(struct rte_vhost_mem_region) * memory.nregions, 0);\n+\t\tsizeof(struct rte_vhost_mem_region) * memory->nregions, 0);\n \tif (dev->mem == NULL) {\n \t\tRTE_LOG(ERR, VHOST_CONFIG,\n \t\t\t\"(%d) failed to allocate memory for dev->mem\\n\",\n \t\t\tdev->vid);\n \t\treturn VH_RESULT_ERR;\n \t}\n-\tdev->mem->nregions = memory.nregions;\n+\tdev->mem->nregions = memory->nregions;\n \n-\tfor (i = 0; i < memory.nregions; i++) {\n+\tfor (i = 0; i < memory->nregions; i++) {\n \t\tfd = msg->fds[i];\n \t\treg = &dev->mem->regions[i];\n \n-\t\treg->guest_phys_addr = memory.regions[i].guest_phys_addr;\n-\t\treg->guest_user_addr = memory.regions[i].userspace_addr;\n-\t\treg->size = memory.regions[i].memory_size;\n+\t\treg->guest_phys_addr = memory->regions[i].guest_phys_addr;\n+\t\treg->guest_user_addr = memory->regions[i].userspace_addr;\n+\t\treg->size = memory->regions[i].memory_size;\n \t\treg->fd = fd;\n \n-\t\tmmap_offset = memory.regions[i].mmap_offset;\n+\t\tmmap_offset = memory->regions[i].mmap_offset;\n \n \t\t/* Check for memory_size + mmap_offset overflow */\n \t\tif (mmap_offset >= -reg->size) {\n", "prefixes": [ "v2", "12/17" ] }{ "id": 45830, "url": "