Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45790/?format=api
{ "id": 45790, "url": "http://patches.dpdk.org/api/patches/45790/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181001205228.3503-3-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181001205228.3503-3-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20181001205228.3503-3-thomas@monjalon.net", "date": "2018-10-01T20:52:26", "name": "[v4,2/4] devargs: simplify parameters of removal function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fd82afc4d03d9ffd21d35aad1610ad5904b4cbdc", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181001205228.3503-3-thomas@monjalon.net/mbox/", "series": [ { "id": 1621, "url": "http://patches.dpdk.org/api/series/1621/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1621", "date": "2018-10-01T20:52:24", "name": "eal: simplify devargs and hotplug functions", "version": 4, "mbox": "http://patches.dpdk.org/series/1621/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45790/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45790/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CCA305F1A;\n\tMon, 1 Oct 2018 22:52:38 +0200 (CEST)", "from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com\n\t[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 4D05D568A\n\tfor <dev@dpdk.org>; Mon, 1 Oct 2018 22:52:34 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id E690721D26;\n\tMon, 1 Oct 2018 16:52:33 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n\tby compute1.internal (MEProxy); Mon, 01 Oct 2018 16:52:33 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id D3F81E49D9;\n\tMon, 1 Oct 2018 16:52:32 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tcc:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to:x-me-sender:x-me-sender\n\t:x-sasl-enc; s=mesmtp; bh=dCoooayVO1v/EsyrpmDWIqN234rEXQmnsTVGii\n\tgbAWs=; b=mkpq/DPtXjclhtitp9pYSPCoio8nPc91/Dssuk8blfvKBerFZOTRxV\n\tMe7Y8IiGC3un0YSZVU/TKaQfk7G5nCgju3Mgu8IQq0DNtgqOMHJilknu/+Igna34\n\tbey0Ue5P7XH0hhosw8gRsV6um8ofXNSOMNmFWEkDDIk+vz+fRS5pU=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:date:from\n\t:in-reply-to:message-id:mime-version:references:subject:to\n\t:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=dCoooayVO1v/Esyrp\n\tmDWIqN234rEXQmnsTVGiigbAWs=; b=LjkNMJkvxB6QObK+DIZU1zVTQ7XAkRkhp\n\t7DvXISOWK2p3amk7iixiZpa0Zrz7fYfXornEIx3mJKqjx1qviGKYe6ZfC9b9coLL\n\tpL7CBC3FKiAH5izkV5+fDd2EU6OZUZrTWrelFYGFI7NxAmCqViNqmsDYFHqN+6So\n\tfzLhiD4wtm98eW9fSxtmB87N0bfceiEeTJdWvIykmCs1n/iHDbv/YK3XjISR85/2\n\tjNbpGO86Aua/XpTjXnLoxeuXIy2LLES816F5TM5K2jnB6eLyoBpZFRzRQ/Qp8Zv4\n\tSm0ow4epGNW58UHdK2i3l30D+gPOeQsGCt44CYuLwzonwDKTilI4g==" ], "X-ME-Sender": "<xms:EYmyW0bip9BwfE-PhbT84b6e7UxxHiXKUqYXXg5yDM8qsAOxAr66Ww>", "X-ME-Proxy": "<xmx:EYmyW6VKgdWamDiuoYwXRroxxw1TX1aMJPwCkcbsVl3EwFwVmTvvkQ>\n\t<xmx:EYmyW3-dU1kxT7bqCXj2XZoblSnMJub7TwsH7ZbnMNbF1e_Pbf03Mg>\n\t<xmx:EYmyW3ro5BZXgpouGAO6UXR6U6akWsXJMCjRwcULQVgNUF7LSXEzTA>\n\t<xmx:EYmyW5lOw4jNPwQOAgr54da0NTM9qlEf-mYw9SLED5ag3TomGNLT_Q>\n\t<xmx:EYmyW7b2d-ySUXmyeeWecoOBn8Wtd4KH7ftS7Po6KhNLQwUoxJuNGw>\n\t<xmx:EYmyWxMSC18uWzE1ck9tgqRsULRqEdNZLVrCQms7lv--Yjx0c3r9Jg>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "gaetan.rivet@6wind.com, ophirmu@mellanox.com, qi.z.zhang@intel.com,\n\tferruh.yigit@intel.com, ktraynor@redhat.com", "Date": "Mon, 1 Oct 2018 22:52:26 +0200", "Message-Id": "<20181001205228.3503-3-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.19.0", "In-Reply-To": "<20181001205228.3503-1-thomas@monjalon.net>", "References": "<20180907222727.20521-1-thomas@monjalon.net>\n\t<20181001205228.3503-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 2/4] devargs: simplify parameters of removal\n\tfunction", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The function rte_devargs_remove(), which is intended to be internal,\ncan take a devargs structure as argument.\nThe matching is still using string comparison of bus name and\ndevice name.\nIt is simpler and may allow a different devargs matching in future.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\nReviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n doc/guides/rel_notes/release_18_11.rst | 3 +++\n drivers/bus/ifpga/ifpga_bus.c | 5 +----\n drivers/bus/vdev/vdev.c | 8 ++------\n lib/librte_eal/common/eal_common_dev.c | 4 ++--\n lib/librte_eal/common/eal_common_devargs.c | 11 +++++++----\n lib/librte_eal/common/include/rte_devargs.h | 10 +++-------\n 6 files changed, 18 insertions(+), 23 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst\nindex ef902b028..54f475fd7 100644\n--- a/doc/guides/rel_notes/release_18_11.rst\n+++ b/doc/guides/rel_notes/release_18_11.rst\n@@ -107,6 +107,9 @@ API Changes\n ``rte_eal_parse_devargs_str()``, ``rte_eal_devargs_add()``,\n ``rte_eal_devargs_type_count()``, and ``rte_eal_devargs_dump()``.\n \n+* eal: The parameters of the function ``rte_devargs_remove()`` have changed\n+ from bus and device names to ``struct rte_devargs``.\n+\n * mbuf: The ``__rte_mbuf_raw_free()`` and ``__rte_pktmbuf_prefree_seg()``\n functions were deprecated since 17.05 and are replaced by\n ``rte_mbuf_raw_free()`` and ``rte_pktmbuf_prefree_seg()``.\ndiff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c\nindex c54b59db2..3ef035b7e 100644\n--- a/drivers/bus/ifpga/ifpga_bus.c\n+++ b/drivers/bus/ifpga/ifpga_bus.c\n@@ -361,7 +361,6 @@ static int\n ifpga_unplug(struct rte_device *dev)\n {\n \tstruct rte_afu_device *afu_dev = NULL;\n-\tstruct rte_devargs *devargs = NULL;\n \tint ret;\n \n \tif (dev == NULL)\n@@ -371,15 +370,13 @@ ifpga_unplug(struct rte_device *dev)\n \tif (!afu_dev)\n \t\treturn -ENOENT;\n \n-\tdevargs = dev->devargs;\n-\n \tret = ifpga_remove_driver(afu_dev);\n \tif (ret)\n \t\treturn ret;\n \n \tTAILQ_REMOVE(&ifpga_afu_dev_list, afu_dev, next);\n \n-\trte_devargs_remove(devargs->bus->name, devargs->name);\n+\trte_devargs_remove(dev->devargs);\n \tfree(afu_dev);\n \treturn 0;\n \ndiff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c\nindex 69dee89a8..390c2ce70 100644\n--- a/drivers/bus/vdev/vdev.c\n+++ b/drivers/bus/vdev/vdev.c\n@@ -248,7 +248,6 @@ int\n rte_vdev_init(const char *name, const char *args)\n {\n \tstruct rte_vdev_device *dev;\n-\tstruct rte_devargs *devargs;\n \tint ret;\n \n \trte_spinlock_recursive_lock(&vdev_device_list_lock);\n@@ -259,9 +258,8 @@ rte_vdev_init(const char *name, const char *args)\n \t\t\tif (ret > 0)\n \t\t\t\tVDEV_LOG(ERR, \"no driver found for %s\", name);\n \t\t\t/* If fails, remove it from vdev list */\n-\t\t\tdevargs = dev->device.devargs;\n \t\t\tTAILQ_REMOVE(&vdev_device_list, dev, next);\n-\t\t\trte_devargs_remove(devargs->bus->name, devargs->name);\n+\t\t\trte_devargs_remove(dev->device.devargs);\n \t\t\tfree(dev);\n \t\t}\n \t}\n@@ -289,7 +287,6 @@ int\n rte_vdev_uninit(const char *name)\n {\n \tstruct rte_vdev_device *dev;\n-\tstruct rte_devargs *devargs;\n \tint ret;\n \n \tif (name == NULL)\n@@ -308,8 +305,7 @@ rte_vdev_uninit(const char *name)\n \t\tgoto unlock;\n \n \tTAILQ_REMOVE(&vdev_device_list, dev, next);\n-\tdevargs = dev->device.devargs;\n-\trte_devargs_remove(devargs->bus->name, devargs->name);\n+\trte_devargs_remove(dev->device.devargs);\n \tfree(dev);\n \n unlock:\ndiff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c\nindex 678dbcac7..e81ff4258 100644\n--- a/lib/librte_eal/common/eal_common_dev.c\n+++ b/lib/librte_eal/common/eal_common_dev.c\n@@ -186,7 +186,7 @@ int __rte_experimental rte_eal_hotplug_add(const char *busname, const char *devn\n \treturn 0;\n \n err_devarg:\n-\tif (rte_devargs_remove(busname, devname)) {\n+\tif (rte_devargs_remove(da)) {\n \t\tfree(da->args);\n \t\tfree(da);\n \t}\n@@ -227,7 +227,7 @@ rte_eal_hotplug_remove(const char *busname, const char *devname)\n \tif (ret)\n \t\tRTE_LOG(ERR, EAL, \"Driver cannot detach the device (%s)\\n\",\n \t\t\tdev->name);\n-\trte_devargs_remove(busname, devname);\n+\trte_devargs_remove(dev->devargs);\n \treturn ret;\n }\n \ndiff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c\nindex f63d2c663..d8db45a23 100644\n--- a/lib/librte_eal/common/eal_common_devargs.c\n+++ b/lib/librte_eal/common/eal_common_devargs.c\n@@ -266,7 +266,7 @@ rte_devargs_insert(struct rte_devargs *da)\n {\n \tint ret;\n \n-\tret = rte_devargs_remove(da->bus->name, da->name);\n+\tret = rte_devargs_remove(da);\n \tif (ret < 0)\n \t\treturn ret;\n \tTAILQ_INSERT_TAIL(&devargs_list, da, next);\n@@ -312,14 +312,17 @@ rte_devargs_add(enum rte_devtype devtype, const char *devargs_str)\n }\n \n int __rte_experimental\n-rte_devargs_remove(const char *busname, const char *devname)\n+rte_devargs_remove(struct rte_devargs *devargs)\n {\n \tstruct rte_devargs *d;\n \tvoid *tmp;\n \n+\tif (devargs->bus == NULL)\n+\t\treturn -1;\n+\n \tTAILQ_FOREACH_SAFE(d, &devargs_list, next, tmp) {\n-\t\tif (strcmp(d->bus->name, busname) == 0 &&\n-\t\t strcmp(d->name, devname) == 0) {\n+\t\tif (strcmp(d->bus->name, devargs->bus->name) == 0 &&\n+\t\t strcmp(d->name, devargs->name) == 0) {\n \t\t\tTAILQ_REMOVE(&devargs_list, d, next);\n \t\t\tfree(d->args);\n \t\t\tfree(d);\ndiff --git a/lib/librte_eal/common/include/rte_devargs.h b/lib/librte_eal/common/include/rte_devargs.h\nindex 0eef6e9c4..b1f121f83 100644\n--- a/lib/librte_eal/common/include/rte_devargs.h\n+++ b/lib/librte_eal/common/include/rte_devargs.h\n@@ -176,11 +176,8 @@ int rte_devargs_add(enum rte_devtype devtype, const char *devargs_str);\n * Its resources are freed.\n * If the devargs cannot be found, nothing happens.\n *\n- * @param busname\n- * bus name of the devargs to remove.\n- *\n- * @param devname\n- * device name of the devargs to remove.\n+ * @param devargs\n+ * The instance or a copy of devargs to remove.\n *\n * @return\n * 0 on success.\n@@ -188,8 +185,7 @@ int rte_devargs_add(enum rte_devtype devtype, const char *devargs_str);\n * >0 if the devargs was not within the user device list.\n */\n __rte_experimental\n-int rte_devargs_remove(const char *busname,\n-\t\t const char *devname);\n+int rte_devargs_remove(struct rte_devargs *devargs);\n \n /**\n * Count the number of user devices of a specified type\n", "prefixes": [ "v4", "2/4" ] }