Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45649/?format=api
{ "id": 45649, "url": "http://patches.dpdk.org/api/patches/45649/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1538208822-9726-4-git-send-email-rasesh.mody@cavium.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1538208822-9726-4-git-send-email-rasesh.mody@cavium.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1538208822-9726-4-git-send-email-rasesh.mody@cavium.com", "date": "2018-09-29T08:14:28", "name": "[03/18] net/qede/base: add DPC sync after PF stop", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6e87aa651b4e7419ee1bb995bdfb269760867b40", "submitter": { "id": 569, "url": "http://patches.dpdk.org/api/people/569/?format=api", "name": "Mody, Rasesh", "email": "rasesh.mody@cavium.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1538208822-9726-4-git-send-email-rasesh.mody@cavium.com/mbox/", "series": [ { "id": 1596, "url": "http://patches.dpdk.org/api/series/1596/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1596", "date": "2018-09-29T08:13:57", "name": "net/qede: base driver update", "version": 1, "mbox": "http://patches.dpdk.org/series/1596/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45649/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/45649/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EFFDF1B113;\n\tSat, 29 Sep 2018 10:14:46 +0200 (CEST)", "from NAM04-CO1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr690074.outbound.protection.outlook.com [40.107.69.74])\n\tby dpdk.org (Postfix) with ESMTP id E51A85F35\n\tfor <dev@dpdk.org>; Sat, 29 Sep 2018 10:14:35 +0200 (CEST)", "from BYAPR07MB5365.namprd07.prod.outlook.com (20.177.125.18) by\n\tBYAPR07MB5320.namprd07.prod.outlook.com (20.177.124.225) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1143.18; Sat, 29 Sep 2018 08:14:29 +0000", "from BYAPR07MB5365.namprd07.prod.outlook.com\n\t([fe80::2047:9647:f196:bde0]) by\n\tBYAPR07MB5365.namprd07.prod.outlook.com\n\t([fe80::2047:9647:f196:bde0%6]) with mapi id 15.20.1143.022;\n\tSat, 29 Sep 2018 08:14:29 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=S4+1vpl85n24QM73r7MQ1Z3L76ise6UPwpZWJQzy0i4=;\n\tb=QMQWbIUKegW/z9r6HVVL+qpdNCyfbupokWReD68GA0A5z4nMguG7hdNu9wyR14BMdn0Ac/QNytf6S6ArY+zMVM6seS27GK3KuozuwVW70NnOdGssjskNUW6XN4ThlPU8foTYTOjU6yUwSJPIagO2TsoRBoq83KyaBp3Hk9ufBto=", "From": "\"Mody, Rasesh\" <Rasesh.Mody@cavium.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"Mody, Rasesh\" <Rasesh.Mody@cavium.com>, \"ferruh.yigit@intel.com\"\n\t<ferruh.yigit@intel.com>, Dept-Eng DPDK Dev <Dept-EngDPDKDev@cavium.com>", "Thread-Topic": "[PATCH 03/18] net/qede/base: add DPC sync after PF stop", "Thread-Index": "AQHUV8xxgCPRjwaMl06D8x+eY32naQ==", "Date": "Sat, 29 Sep 2018 08:14:28 +0000", "Message-ID": "<1538208822-9726-4-git-send-email-rasesh.mody@cavium.com>", "References": "<1538208822-9726-1-git-send-email-rasesh.mody@cavium.com>", "In-Reply-To": "<1538208822-9726-1-git-send-email-rasesh.mody@cavium.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "BYAPR11CA0059.namprd11.prod.outlook.com\n\t(2603:10b6:a03:80::36) To BYAPR07MB5365.namprd07.prod.outlook.com\n\t(2603:10b6:a03:64::18)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Rasesh.Mody@cavium.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-originating-ip": "[198.186.1.5]", "x-ms-publictraffictype": "Email", "x-microsoft-exchange-diagnostics": "1; BYAPR07MB5320;\n\t6:9fh4kEi3Fg+2uTnDIlujdO5fOjH3Yh69tdvVKyfC6ccQVFnuilq01+32W5/h4uogXbmZ322RnVjAu/qeHoC2pRRdGXQutAX15KwBS+4f4NiLw7rntsVzyDGxk6uipVAzpSKGrmShXCjqPD1le/yQXYAZIbJwDnkxMWNbYweNRp44k6AybGXJySMjrI2yu4sg2Os8oFhjv2Ex1symLt7EFf83fLkF5GMB9ZW5Y1QFRi9ifQOeX9dyUNTExrXmyjR9dx5fxDN3/2p9xwoNco8H+mT9jRMVdRJJlJ7slI+HpsvHx710xbGlitvSDtqvASZFZdHn6LosiwDza19W326wFY6buKLFpTiIwzRby0I3n2CcT/+l+/FPWtsu1cFW2rgHU0PYlYzrM04Tnfvs8Ud97p2M9NGx+QmTttD2fXhyp/vF05ge1V8ymMyTyExxWgt7tF4kT0GVFr3H0UtbwLBR/Q==;\n\t5:O56kRBhsHICWj/iLtoCyQ4pnuXpZ5KvPw5NU0XcBwqZGmzxjv43drvCamzGZAyqw97JCKO8vnQUUsJxtkxUedsVChdQzfNpa60Jp0DG0gsufaidtRXHXPElPzZ7b4Zo5ix9PS/EwuieM+pOJuXmNquPH+Hxr+6A0nUpmxjJHPOg=;\n\t7:Mjo84JLVm0/GlTcKEhQm5ee2Hl+ZJaztpjp/s5xN6+ieHIUe+ly09sAUWd9ZcnkY0m/XVjuwA9RYRV4oPcCohSKf+UoYBb1/JQ7U0S7Ni9lmWTEwHllGJ5X9AYOxH6ZFtpR5lBqyIrvUT3zhSPejXQcS36AQygHcfK9Mvbj6T6oyDms1nCMfp9PyUplvYwTJeZab8Bg6dTkrRmmB+0M3b9Mmo/fMvubID86pT+ftnHxr9SF8cjhnkISRLjIuzMPV", "x-ms-office365-filtering-correlation-id": "0ccd112d-6f49-4c10-ed9c-08d625e39389", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020);\n\tSRVR:BYAPR07MB5320; ", "x-ms-traffictypediagnostic": "BYAPR07MB5320:", "x-microsoft-antispam-prvs": "<BYAPR07MB53208E9C613D72A7812F04BE9FED0@BYAPR07MB5320.namprd07.prod.outlook.com>", "x-exchange-antispam-report-test": "UriScan:;", "x-ms-exchange-senderadcheck": "1", "x-exchange-antispam-report-cfa-test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823301075)(3231355)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(149066)(150057)(6041310)(20161123564045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699051);\n\tSRVR:BYAPR07MB5320; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB5320; ", "x-forefront-prvs": "0810818DA0", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(376002)(366004)(396003)(136003)(346002)(39860400002)(199004)(189003)(97736004)(256004)(14454004)(4326008)(11346002)(2501003)(2900100001)(99286004)(54906003)(1730700003)(86362001)(68736007)(446003)(3846002)(25786009)(76176011)(5660300001)(2616005)(8676002)(305945005)(8936002)(486006)(107886003)(2351001)(26005)(2906002)(5250100002)(71190400001)(5640700003)(36756003)(6436002)(6486002)(53936002)(316002)(72206003)(386003)(105586002)(71200400001)(6916009)(102836004)(6512007)(6116002)(6506007)(7736002)(81156014)(81166006)(186003)(52116002)(476003)(478600001)(66066001)(34290500001)(106356001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB5320;\n\tH:BYAPR07MB5365.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)", "x-microsoft-antispam-message-info": "IO2mQSok21PJlXT4QXOidFS7AbSu3/NE1pINqlozlJqeOuwu6RtAOwEZ0SE9Uok7JNNIbvJfIJaTPhrQLnBUkVlrfBRZvUHUf1hFqqCarxXSfkuh+n9RaL4uDhsN1CznMz5Xb39CyeDlDyWR8voaSd9zmlh27s2P471uhTp0pyxkSn8dJceM8mX0Q7kniI65rIB2jDtkiP5c6eoMqmmB4hrgfkL4LfkY6s5efOkOdUpuhvziDdGBPx7w7UexSo2l6cjibvggKz9JogH6v5+N7cXOfpj4n29SxQeeo8jkf90wiF3PCPAhOrhjBUujlAZ0MBCRRz9+xAUMNn0yOHpHubif+MIrocPI7wZVX6Y9S0w=", "spamdiagnosticoutput": "1:99", "spamdiagnosticmetadata": "NSPM", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "cavium.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "0ccd112d-6f49-4c10-ed9c-08d625e39389", "X-MS-Exchange-CrossTenant-originalarrivaltime": "29 Sep 2018 08:14:28.9742\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "711e4ccf-2e9b-4bcf-a551-4094005b6194", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BYAPR07MB5320", "Subject": "[dpdk-dev] [PATCH 03/18] net/qede/base: add DPC sync after PF stop", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add DPC sync after stopping the physical funciton to allow clean up of\nasyncronous events. Post this the driver don't expect the FW to send\nasync events.\n\nSigned-off-by: Rasesh Mody <rasesh.mody@cavium.com>\n---\n drivers/net/qede/base/ecore_dev.c | 6 ++++++\n drivers/net/qede/base/ecore_spq.c | 12 ++++++++++--\n 2 files changed, 16 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c\nindex f09f771..4558306 100644\n--- a/drivers/net/qede/base/ecore_dev.c\n+++ b/drivers/net/qede/base/ecore_dev.c\n@@ -2804,6 +2804,12 @@ enum _ecore_status_t ecore_hw_stop(struct ecore_dev *p_dev)\n \t\t\trc2 = ECORE_UNKNOWN_ERROR;\n \t\t}\n \n+\t\tOSAL_DPC_SYNC(p_hwfn);\n+\n+\t\t/* After this point we don't expect the FW to send us async\n+\t\t * events\n+\t\t */\n+\n \t\t/* perform debug action after PF stop was sent */\n \t\tOSAL_AFTER_PF_STOP((void *)p_dev, p_hwfn->my_id);\n \ndiff --git a/drivers/net/qede/base/ecore_spq.c b/drivers/net/qede/base/ecore_spq.c\nindex 776c86f..1a02ba2 100644\n--- a/drivers/net/qede/base/ecore_spq.c\n+++ b/drivers/net/qede/base/ecore_spq.c\n@@ -283,8 +283,10 @@ static enum _ecore_status_t ecore_spq_hw_post(struct ecore_hwfn *p_hwfn,\n {\n \tecore_spq_async_comp_cb cb;\n \n-\tif (!p_hwfn->p_spq || (p_eqe->protocol_id >= MAX_PROTOCOL_TYPE))\n+\tif (p_eqe->protocol_id >= MAX_PROTOCOL_TYPE) {\n+\t\tDP_ERR(p_hwfn, \"Wrong protocol: %d\\n\", p_eqe->protocol_id);\n \t\treturn ECORE_INVAL;\n+\t}\n \n \tcb = p_hwfn->p_spq->async_comp_cb[p_eqe->protocol_id];\n \tif (cb) {\n@@ -339,10 +341,16 @@ enum _ecore_status_t ecore_eq_completion(struct ecore_hwfn *p_hwfn,\n {\n \tstruct ecore_eq *p_eq = cookie;\n \tstruct ecore_chain *p_chain = &p_eq->chain;\n+\tu16 fw_cons_idx = 0;\n \tenum _ecore_status_t rc = 0;\n \n+\tif (!p_hwfn->p_spq) {\n+\t\tDP_ERR(p_hwfn, \"Unexpected NULL p_spq\\n\");\n+\t\treturn ECORE_INVAL;\n+\t}\n+\n \t/* take a snapshot of the FW consumer */\n-\tu16 fw_cons_idx = OSAL_LE16_TO_CPU(*p_eq->p_fw_cons);\n+\tfw_cons_idx = OSAL_LE16_TO_CPU(*p_eq->p_fw_cons);\n \n \tDP_VERBOSE(p_hwfn, ECORE_MSG_SPQ, \"fw_cons_idx %x\\n\", fw_cons_idx);\n \n", "prefixes": [ "03/18" ] }