Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45637/?format=api
{ "id": 45637, "url": "http://patches.dpdk.org/api/patches/45637/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180929020006.71505-15-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180929020006.71505-15-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180929020006.71505-15-ajit.khaparde@broadcom.com", "date": "2018-09-29T02:00:05", "name": "[v3,14/15] net/bnxt: remove excess log messages", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "75e8d73b10e04e6580d4f4f41957b2567bc57601", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180929020006.71505-15-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 1590, "url": "http://patches.dpdk.org/api/series/1590/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1590", "date": "2018-09-29T01:59:54", "name": "bnxt patchset", "version": 3, "mbox": "http://patches.dpdk.org/series/1590/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45637/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45637/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 587D31B4BD;\n\tSat, 29 Sep 2018 04:01:30 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id AD3981B3BB;\n\tSat, 29 Sep 2018 04:00:22 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 81AE230C060;\n\tFri, 28 Sep 2018 19:00:21 -0700 (PDT)", "from C02VPB22HTD6.vpn.broadcom.net (unknown [10.10.118.196])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 3A7A3AC0729;\n\tFri, 28 Sep 2018 19:00:21 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 81AE230C060", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1538186421;\n\tbh=4BcgZbGtqXQDP62f5h192+BmXmK3gXxKNF0kpHK8hE8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=vF7nVRuvC/Kj31EjYa3NGO4SzY4XCZAxvm21eocFUF6iEooXtm/AqjBT1CDyCrXo0\n\t3rk/5beJ6+qc1djIAd1j9eAwCeHFDf1axbfI+4uoMXpISWgO4gbMMapDC9q56XuS2U\n\tw/eTcTGXBOxEOorltnaKZMKrciFFqfirx4dKYNr8=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tstable@dpdk.org", "Date": "Fri, 28 Sep 2018 19:00:05 -0700", "Message-Id": "<20180929020006.71505-15-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.17.1 (Apple Git-112)", "In-Reply-To": "<20180929020006.71505-1-ajit.khaparde@broadcom.com>", "References": "<95301884-14c8-bbfd-ade9-ded04bdb6a95@intel.com>\n\t<20180929020006.71505-1-ajit.khaparde@broadcom.com>", "Subject": "[dpdk-dev] [PATCH v3 14/15] net/bnxt: remove excess log messages", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When the firmware version and the driver HWRM version do not match,\nwe are logging some messages. These messages unnecessarily clutter\nthe logs and can add to the noise. We are logging the HWRM version\nand the firmware version anyway. The difference in version numbers\ncan be gleaned from that. Removing the remaining log messages.\n\nFixes: 804e746c7b73 (\"net/bnxt: add hardware resource manager init code\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n--\nv1->v2:\nAdd \"Fixes\" to the commit message.\n---\n drivers/net/bnxt/bnxt_hwrm.c | 20 --------------------\n 1 file changed, 20 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 38698e214..76e443ec1 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -789,7 +789,6 @@ int bnxt_hwrm_ver_get(struct bnxt *bp)\n \tint rc = 0;\n \tstruct hwrm_ver_get_input req = {.req_type = 0 };\n \tstruct hwrm_ver_get_output *resp = bp->hwrm_cmd_resp_addr;\n-\tuint32_t my_version;\n \tuint32_t fw_version;\n \tuint16_t max_resp_len;\n \tchar type[RTE_MEMZONE_NAMESIZE];\n@@ -817,10 +816,6 @@ int bnxt_hwrm_ver_get(struct bnxt *bp)\n \tPMD_DRV_LOG(INFO, \"Driver HWRM version: %d.%d.%d\\n\",\n \t\tHWRM_VERSION_MAJOR, HWRM_VERSION_MINOR, HWRM_VERSION_UPDATE);\n \n-\tmy_version = HWRM_VERSION_MAJOR << 16;\n-\tmy_version |= HWRM_VERSION_MINOR << 8;\n-\tmy_version |= HWRM_VERSION_UPDATE;\n-\n \tfw_version = resp->hwrm_intf_maj_8b << 16;\n \tfw_version |= resp->hwrm_intf_min_8b << 8;\n \tfw_version |= resp->hwrm_intf_upd_8b;\n@@ -832,21 +827,6 @@ int bnxt_hwrm_ver_get(struct bnxt *bp)\n \t\tgoto error;\n \t}\n \n-\tif (my_version != fw_version) {\n-\t\tPMD_DRV_LOG(INFO, \"BNXT Driver/HWRM API mismatch.\\n\");\n-\t\tif (my_version < fw_version) {\n-\t\t\tPMD_DRV_LOG(INFO,\n-\t\t\t\t\"Firmware API version is newer than driver.\\n\");\n-\t\t\tPMD_DRV_LOG(INFO,\n-\t\t\t\t\"The driver may be missing features.\\n\");\n-\t\t} else {\n-\t\t\tPMD_DRV_LOG(INFO,\n-\t\t\t\t\"Firmware API version is older than driver.\\n\");\n-\t\t\tPMD_DRV_LOG(INFO,\n-\t\t\t\t\"Not all driver features may be functional.\\n\");\n-\t\t}\n-\t}\n-\n \tif (bp->max_req_len > resp->max_req_win_len) {\n \t\tPMD_DRV_LOG(ERR, \"Unsupported request length\\n\");\n \t\trc = -EINVAL;\n", "prefixes": [ "v3", "14/15" ] }