Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45623/?format=api
{ "id": 45623, "url": "http://patches.dpdk.org/api/patches/45623/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1538155426-145177-2-git-send-email-yipeng1.wang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1538155426-145177-2-git-send-email-yipeng1.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1538155426-145177-2-git-send-email-yipeng1.wang@intel.com", "date": "2018-09-28T17:23:43", "name": "[v4,1/4] hash: fix race condition in iterate", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4db78096c03905cf2d8e2ba320a20f85d728df69", "submitter": { "id": 754, "url": "http://patches.dpdk.org/api/people/754/?format=api", "name": "Wang, Yipeng1", "email": "yipeng1.wang@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1538155426-145177-2-git-send-email-yipeng1.wang@intel.com/mbox/", "series": [ { "id": 1589, "url": "http://patches.dpdk.org/api/series/1589/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1589", "date": "2018-09-28T17:23:42", "name": "hash: add extendable bucket and partial key hashing", "version": 4, "mbox": "http://patches.dpdk.org/series/1589/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45623/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45623/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 044FC1B184;\n\tSat, 29 Sep 2018 02:29:05 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 2D1E35F19\n\tfor <dev@dpdk.org>; Sat, 29 Sep 2018 02:28:51 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Sep 2018 17:28:48 -0700", "from skx-yipeng.jf.intel.com ([10.54.81.175])\n\tby orsmga008.jf.intel.com with ESMTP; 28 Sep 2018 17:28:46 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,317,1534834800\"; d=\"scan'208\";a=\"77286775\"", "From": "Yipeng Wang <yipeng1.wang@intel.com>", "To": "bruce.richardson@intel.com", "Cc": "konstantin.ananyev@intel.com, dev@dpdk.org, yipeng1.wang@intel.com,\n\thonnappa.nagarahalli@arm.com, sameh.gobriel@intel.com", "Date": "Fri, 28 Sep 2018 10:23:43 -0700", "Message-Id": "<1538155426-145177-2-git-send-email-yipeng1.wang@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1538155426-145177-1-git-send-email-yipeng1.wang@intel.com>", "References": "<1537993618-92630-1-git-send-email-yipeng1.wang@intel.com>\n\t<1538155426-145177-1-git-send-email-yipeng1.wang@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 1/4] hash: fix race condition in iterate", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In rte_hash_iterate, the reader lock did not protect the\nwhile loop which checks empty entry. This created a race\ncondition that the entry may become empty when enters\nthe lock, then a wrong key data value would be read out.\n\nThis commit extends the protected region.\n\nFixes: f2e3001b53ec (\"hash: support read/write concurrency\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yipeng Wang <yipeng1.wang@intel.com>\nReported-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n---\n lib/librte_hash/rte_cuckoo_hash.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_hash/rte_cuckoo_hash.c b/lib/librte_hash/rte_cuckoo_hash.c\nindex f7b86c8..eba13e9 100644\n--- a/lib/librte_hash/rte_cuckoo_hash.c\n+++ b/lib/librte_hash/rte_cuckoo_hash.c\n@@ -1317,16 +1317,19 @@ rte_hash_iterate(const struct rte_hash *h, const void **key, void **data, uint32\n \tbucket_idx = *next / RTE_HASH_BUCKET_ENTRIES;\n \tidx = *next % RTE_HASH_BUCKET_ENTRIES;\n \n+\t__hash_rw_reader_lock(h);\n \t/* If current position is empty, go to the next one */\n \twhile (h->buckets[bucket_idx].key_idx[idx] == EMPTY_SLOT) {\n \t\t(*next)++;\n \t\t/* End of table */\n-\t\tif (*next == total_entries)\n+\t\tif (*next == total_entries) {\n+\t\t\t__hash_rw_reader_unlock(h);\n \t\t\treturn -ENOENT;\n+\t\t}\n \t\tbucket_idx = *next / RTE_HASH_BUCKET_ENTRIES;\n \t\tidx = *next % RTE_HASH_BUCKET_ENTRIES;\n \t}\n-\t__hash_rw_reader_lock(h);\n+\n \t/* Get position of entry in key table */\n \tposition = h->buckets[bucket_idx].key_idx[idx];\n \tnext_key = (struct rte_hash_key *) ((char *)h->key_store +\n", "prefixes": [ "v4", "1/4" ] }