Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45616/?format=api
{ "id": 45616, "url": "http://patches.dpdk.org/api/patches/45616/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1538143869-152808-2-git-send-email-yipeng1.wang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1538143869-152808-2-git-send-email-yipeng1.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1538143869-152808-2-git-send-email-yipeng1.wang@intel.com", "date": "2018-09-28T14:11:05", "name": "[v4,1/5] test/hash: fix bucket size in hash perf test", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "af44cc1938b734c6ba5585cebc15cf2956823671", "submitter": { "id": 754, "url": "http://patches.dpdk.org/api/people/754/?format=api", "name": "Wang, Yipeng1", "email": "yipeng1.wang@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1538143869-152808-2-git-send-email-yipeng1.wang@intel.com/mbox/", "series": [ { "id": 1585, "url": "http://patches.dpdk.org/api/series/1585/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1585", "date": "2018-09-28T14:11:04", "name": "hash: fix multiple issues", "version": 4, "mbox": "http://patches.dpdk.org/series/1585/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45616/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45616/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E34DE1B491;\n\tFri, 28 Sep 2018 23:18:10 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id B7FBE1B3B0\n\tfor <dev@dpdk.org>; Fri, 28 Sep 2018 23:17:53 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Sep 2018 14:17:50 -0700", "from skx-yipeng.jf.intel.com ([10.54.81.175])\n\tby fmsmga005.fm.intel.com with ESMTP; 28 Sep 2018 14:16:08 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,316,1534834800\"; d=\"scan'208\";a=\"266882881\"", "From": "Yipeng Wang <yipeng1.wang@intel.com>", "To": "bruce.richardson@intel.com", "Cc": "dev@dpdk.org, yipeng1.wang@intel.com, honnappa.nagarahalli@arm.com,\n\tsameh.gobriel@intel.com", "Date": "Fri, 28 Sep 2018 07:11:05 -0700", "Message-Id": "<1538143869-152808-2-git-send-email-yipeng1.wang@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1538143869-152808-1-git-send-email-yipeng1.wang@intel.com>", "References": "<1537966465-248530-1-git-send-email-yipeng1.wang@intel.com>\n\t<1538143869-152808-1-git-send-email-yipeng1.wang@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 1/5] test/hash: fix bucket size in hash perf\n\ttest", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The bucket size was changed from 4 to 8 but the corresponding\nperf test was not changed accordingly.\n\nIn the test, the bucket size and number of buckets are used\nto map to the underneath rte_hash structure. They are used\nto test performance of two conditions: keys in primary\nbuckets only and keys in both primary and secondary buckets.\n\nAlthough there is no functional issue with bucket size set\nto 4, it mismatches the underneath rte_hash structure,\nwhich may affect code readability and future extension.\n\nFixes: 58017c98ed53 (\"hash: add vectorized comparison\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yipeng Wang <yipeng1.wang@intel.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n test/test/test_hash_perf.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/test/test/test_hash_perf.c b/test/test/test_hash_perf.c\nindex 33dcb9f..fe11632 100644\n--- a/test/test/test_hash_perf.c\n+++ b/test/test/test_hash_perf.c\n@@ -20,7 +20,8 @@\n #define MAX_ENTRIES (1 << 19)\n #define KEYS_TO_ADD (MAX_ENTRIES * 3 / 4) /* 75% table utilization */\n #define NUM_LOOKUPS (KEYS_TO_ADD * 5) /* Loop among keys added, several times */\n-#define BUCKET_SIZE 4\n+/* BUCKET_SIZE should be same as RTE_HASH_BUCKET_ENTRIES in rte_hash library */\n+#define BUCKET_SIZE 8\n #define NUM_BUCKETS (MAX_ENTRIES / BUCKET_SIZE)\n #define MAX_KEYSIZE 64\n #define NUM_KEYSIZES 10\n", "prefixes": [ "v4", "1/5" ] }