Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 456,
    "url": "http://patches.dpdk.org/api/patches/456/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1411470497-10209-4-git-send-email-bruce.richardson@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1411470497-10209-4-git-send-email-bruce.richardson@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1411470497-10209-4-git-send-email-bruce.richardson@intel.com",
    "date": "2014-09-23T11:08:15",
    "name": "[dpdk-dev,v2,3/5] testpmd: Change rxfreet default to 32",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "a2310f5c2abfe525bc40940973007aedf1fd42b9",
    "submitter": {
        "id": 20,
        "url": "http://patches.dpdk.org/api/people/20/?format=api",
        "name": "Bruce Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1411470497-10209-4-git-send-email-bruce.richardson@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/456/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/456/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E5D09B344;\n\tTue, 23 Sep 2014 13:02:36 +0200 (CEST)",
            "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 22B98137D\n\tfor <dev@dpdk.org>; Tue, 23 Sep 2014 13:02:35 +0200 (CEST)",
            "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga103.fm.intel.com with ESMTP; 23 Sep 2014 03:59:14 -0700",
            "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby FMSMGA003.fm.intel.com with ESMTP; 23 Sep 2014 04:02:28 -0700",
            "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\ts8NB8ILC012723; Tue, 23 Sep 2014 12:08:18 +0100",
            "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id s8NB8IHR010435;\n\tTue, 23 Sep 2014 12:08:18 +0100",
            "(from bricha3@localhost)\n\tby sivswdev02.ir.intel.com with  id s8NB8IbE010431;\n\tTue, 23 Sep 2014 12:08:18 +0100"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"4.97,862,1389772800\"; d=\"scan'208\";a=\"390290433\"",
        "From": "Bruce Richardson <bruce.richardson@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Tue, 23 Sep 2014 12:08:15 +0100",
        "Message-Id": "<1411470497-10209-4-git-send-email-bruce.richardson@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1411470497-10209-1-git-send-email-bruce.richardson@intel.com>",
        "References": "<1410948102-12740-1-git-send-email-bruce.richardson@intel.com>\n\t<1411470497-10209-1-git-send-email-bruce.richardson@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2 3/5] testpmd: Change rxfreet default to 32",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "To improve performance by using bulk alloc or vectored RX routines, we\nneed to set rx free threshold (rxfreet) value to 32, so make this the\ntestpmd default.\n\nThirty-two is the minimum setting needed to enable either the\nbulk alloc or vector RX routines inside the ixgbe driver, so it's\nbest made the default for that reason. Please see\n\"check_rx_burst_bulk_alloc_preconditions()\" in ixgbe_rxtx.c, and\nRX function assignment logic in \"ixgbe_dev_rx_queue_setup()\" in\nthe same file.\n\nThe difference in IO performance for testpmd when called without any\noptional parameters, and using 10G NICs using the ixgbe driver, can be\nsignificant - approx 25% or more.\n\nUpdates in V2:\n* Updated commit message with additional details\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n app/test-pmd/testpmd.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 9f6cdc4..f76406f 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -225,7 +225,9 @@ struct rte_eth_thresh tx_thresh = {\n /*\n  * Configurable value of RX free threshold.\n  */\n-uint16_t rx_free_thresh = 0; /* Immediately free RX descriptors by default. */\n+uint16_t rx_free_thresh = 32; /* Refill RX descriptors once every 32 packets,\n+\t\tThis setting is needed for ixgbe to enable bulk alloc or vector\n+\t\treceive functionality. */\n \n /*\n  * Configurable value of RX drop enable.\n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "3/5"
    ]
}