Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 45563,
    "url": "http://patches.dpdk.org/api/patches/45563/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180928072453.6348-1-xiaoyun.li@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180928072453.6348-1-xiaoyun.li@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180928072453.6348-1-xiaoyun.li@intel.com",
    "date": "2018-09-28T07:24:53",
    "name": "net/i40e: select fdir config automatically",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "b4cf8af44b47fecad0a734bb4811b277a38a0fe6",
    "submitter": {
        "id": 798,
        "url": "http://patches.dpdk.org/api/people/798/?format=api",
        "name": "Li, Xiaoyun",
        "email": "xiaoyun.li@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180928072453.6348-1-xiaoyun.li@intel.com/mbox/",
    "series": [
        {
            "id": 1565,
            "url": "http://patches.dpdk.org/api/series/1565/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1565",
            "date": "2018-09-28T07:24:53",
            "name": "net/i40e: select fdir config automatically",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/1565/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/45563/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/45563/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 935C31B114;\n\tFri, 28 Sep 2018 09:33:13 +0200 (CEST)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id DA0011B110\n\tfor <dev@dpdk.org>; Fri, 28 Sep 2018 09:33:11 +0200 (CEST)",
            "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Sep 2018 00:33:11 -0700",
            "from dpdk-xiaoyun3.sh.intel.com ([10.67.119.56])\n\tby orsmga005.jf.intel.com with ESMTP; 28 Sep 2018 00:33:09 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.54,313,1534834800\"; d=\"scan'208\";a=\"261148390\"",
        "From": "Xiaoyun Li <xiaoyun.li@intel.com>",
        "To": "ferruh.yigit@intel.com, qi.z.zhang@intel.com, beilei.xing@intel.com,\n\tdev@dpdk.org",
        "Cc": "Xiaoyun Li <xiaoyun.li@intel.com>",
        "Date": "Fri, 28 Sep 2018 15:24:53 +0800",
        "Message-Id": "<20180928072453.6348-1-xiaoyun.li@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "Subject": "[dpdk-dev] [PATCH] net/i40e: select fdir config automatically",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "I40e driver needed users to config exact fdir mode to create rte_flow\nrules but it shouldn't. This patch allows users to create rte_flow rules\nwithout configuring fdir mode and let the driver select the config\nautomatically.\n\nSigned-off-by: Xiaoyun Li <xiaoyun.li@intel.com>\n---\n drivers/net/i40e/i40e_flow.c | 33 ++++++++++++++++++++++++++++-----\n 1 file changed, 28 insertions(+), 5 deletions(-)",
    "diff": "diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c\nindex c67b264de..70ff33ac0 100644\n--- a/drivers/net/i40e/i40e_flow.c\n+++ b/drivers/net/i40e/i40e_flow.c\n@@ -3127,6 +3127,7 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev *dev,\n \t\t\t    struct rte_flow_error *error,\n \t\t\t    union i40e_filter_t *filter)\n {\n+\tstruct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);\n \tstruct i40e_fdir_filter_conf *fdir_filter =\n \t\t&filter->fdir_filter;\n \tint ret;\n@@ -3148,14 +3149,29 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev *dev,\n \n \tif (dev->data->dev_conf.fdir_conf.mode !=\n \t    RTE_FDIR_MODE_PERFECT) {\n-\t\trte_flow_error_set(error, ENOTSUP,\n-\t\t\t\t   RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n-\t\t\t\t   NULL,\n-\t\t\t\t   \"Check the mode in fdir_conf.\");\n-\t\treturn -rte_errno;\n+\t\t/* Enable fdir when fdir flow is added at first time. */\n+\t\tret = i40e_fdir_setup(pf);\n+\t\tif (ret != I40E_SUCCESS) {\n+\t\t\trte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t   RTE_FLOW_ERROR_TYPE_HANDLE,\n+\t\t\t\t\t   NULL, \"Failed to setup fdir.\");\n+\t\t\treturn -rte_errno;\n+\t\t}\n+\t\tret = i40e_fdir_configure(dev);\n+\t\tif (ret < 0) {\n+\t\t\trte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t   RTE_FLOW_ERROR_TYPE_HANDLE,\n+\t\t\t\t\t   NULL, \"Failed to configure fdir.\");\n+\t\t\tgoto err;\n+\t\t}\n+\n+\t\tdev->data->dev_conf.fdir_conf.mode = RTE_FDIR_MODE_PERFECT;\n \t}\n \n \treturn 0;\n+err:\n+\ti40e_fdir_teardown(pf);\n+\treturn -rte_errno;\n }\n \n /* Parse to get the action info of a tunnel filter\n@@ -4708,6 +4724,13 @@ i40e_flow_destroy(struct rte_eth_dev *dev,\n \tcase RTE_ETH_FILTER_FDIR:\n \t\tret = i40e_flow_add_del_fdir_filter(dev,\n \t\t       &((struct i40e_fdir_filter *)flow->rule)->fdir, 0);\n+\n+\t\t/* If the last flow is destroyed, disable fdir. */\n+\t\tif (!ret && !TAILQ_FIRST(&pf->fdir.fdir_list)) {\n+\t\t\ti40e_fdir_teardown(pf);\n+\t\t\tdev->data->dev_conf.fdir_conf.mode =\n+\t\t\t\t   RTE_FDIR_MODE_NONE;\n+\t\t}\n \t\tbreak;\n \tcase RTE_ETH_FILTER_HASH:\n \t\tret = i40e_config_rss_filter_del(dev,\n",
    "prefixes": []
}