Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45550/?format=api
{ "id": 45550, "url": "http://patches.dpdk.org/api/patches/45550/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180928042326.50471-2-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180928042326.50471-2-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180928042326.50471-2-qi.z.zhang@intel.com", "date": "2018-09-28T04:23:21", "name": "[v16,1/6] ethdev: add function to release port in secondary process", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6bbd558ca538a9ddc9ea41d815a05035be1b8801", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180928042326.50471-2-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 1562, "url": "http://patches.dpdk.org/api/series/1562/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1562", "date": "2018-09-28T04:23:20", "name": "enable hotplug on multi-process", "version": 16, "mbox": "http://patches.dpdk.org/series/1562/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45550/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45550/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7F33A1B13E;\n\tFri, 28 Sep 2018 06:22:55 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 0F21D1B11C\n\tfor <dev@dpdk.org>; Fri, 28 Sep 2018 06:22:52 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Sep 2018 21:22:52 -0700", "from dpdk51.sh.intel.com ([10.67.110.190])\n\tby fmsmga005.fm.intel.com with ESMTP; 27 Sep 2018 21:22:28 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,313,1534834800\"; d=\"scan'208\";a=\"266654779\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "thomas@monjalon.net, gaetan.rivet@6wind.com, anatoly.burakov@intel.com, \n\tarybchenko@solarflare.com", "Cc": "konstantin.ananyev@intel.com, dev@dpdk.org, bruce.richardson@intel.com, \n\tferruh.yigit@intel.com, benjamin.h.shelton@intel.com,\n\tnarender.vangati@intel.com, Qi Zhang <qi.z.zhang@intel.com>", "Date": "Fri, 28 Sep 2018 12:23:21 +0800", "Message-Id": "<20180928042326.50471-2-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20180928042326.50471-1-qi.z.zhang@intel.com>", "References": "<20180607123849.14439-1-qi.z.zhang@intel.com>\n\t<20180928042326.50471-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v16 1/6] ethdev: add function to release port in\n\tsecondary process", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add driver API rte_eth_release_port_secondary to support the\ncase when an ethdev need to be detached on a secondary process.\nLocal state is set to unused and shared data will not be reset\nso the primary process can still use it.\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n lib/librte_ethdev/rte_ethdev.c | 17 +++++++++++++++--\n lib/librte_ethdev/rte_ethdev_driver.h | 16 +++++++++++++++-\n lib/librte_ethdev/rte_ethdev_pci.h | 10 ++++++++--\n lib/librte_ethdev/rte_ethdev_version.map | 7 +++++++\n 4 files changed, 45 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex aa7730ce2..c58b1c6ed 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -360,6 +360,18 @@ rte_eth_dev_attach_secondary(const char *name)\n }\n \n int\n+rte_eth_dev_release_port_secondary(struct rte_eth_dev *eth_dev)\n+{\n+\tif (eth_dev == NULL)\n+\t\treturn -EINVAL;\n+\n+\t_rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_DESTROY, NULL);\n+\teth_dev->state = RTE_ETH_DEV_UNUSED;\n+\n+\treturn 0;\n+}\n+\n+int\n rte_eth_dev_release_port(struct rte_eth_dev *eth_dev)\n {\n \tif (eth_dev == NULL)\n@@ -3540,9 +3552,10 @@ rte_eth_dev_destroy(struct rte_eth_dev *ethdev,\n \t\t\treturn ret;\n \t}\n \n-\tif (rte_eal_process_type() == RTE_PROC_PRIMARY)\n-\t\trte_free(ethdev->data->dev_private);\n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn rte_eth_dev_release_port_secondary(ethdev);\n \n+\trte_free(ethdev->data->dev_private);\n \tethdev->data->dev_private = NULL;\n \n \treturn rte_eth_dev_release_port(ethdev);\ndiff --git a/lib/librte_ethdev/rte_ethdev_driver.h b/lib/librte_ethdev/rte_ethdev_driver.h\nindex f158462a0..ca31b5777 100644\n--- a/lib/librte_ethdev/rte_ethdev_driver.h\n+++ b/lib/librte_ethdev/rte_ethdev_driver.h\n@@ -61,7 +61,7 @@ struct rte_eth_dev *rte_eth_dev_attach_secondary(const char *name);\n * Release the specified ethdev port.\n *\n * @param eth_dev\n- * The *eth_dev* pointer is the address of the *rte_eth_dev* structure.\n+ * Device to be detached.\n * @return\n * - 0 on success, negative on error\n */\n@@ -69,6 +69,20 @@ int rte_eth_dev_release_port(struct rte_eth_dev *eth_dev);\n \n /**\n * @internal\n+ * Release the specified ethdev port in the local process.\n+ * Only set ethdev state to unused, but not reset shared data since\n+ * it assume other processes is still using it. typically it is\n+ * called by a secondary process.\n+ *\n+ * @param eth_dev\n+ * Device to be detached.\n+ * @return\n+ * - 0 on success, negative on error\n+ */\n+int rte_eth_dev_release_port_secondary(struct rte_eth_dev *eth_dev);\n+\n+/**\n+ * @internal\n * Release device queues and clear its configuration to force the user\n * application to reconfigure it. It is for internal use only.\n *\ndiff --git a/lib/librte_ethdev/rte_ethdev_pci.h b/lib/librte_ethdev/rte_ethdev_pci.h\nindex f652596f4..70d2d2503 100644\n--- a/lib/librte_ethdev/rte_ethdev_pci.h\n+++ b/lib/librte_ethdev/rte_ethdev_pci.h\n@@ -135,9 +135,15 @@ rte_eth_dev_pci_allocate(struct rte_pci_device *dev, size_t private_data_size)\n static inline void\n rte_eth_dev_pci_release(struct rte_eth_dev *eth_dev)\n {\n-\tif (rte_eal_process_type() == RTE_PROC_PRIMARY)\n-\t\trte_free(eth_dev->data->dev_private);\n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY) {\n+\t\teth_dev->device = NULL;\n+\t\teth_dev->intr_handle = NULL;\n+\t\trte_eth_dev_release_port_secondary(eth_dev);\n+\t\treturn;\n+\t}\n \n+\t/* primary process */\n+\trte_free(eth_dev->data->dev_private);\n \teth_dev->data->dev_private = NULL;\n \n \t/*\ndiff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map\nindex 38f117f01..acc407f86 100644\n--- a/lib/librte_ethdev/rte_ethdev_version.map\n+++ b/lib/librte_ethdev/rte_ethdev_version.map\n@@ -220,6 +220,13 @@ DPDK_18.08 {\n \n } DPDK_18.05;\n \n+DPDK_18.11 {\n+\tglobal:\n+\n+\trte_eth_dev_release_port_secondary;\n+\n+} DPDK_18.08;\n+\n EXPERIMENTAL {\n \tglobal:\n \n", "prefixes": [ "v16", "1/6" ] }