Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45530/?format=api
{ "id": 45530, "url": "http://patches.dpdk.org/api/patches/45530/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1538056677-33846-4-git-send-email-dekelp@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1538056677-33846-4-git-send-email-dekelp@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1538056677-33846-4-git-send-email-dekelp@mellanox.com", "date": "2018-09-27T13:57:57", "name": "[v3,3/3] app/testpmd: add debug command Tx metadata set", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8e0c9091bde05b42b3c4c308ad9516f135bc4b07", "submitter": { "id": 1082, "url": "http://patches.dpdk.org/api/people/1082/?format=api", "name": "Dekel Peled", "email": "dekelp@mellanox.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1538056677-33846-4-git-send-email-dekelp@mellanox.com/mbox/", "series": [ { "id": 1336, "url": "http://patches.dpdk.org/api/series/1336/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1336", "date": "2018-09-16T14:37:47", "name": "*** SUBJECT HERE ***", "version": 2, "mbox": "http://patches.dpdk.org/series/1336/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45530/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45530/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 528961B4FC;\n\tThu, 27 Sep 2018 15:59:57 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 593B61B503\n\tfor <dev@dpdk.org>; Thu, 27 Sep 2018 15:59:54 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tdekelp@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 27 Sep 2018 16:04:24 +0200", "from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx\n\t[10.128.130.87])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id w8RDxe6p015805;\n\tThu, 27 Sep 2018 16:59:50 +0300" ], "From": "Dekel Peled <dekelp@mellanox.com>", "To": "wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com,\n\tdev@dpdk.org, olivier.matz@6wind.com, adrien.mazarguil@6wind.com,\n\tthomas@monjalon.net, ferruh.yigit@intel.com, arybchenko@solarflare.com", "Cc": "shahafs@mellanox.com, orika@mellanox.com", "Date": "Thu, 27 Sep 2018 16:57:57 +0300", "Message-Id": "<1538056677-33846-4-git-send-email-dekelp@mellanox.com>", "X-Mailer": "git-send-email 1.7.1", "In-Reply-To": "<1537108670-11380-1-git-send-email-dekelp@mellanox.com>", "References": "<1537108670-11380-1-git-send-email-dekelp@mellanox.com>", "Subject": "[dpdk-dev] [PATCH v3 3/3] app/testpmd: add debug command Tx\n\tmetadata set", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As described in [1],[2] this series adds option to set metadata value as\nmatch pattern when creating a new flow rule.\n\nThis patch introduces code for debug porpuse only.\nThe new debug command takes a 32 bit value and stores it per port.\ntestpmd will add to any Tx packet sent from this port the metadata\nvalue, and set ol_flags accordingly.\n\n[1] \"ethdev: support metadata as flow rule criteria\"\n[2] \"app/testpmd: support metadata as flow rule criteria\"\n\nSigned-off-by: Dekel Peled <dekelp@mellanox.com>\n---\n app/test-pmd/cmdline.c | 46 +++++++++++++++++++++++++++++\n app/test-pmd/config.c | 6 ++++\n app/test-pmd/testpmd.c | 1 +\n app/test-pmd/testpmd.h | 4 +++\n app/test-pmd/txonly.c | 9 ++++++\n doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +++++\n 6 files changed, 73 insertions(+)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 8cfde40..0f0e3ee 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -17602,6 +17602,51 @@ struct cmd_config_per_queue_tx_offload_result {\n \t}\n };\n \n+/* *** ENABLE METADATA INSERTION IN TX PACKETS SENT TO PMD *** */\n+struct cmd_tx_metadata_set_result {\n+\tcmdline_fixed_string_t tx_metadata;\n+\tcmdline_fixed_string_t set;\n+\tportid_t port_id;\n+\tuint32_t metadata;\n+};\n+\n+static void\n+cmd_tx_metadata_set_parsed(void *parsed_result,\n+\t\t __attribute__((unused)) struct cmdline *cl,\n+\t\t __attribute__((unused)) void *data)\n+{\n+\tstruct cmd_tx_metadata_set_result *res = parsed_result;\n+\n+\ttx_metadata_set(res->port_id, res->metadata);\n+}\n+\n+cmdline_parse_token_string_t cmd_tx_metadata_set_tx_metadata =\n+\tTOKEN_STRING_INITIALIZER(struct cmd_tx_metadata_set_result,\n+\t\t\t\ttx_metadata, \"tx_metadata\");\n+cmdline_parse_token_string_t cmd_tx_metadata_set_set =\n+\tTOKEN_STRING_INITIALIZER(struct cmd_tx_metadata_set_result,\n+\t\t\t\t set, \"set\");\n+cmdline_parse_token_num_t cmd_tx_metadata_set_portid =\n+\tTOKEN_NUM_INITIALIZER(struct cmd_tx_metadata_set_result,\n+\t\t\t port_id, UINT16);\n+cmdline_parse_token_num_t cmd_tx_metadata_set_metadata =\n+\tTOKEN_NUM_INITIALIZER(struct cmd_tx_metadata_set_result,\n+\t\t\t metadata, UINT32);\n+\n+cmdline_parse_inst_t cmd_tx_metadata_set = {\n+\t.f = cmd_tx_metadata_set_parsed,\n+\t.data = NULL,\n+\t.help_str = \"tx_metadata set <port_id> <metadata>: \"\n+\t\t \"Enable metadata insertion in packets sent to PMD\",\n+\t.tokens = {\n+\t\t(void *)&cmd_tx_metadata_set_tx_metadata,\n+\t\t(void *)&cmd_tx_metadata_set_set,\n+\t\t(void *)&cmd_tx_metadata_set_portid,\n+\t\t(void *)&cmd_tx_metadata_set_metadata,\n+\t\tNULL,\n+\t},\n+};\n+\n /* ******************************************************************************** */\n \n /* list of instructions */\n@@ -17867,6 +17912,7 @@ struct cmd_config_per_queue_tx_offload_result {\n \t(cmdline_parse_inst_t *)&cmd_operate_bpf_ld_parse,\n \t(cmdline_parse_inst_t *)&cmd_operate_bpf_unld_parse,\n #endif\n+\t(cmdline_parse_inst_t *)&cmd_tx_metadata_set,\n \tNULL,\n };\n \ndiff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex 274c392..7aa40d6 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -3845,3 +3845,9 @@ struct igb_ring_desc_16_bytes {\n \n \tprintf(\"\\n\\n\");\n }\n+\n+void\n+tx_metadata_set(portid_t port_id, uint32_t metadata)\n+{\n+\tports[port_id].metadata = metadata;\n+}\ndiff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 268a80c..caf26be 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -771,6 +771,7 @@ static void eth_dev_event_callback(char *device_name,\n \t\t/* set flag to initialize port/queue */\n \t\tport->need_reconfig = 1;\n \t\tport->need_reconfig_queues = 1;\n+\t\tport->metadata = 0;\n \t}\n \n \t/*\ndiff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h\nindex a1f6614..54c7e95 100644\n--- a/app/test-pmd/testpmd.h\n+++ b/app/test-pmd/testpmd.h\n@@ -183,6 +183,8 @@ struct rte_port {\n #ifdef SOFTNIC\n \tstruct softnic_port softport; /**< softnic params */\n #endif\n+\t/* metadata value to add in tx packets (debug only) */\n+\tuint32_t metadata;\n };\n \n /**\n@@ -743,6 +745,8 @@ enum print_warning {\n queueid_t get_allowed_max_nb_txq(portid_t *pid);\n int check_nb_txq(queueid_t txq);\n \n+void tx_metadata_set(portid_t port_id, uint32_t metadata);\n+\n /*\n * Work-around of a compilation error with ICC on invocations of the\n * rte_be_to_cpu_16() function.\ndiff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c\nindex 1f08b6e..b5a4b35 100644\n--- a/app/test-pmd/txonly.c\n+++ b/app/test-pmd/txonly.c\n@@ -253,6 +253,15 @@\n \t\tpkt->l2_len = sizeof(struct ether_hdr);\n \t\tpkt->l3_len = sizeof(struct ipv4_hdr);\n \t\tpkts_burst[nb_pkt] = pkt;\n+\n+\t\t/*\n+\t\t * If user configured metadata value add it to packet\n+\t\t * and set ol_flags accordingly\n+\t\t */\n+\t\tif (ports[fs->tx_port].metadata) {\n+\t\t\tpkt->hash.fdir.hi = ports[fs->tx_port].metadata;\n+\t\t\tpkt->ol_flags |= PKT_TX_METADATA;\n+\t\t}\n \t}\n \tnb_tx = rte_eth_tx_burst(fs->tx_port, fs->tx_queue, pkts_burst, nb_pkt);\n \t/*\ndiff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\nindex 853ab83..dd843a5 100644\n--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n@@ -851,6 +851,13 @@ Disable hardware insertion of a VLAN header in packets sent on a port::\n \n testpmd> tx_vlan reset (port_id)\n \n+tx_metadata set\n+~~~~~~~~~~~~~~~\n+\n+Set metadata value to insert in packets sent to PMD::\n+\n+ testpmd> tx_metadata set (port_id) (value)\n+\n csum set\n ~~~~~~~~\n \n", "prefixes": [ "v3", "3/3" ] }