Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45529/?format=api
{ "id": 45529, "url": "http://patches.dpdk.org/api/patches/45529/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1538056677-33846-3-git-send-email-dekelp@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1538056677-33846-3-git-send-email-dekelp@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1538056677-33846-3-git-send-email-dekelp@mellanox.com", "date": "2018-09-27T13:57:56", "name": "[v3,2/3] app/testpmd: support metadata as flow rule criteria", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c364fdfb9944b67b5e665f9b3b296359573843b4", "submitter": { "id": 1082, "url": "http://patches.dpdk.org/api/people/1082/?format=api", "name": "Dekel Peled", "email": "dekelp@mellanox.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1538056677-33846-3-git-send-email-dekelp@mellanox.com/mbox/", "series": [ { "id": 1336, "url": "http://patches.dpdk.org/api/series/1336/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1336", "date": "2018-09-16T14:37:47", "name": "*** SUBJECT HERE ***", "version": 2, "mbox": "http://patches.dpdk.org/series/1336/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45529/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45529/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6B4D91B4FD;\n\tThu, 27 Sep 2018 15:59:52 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 645621B4F7\n\tfor <dev@dpdk.org>; Thu, 27 Sep 2018 15:59:49 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tdekelp@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 27 Sep 2018 16:04:19 +0200", "from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx\n\t[10.128.130.87])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id w8RDxe6o015805;\n\tThu, 27 Sep 2018 16:59:45 +0300" ], "From": "Dekel Peled <dekelp@mellanox.com>", "To": "wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com,\n\tdev@dpdk.org, olivier.matz@6wind.com, adrien.mazarguil@6wind.com,\n\tthomas@monjalon.net, ferruh.yigit@intel.com, arybchenko@solarflare.com", "Cc": "shahafs@mellanox.com, orika@mellanox.com", "Date": "Thu, 27 Sep 2018 16:57:56 +0300", "Message-Id": "<1538056677-33846-3-git-send-email-dekelp@mellanox.com>", "X-Mailer": "git-send-email 1.7.1", "In-Reply-To": "<1537108670-11380-1-git-send-email-dekelp@mellanox.com>", "References": "<1537108670-11380-1-git-send-email-dekelp@mellanox.com>", "Subject": "[dpdk-dev] [PATCH v3 2/3] app/testpmd: support metadata as flow\n\trule criteria", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As described in [1], this series adds option to set metadata value as\nmatch pattern when creating a new flow rule.\n\nThis patch introduces additional options in testpmd commands.\nNew item type \"meta\" \"data\", new offload flag \"match_metadata\".\n\n[1] \"ethdev: support metadata as flow rule criteria\"\n\nSigned-off-by: Dekel Peled <dekelp@mellanox.com>\n---\n app/test-pmd/cmdline.c | 14 ++++++++------\n app/test-pmd/cmdline_flow.c | 25 +++++++++++++++++++++++++\n app/test-pmd/config.c | 1 +\n app/test-pmd/testpmd.c | 4 ++++\n doc/guides/testpmd_app_ug/testpmd_funcs.rst | 6 +++++-\n 5 files changed, 43 insertions(+), 7 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 0cbd340..8cfde40 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -17401,7 +17401,8 @@ struct cmd_config_per_port_tx_offload_result {\n \t\t\t \"sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#\"\n \t\t\t \"qinq_insert#vxlan_tnl_tso#gre_tnl_tso#\"\n \t\t\t \"ipip_tnl_tso#geneve_tnl_tso#macsec_insert#\"\n-\t\t\t \"mt_lockfree#multi_segs#mbuf_fast_free#security\");\n+\t\t\t \"mt_lockfree#multi_segs#mbuf_fast_free#security#\"\n+\t\t\t \"match_metadata\");\n cmdline_parse_token_string_t cmd_config_per_port_tx_offload_result_on_off =\n \tTOKEN_STRING_INITIALIZER\n \t\t(struct cmd_config_per_port_tx_offload_result,\n@@ -17482,8 +17483,8 @@ struct cmd_config_per_port_tx_offload_result {\n \t\t \"sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|\"\n \t\t \"qinq_insert|vxlan_tnl_tso|gre_tnl_tso|\"\n \t\t \"ipip_tnl_tso|geneve_tnl_tso|macsec_insert|\"\n-\t\t \"mt_lockfree|multi_segs|mbuf_fast_free|security \"\n-\t\t \"on|off\",\n+\t\t \"mt_lockfree|multi_segs|mbuf_fast_free|security|\"\n+\t\t \"match_metadata on|off\",\n \t.tokens = {\n \t\t(void *)&cmd_config_per_port_tx_offload_result_port,\n \t\t(void *)&cmd_config_per_port_tx_offload_result_config,\n@@ -17533,7 +17534,8 @@ struct cmd_config_per_queue_tx_offload_result {\n \t\t\t \"sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#\"\n \t\t\t \"qinq_insert#vxlan_tnl_tso#gre_tnl_tso#\"\n \t\t\t \"ipip_tnl_tso#geneve_tnl_tso#macsec_insert#\"\n-\t\t\t \"mt_lockfree#multi_segs#mbuf_fast_free#security\");\n+\t\t\t \"mt_lockfree#multi_segs#mbuf_fast_free#security#\"\n+\t\t\t \"match_metadata\");\n cmdline_parse_token_string_t cmd_config_per_queue_tx_offload_result_on_off =\n \tTOKEN_STRING_INITIALIZER\n \t\t(struct cmd_config_per_queue_tx_offload_result,\n@@ -17586,8 +17588,8 @@ struct cmd_config_per_queue_tx_offload_result {\n \t\t \"sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|\"\n \t\t \"qinq_insert|vxlan_tnl_tso|gre_tnl_tso|\"\n \t\t \"ipip_tnl_tso|geneve_tnl_tso|macsec_insert|\"\n-\t\t \"mt_lockfree|multi_segs|mbuf_fast_free|security \"\n-\t\t \"on|off\",\n+\t\t \"mt_lockfree|multi_segs|mbuf_fast_free|security|\"\n+\t\t \"match_metadata on|off\",\n \t.tokens = {\n \t\t(void *)&cmd_config_per_queue_tx_offload_result_port,\n \t\t(void *)&cmd_config_per_queue_tx_offload_result_port_id,\ndiff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex 349e822..8f997e4 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -178,6 +178,8 @@ enum index {\n \tITEM_ICMP6_ND_OPT_SLA_ETH_SLA,\n \tITEM_ICMP6_ND_OPT_TLA_ETH,\n \tITEM_ICMP6_ND_OPT_TLA_ETH_TLA,\n+\tITEM_META,\n+\tITEM_META_DATA,\n \n \t/* Validate/create actions. */\n \tACTIONS,\n@@ -540,6 +542,7 @@ struct parse_action_priv {\n \tITEM_ICMP6_ND_OPT,\n \tITEM_ICMP6_ND_OPT_SLA_ETH,\n \tITEM_ICMP6_ND_OPT_TLA_ETH,\n+\tITEM_META,\n \tZERO,\n };\n \n@@ -760,6 +763,12 @@ struct parse_action_priv {\n \tZERO,\n };\n \n+static const enum index item_meta[] = {\n+\tITEM_META_DATA,\n+\tITEM_NEXT,\n+\tZERO,\n+};\n+\n static const enum index next_action[] = {\n \tACTION_END,\n \tACTION_VOID,\n@@ -1961,6 +1970,22 @@ static int comp_vc_action_rss_queue(struct context *, const struct token *,\n \t\t.args = ARGS(ARGS_ENTRY_HTON\n \t\t\t (struct rte_flow_item_icmp6_nd_opt_tla_eth, tla)),\n \t},\n+\t[ITEM_META] = {\n+\t\t.name = \"meta\",\n+\t\t.help = \"match metadata header\",\n+\t\t.priv = PRIV_ITEM(META, sizeof(struct rte_flow_item_meta)),\n+\t\t.next = NEXT(item_meta),\n+\t\t.call = parse_vc,\n+\t},\n+\t[ITEM_META_DATA] = {\n+\t\t.name = \"data\",\n+\t\t.help = \"metadata value\",\n+\t\t.next = NEXT(item_meta, NEXT_ENTRY(UNSIGNED), item_param),\n+\t\t.args = ARGS(ARGS_ENTRY_MASK_HTON(struct rte_flow_item_meta,\n+\t\t\t\t\t\t\tdata,\n+\t\t\t\t\t\t\t\"\\xff\\xff\\xff\\xff\"\n+\t\t\t\t\t\t\t\"\\xff\\xff\\xff\\xff\")),\n+\t},\n \n \t/* Validate/create actions. */\n \t[ACTIONS] = {\ndiff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex 7d384d9..274c392 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -1043,6 +1043,7 @@ void print_valid_ports(void)\n \t\t sizeof(struct rte_flow_item_icmp6_nd_opt_sla_eth)),\n \tMK_FLOW_ITEM(ICMP6_ND_OPT_TLA_ETH,\n \t\t sizeof(struct rte_flow_item_icmp6_nd_opt_tla_eth)),\n+\tMK_FLOW_ITEM(META, sizeof(struct rte_flow_item_meta)),\n };\n \n /** Pattern item specification types. */\ndiff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 571ecb4..268a80c 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -742,6 +742,10 @@ static void eth_dev_event_callback(char *device_name,\n \t\t DEV_TX_OFFLOAD_MBUF_FAST_FREE))\n \t\t\tport->dev_conf.txmode.offloads &=\n \t\t\t\t~DEV_TX_OFFLOAD_MBUF_FAST_FREE;\n+\t\tif (!(port->dev_info.tx_offload_capa &\n+\t\t\tDEV_TX_OFFLOAD_MATCH_METADATA))\n+\t\t\tport->dev_conf.txmode.offloads &=\n+\t\t\t\t~DEV_TX_OFFLOAD_MATCH_METADATA;\n \t\tif (numa_support) {\n \t\t\tif (port_numa[pid] != NUMA_NO_CONFIG)\n \t\t\t\tport_per_socket[port_numa[pid]]++;\ndiff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\nindex dde205a..853ab83 100644\n--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n@@ -3511,11 +3511,15 @@ This section lists supported pattern items and their attributes, if any.\n \n - ``sla {MAC-48}``: source Ethernet LLA.\n \n-- ``icmp6_nd_opt_sla_eth``: match ICMPv6 neighbor discovery target Ethernet\n+- ``icmp6_nd_opt_tla_eth``: match ICMPv6 neighbor discovery target Ethernet\n link-layer address option.\n \n - ``tla {MAC-48}``: target Ethernet LLA.\n \n+- ``meta``: match application specific metadata.\n+\n+ - ``data``: metadata value.\n+\n Actions list\n ^^^^^^^^^^^^\n \n", "prefixes": [ "v3", "2/3" ] }