Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45472/?format=api
{ "id": 45472, "url": "http://patches.dpdk.org/api/patches/45472/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1538014382-7584-1-git-send-email-beilei.xing@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1538014382-7584-1-git-send-email-beilei.xing@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1538014382-7584-1-git-send-email-beilei.xing@intel.com", "date": "2018-09-27T02:13:02", "name": "[v2] net/i40e: remove keeping CRC configuration for VF", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6075d0c47e1e0aa3aaa05a456a9526288e007174", "submitter": { "id": 410, "url": "http://patches.dpdk.org/api/people/410/?format=api", "name": "Xing, Beilei", "email": "beilei.xing@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1538014382-7584-1-git-send-email-beilei.xing@intel.com/mbox/", "series": [ { "id": 1531, "url": "http://patches.dpdk.org/api/series/1531/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1531", "date": "2018-09-27T02:13:02", "name": "[v2] net/i40e: remove keeping CRC configuration for VF", "version": 2, "mbox": "http://patches.dpdk.org/series/1531/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45472/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45472/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1167C1B193;\n\tThu, 27 Sep 2018 04:14:00 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 890FC160\n\tfor <dev@dpdk.org>; Thu, 27 Sep 2018 04:13:58 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Sep 2018 19:13:57 -0700", "from unknown (HELO dpdk9.sh.intel.com) ([10.67.118.52])\n\tby fmsmga005.fm.intel.com with ESMTP; 26 Sep 2018 19:13:56 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,308,1534834800\"; d=\"scan'208\";a=\"266064418\"", "From": "Beilei Xing <beilei.xing@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org", "Date": "Thu, 27 Sep 2018 10:13:02 +0800", "Message-Id": "<1538014382-7584-1-git-send-email-beilei.xing@intel.com>", "X-Mailer": "git-send-email 2.5.5", "In-Reply-To": "<1537926663-21153-1-git-send-email-beilei.xing@intel.com>", "References": "<1537926663-21153-1-git-send-email-beilei.xing@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] net/i40e: remove keeping CRC configuration\n\tfor VF", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Remove keeping CRC configuration since it's not\nsupported by i40e VF.\n\nSigned-off-by: Beilei Xing <beilei.xing@intel.com>\n---\n drivers/net/i40e/i40e_ethdev_vf.c | 16 ----------------\n 1 file changed, 16 deletions(-)\n\nv2 changes:\n - Remove the whole branch since offload has been checked in rte_eth_dev_configure.", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c\nindex f9cedf5..5713fd1 100644\n--- a/drivers/net/i40e/i40e_ethdev_vf.c\n+++ b/drivers/net/i40e/i40e_ethdev_vf.c\n@@ -1522,8 +1522,6 @@ i40evf_dev_configure(struct rte_eth_dev *dev)\n {\n \tstruct i40e_adapter *ad =\n \t\tI40E_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n-\tstruct rte_eth_conf *conf = &dev->data->dev_conf;\n-\tstruct i40e_vf *vf;\n \n \t/* Initialize to TRUE. If any of Rx queues doesn't meet the bulk\n \t * allocation or vector Rx preconditions we will reset it.\n@@ -1533,19 +1531,6 @@ i40evf_dev_configure(struct rte_eth_dev *dev)\n \tad->tx_simple_allowed = true;\n \tad->tx_vec_allowed = true;\n \n-\t/* For non-DPDK PF drivers, VF has no ability to disable HW\n-\t * CRC strip, and is implicitly enabled by the PF.\n-\t */\n-\tif (conf->rxmode.offloads & DEV_RX_OFFLOAD_KEEP_CRC) {\n-\t\tvf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);\n-\t\tif ((vf->version_major == VIRTCHNL_VERSION_MAJOR) &&\n-\t\t (vf->version_minor <= VIRTCHNL_VERSION_MINOR)) {\n-\t\t\t/* Peer is running non-DPDK PF driver. */\n-\t\t\tPMD_INIT_LOG(ERR, \"VF can't disable HW CRC Strip\");\n-\t\t\treturn -EINVAL;\n-\t\t}\n-\t}\n-\n \treturn i40evf_init_vlan(dev);\n }\n \n@@ -2180,7 +2165,6 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \t\tDEV_RX_OFFLOAD_UDP_CKSUM |\n \t\tDEV_RX_OFFLOAD_TCP_CKSUM |\n \t\tDEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |\n-\t\tDEV_RX_OFFLOAD_KEEP_CRC |\n \t\tDEV_RX_OFFLOAD_SCATTER |\n \t\tDEV_RX_OFFLOAD_JUMBO_FRAME |\n \t\tDEV_RX_OFFLOAD_VLAN_FILTER;\n", "prefixes": [ "v2" ] }