Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 45368,
    "url": "http://patches.dpdk.org/api/patches/45368/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180926090456.42495-1-xiaoyun.li@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180926090456.42495-1-xiaoyun.li@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180926090456.42495-1-xiaoyun.li@intel.com",
    "date": "2018-09-26T09:04:56",
    "name": "[v2] net/ixgbe: firmware status check",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "a7c77360114ab48977cfa1a78bf27f1e608f1bc3",
    "submitter": {
        "id": 798,
        "url": "http://patches.dpdk.org/api/people/798/?format=api",
        "name": "Li, Xiaoyun",
        "email": "xiaoyun.li@intel.com"
    },
    "delegate": {
        "id": 1540,
        "url": "http://patches.dpdk.org/api/users/1540/?format=api",
        "username": "qzhan15",
        "first_name": "Qi",
        "last_name": "Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180926090456.42495-1-xiaoyun.li@intel.com/mbox/",
    "series": [
        {
            "id": 1512,
            "url": "http://patches.dpdk.org/api/series/1512/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1512",
            "date": "2018-09-26T09:04:56",
            "name": "[v2] net/ixgbe: firmware status check",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/1512/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/45368/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/45368/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A4C131B111;\n\tWed, 26 Sep 2018 11:13:11 +0200 (CEST)",
            "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 91D7A7CDC\n\tfor <dev@dpdk.org>; Wed, 26 Sep 2018 11:13:09 +0200 (CEST)",
            "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Sep 2018 02:13:08 -0700",
            "from dpdk-xiaoyun3.sh.intel.com ([10.67.119.56])\n\tby orsmga008.jf.intel.com with ESMTP; 26 Sep 2018 02:13:05 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.54,305,1534834800\"; d=\"scan'208\";a=\"76298046\"",
        "From": "Xiaoyun Li <xiaoyun.li@intel.com>",
        "To": "wenzhuo.lu@intel.com,\n\tqi.z.zhang@intel.com,\n\tferruh.yigit@intel.com",
        "Cc": "dev@dpdk.org,\n\tXiaoyun Li <xiaoyun.li@intel.com>",
        "Date": "Wed, 26 Sep 2018 17:04:56 +0800",
        "Message-Id": "<20180926090456.42495-1-xiaoyun.li@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<1536332468-31544-1-git-send-email-xiaoyun.li@intel.com>",
        "References": "<1536332468-31544-1-git-send-email-xiaoyun.li@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2] net/ixgbe: firmware status check",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Check the firmware status at init time. If the firmware is in\nrecovery mode, alert the user to check it.\n\nSigned-off-by: Xiaoyun Li <xiaoyun.li@intel.com>\n---\nv2:\n * The check should be after the shared code init. Fix it.\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 8 ++++++++\n 1 file changed, 8 insertions(+)",
    "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex cee886754..192ebd285 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -1119,6 +1119,14 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)\n \t\treturn -EIO;\n \t}\n \n+\tif (hw->mac.ops.fw_recovery_mode && hw->mac.ops.fw_recovery_mode(hw)) {\n+\t\tPMD_INIT_LOG(ERR, \"\\nERROR: \"\n+\t\t\t\"Firmware recovery mode detected. Limiting functionality.\\n\"\n+\t\t\t\"Refer to the Intel(R) Ethernet Adapters and Devices \"\n+\t\t\t\"User Guide for details on firmware recovery mode.\");\n+\t\treturn -EIO;\n+\t}\n+\n \t/* pick up the PCI bus settings for reporting later */\n \tixgbe_get_bus_info(hw);\n \n",
    "prefixes": [
        "v2"
    ]
}