Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45295/?format=api
{ "id": 45295, "url": "http://patches.dpdk.org/api/patches/45295/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1537859109-25659-8-git-send-email-amo@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1537859109-25659-8-git-send-email-amo@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1537859109-25659-8-git-send-email-amo@semihalf.com", "date": "2018-09-25T07:05:03", "name": "[v3,07/13] net/mvpp2: detach Tx QoS from Rx cls/QoS config", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "276d430d4a3c05c7acc2b718bc7ede82ce21f2c6", "submitter": { "id": 1112, "url": "http://patches.dpdk.org/api/people/1112/?format=api", "name": "Andrzej Ostruszka", "email": "amo@semihalf.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1537859109-25659-8-git-send-email-amo@semihalf.com/mbox/", "series": [ { "id": 1482, "url": "http://patches.dpdk.org/api/series/1482/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1482", "date": "2018-09-25T07:04:56", "name": "net/mvpp2: add new features", "version": 3, "mbox": "http://patches.dpdk.org/series/1482/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45295/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45295/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1EF7B4C93;\n\tTue, 25 Sep 2018 09:05:52 +0200 (CEST)", "from mail-lj1-f172.google.com (mail-lj1-f172.google.com\n\t[209.85.208.172]) by dpdk.org (Postfix) with ESMTP id 3F9324CA7\n\tfor <dev@dpdk.org>; Tue, 25 Sep 2018 09:05:20 +0200 (CEST)", "by mail-lj1-f172.google.com with SMTP id v9-v6so20642229ljk.4\n\tfor <dev@dpdk.org>; Tue, 25 Sep 2018 00:05:20 -0700 (PDT)", "from amok.semihalf.local (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173]) by smtp.googlemail.com with ESMTPSA id\n\t24-v6sm238306ljb.76.2018.09.25.00.05.18\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tTue, 25 Sep 2018 00:05:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=drm2Anax2hH1FzMY4OqMYrw8s+cDA2OmHGta1ov5lGM=;\n\tb=waRmGpJvn1AZ6MX4ZlDMrUlBhz4U7VVARiDKd9QJW4B8Dyc5SUouE4rR9T+89Ld0j/\n\t9V/OaxQ+pa+MYJKQVUj6++AHB2XzDvF08SwyfMTvOzN77CaFQThznPi2xasPP0Jr+LGQ\n\tGey66WXo9nIzs95oavz8ZhmReAfdkkyY37Yvmbmf6dchKmuWQ+S/I5AcpCBfTuhy6IQX\n\t1kxAVCrw7XcPpFbCAbJ8TOgDSzqgctGmvDUEowRwfz1/dfnW9CnwGFPOOJT6ya+RnJZy\n\tTid/tGenrRzryj8LEZdIrQpBq2KDUcEiaIYKhdqWuUKlC9MyjkPlAzpjxmsTAfWqhp9W\n\tX/cg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=drm2Anax2hH1FzMY4OqMYrw8s+cDA2OmHGta1ov5lGM=;\n\tb=Nsu18c5Q2i6Ak3cTe6DYY8Zt/xl/YTM5NK5faQZjFBl31XjOFIqS7DxygNad90DD5J\n\t6dl3snqc9Aj90OWWhzzl+025OAtAspR7D0XlXHSmBj4cNFEbJUOIaMKPedWACIW9J8kB\n\trS38YQ6+7jWXtHkuWM/17nNt6DISMk5eAj5g2W2l5W/da4lcOmKy56LdNfciy+IYphwf\n\tMPAJZ+OpzXXtXVWC8TLsCnRhfvRh/KWmOPH8O0zrdiwSUnp309y3ANgh1ldYY5Fa/2Uw\n\tKrgB0aC8mae7J7TtsiDySs3cs60dEE5l0rNjOCS4JcwmKo7HND6jz0vm9S5qy/rK+p16\n\tjv2g==", "X-Gm-Message-State": "ABuFfoiW/rnOhq4mzbg+2S97CYszLincompFnh8EFo745MVBQM88ahnZ\n\tHsRDHc4UKdmS5FQaOpr2wqk1kP0c0w+Kmw==", "X-Google-Smtp-Source": "ACcGV63qVwIc248qBZQSokaQJnct2tyzadIciQetDdr65Lb463xbvlcBClyHR0UP9zXAODZwpKwoHw==", "X-Received": "by 2002:a2e:5719:: with SMTP id\n\tl25-v6mr1494707ljb.125.1537859119622; \n\tTue, 25 Sep 2018 00:05:19 -0700 (PDT)", "From": "Andrzej Ostruszka <amo@semihalf.com>", "To": "dev@dpdk.org", "Cc": "mw@semihalf.com, nadavh@marvell.com, Yuval Caduri <cyuval@marvell.com>", "Date": "Tue, 25 Sep 2018 09:05:03 +0200", "Message-Id": "<1537859109-25659-8-git-send-email-amo@semihalf.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1537859109-25659-1-git-send-email-amo@semihalf.com>", "References": "<1536068953-9352-1-git-send-email-tdu@semihalf.com>\n\t<1537859109-25659-1-git-send-email-amo@semihalf.com>", "Subject": "[dpdk-dev] [PATCH v3 07/13] net/mvpp2: detach Tx QoS from Rx\n\tcls/QoS config", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Yuval Caduri <cyuval@marvell.com>\n\nFunctional change:\nOpen receive cls/qos related features, only if the\nconfig file contains an rx_related configuration entry.\nThis allows to configure tx_related entries, w/o unintentionally\nopening rx cls/qos.\n\nCode:\n'use_global_defaults' is by default set to '1'.\nOnly if an rx_related entry was configured, it is updated to '0'.\nrx cls/qos is performed only if 'use_global_defaults' is '0'.\nDefault TC configuration is now only mandatory when\n'use_global_defaults' is '0'.\n\nSigned-off-by: Yuval Caduri <cyuval@marvell.com>\nReviewed-by: Natalie Samsonov <nsamsono@marvell.com>\nTested-by: Natalie Samsonov <nsamsono@marvell.com>\n---\n drivers/net/mvpp2/mrvl_ethdev.c | 3 ++-\n drivers/net/mvpp2/mrvl_qos.c | 41 +++++++++++++++++++++++------------------\n 2 files changed, 25 insertions(+), 19 deletions(-)", "diff": "diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c\nindex 4d1e84a..64c6f0f 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.c\n+++ b/drivers/net/mvpp2/mrvl_ethdev.c\n@@ -593,7 +593,8 @@ mrvl_dev_start(struct rte_eth_dev *dev)\n \t}\n \n \t/* For default QoS config, don't start classifier. */\n-\tif (mrvl_qos_cfg) {\n+\tif (mrvl_qos_cfg &&\n+\t mrvl_qos_cfg->port[dev->data->port_id].use_global_defaults == 0) {\n \t\tret = mrvl_start_qos_mapping(priv);\n \t\tif (ret) {\n \t\t\tMRVL_LOG(ERR, \"Failed to setup QoS mapping\");\ndiff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c\nindex e039635..5d80c3e 100644\n--- a/drivers/net/mvpp2/mrvl_qos.c\n+++ b/drivers/net/mvpp2/mrvl_qos.c\n@@ -324,6 +324,7 @@ parse_tc_cfg(struct rte_cfgfile *file, int port, int tc,\n \tif (rte_cfgfile_num_sections(file, sec_name, strlen(sec_name)) <= 0)\n \t\treturn 0;\n \n+\tcfg->port[port].use_global_defaults = 0;\n \tentry = rte_cfgfile_get_entry(file, sec_name, MRVL_TOK_RXQ);\n \tif (entry) {\n \t\tn = get_entry_values(entry,\n@@ -421,7 +422,7 @@ parse_policer(struct rte_cfgfile *file, int port, const char *sec_name,\n \t\t\tcfg->port[port].policer_params.token_unit =\n \t\t\t\tPP2_CLS_PLCR_PACKETS_TOKEN_UNIT;\n \t\t} else {\n-\t\t\tRTE_LOG(ERR, PMD, \"Unknown token: %s\\n\", entry);\n+\t\t\tMRVL_LOG(ERR, \"Unknown token: %s\", entry);\n \t\t\treturn -1;\n \t\t}\n \t}\n@@ -438,7 +439,7 @@ parse_policer(struct rte_cfgfile *file, int port, const char *sec_name,\n \t\t\tcfg->port[port].policer_params.color_mode =\n \t\t\t\tPP2_CLS_PLCR_COLOR_AWARE_MODE;\n \t\t} else {\n-\t\t\tRTE_LOG(ERR, PMD, \"Error in parsing: %s\\n\", entry);\n+\t\t\tMRVL_LOG(ERR, \"Error in parsing: %s\", entry);\n \t\t\treturn -1;\n \t\t}\n \t}\n@@ -518,28 +519,15 @@ mrvl_get_qoscfg(const char *key __rte_unused, const char *path,\n \t\tsnprintf(sec_name, sizeof(sec_name), \"%s %d %s\",\n \t\t\tMRVL_TOK_PORT, n, MRVL_TOK_DEFAULT);\n \n+\t\t/* Use global defaults, unless an override occurs */\n+\t\t(*cfg)->port[n].use_global_defaults = 1;\n+\n \t\t/* Skip ports non-existing in configuration. */\n \t\tif (rte_cfgfile_num_sections(file, sec_name,\n \t\t\t\tstrlen(sec_name)) <= 0) {\n-\t\t\t(*cfg)->port[n].use_global_defaults = 1;\n-\t\t\t(*cfg)->port[n].mapping_priority =\n-\t\t\t\tPP2_CLS_QOS_TBL_VLAN_IP_PRI;\n \t\t\tcontinue;\n \t\t}\n \n-\t\tentry = rte_cfgfile_get_entry(file, sec_name,\n-\t\t\t\tMRVL_TOK_DEFAULT_TC);\n-\t\tif (entry) {\n-\t\t\tif (get_val_securely(entry, &val) < 0 ||\n-\t\t\t\tval > USHRT_MAX)\n-\t\t\t\treturn -1;\n-\t\t\t(*cfg)->port[n].default_tc = (uint8_t)val;\n-\t\t} else {\n-\t\t\tMRVL_LOG(ERR,\n-\t\t\t\t\"Default Traffic Class required in custom configuration!\");\n-\t\t\treturn -1;\n-\t\t}\n-\n \t\t/*\n \t\t * Read per-port rate limiting. Setting that will\n \t\t * disable per-queue rate limiting.\n@@ -573,6 +561,7 @@ mrvl_get_qoscfg(const char *key __rte_unused, const char *path,\n \t\tentry = rte_cfgfile_get_entry(file, sec_name,\n \t\t\t\tMRVL_TOK_MAPPING_PRIORITY);\n \t\tif (entry) {\n+\t\t\t(*cfg)->port[n].use_global_defaults = 0;\n \t\t\tif (!strncmp(entry, MRVL_TOK_VLAN_IP,\n \t\t\t\tsizeof(MRVL_TOK_VLAN_IP)))\n \t\t\t\t(*cfg)->port[n].mapping_priority =\n@@ -602,6 +591,7 @@ mrvl_get_qoscfg(const char *key __rte_unused, const char *path,\n \t\tentry = rte_cfgfile_get_entry(file, sec_name,\n \t\t\t\tMRVL_TOK_PLCR_DEFAULT);\n \t\tif (entry) {\n+\t\t\t(*cfg)->port[n].use_global_defaults = 0;\n \t\t\tif (get_val_securely(entry, &val) < 0)\n \t\t\t\treturn -1;\n \n@@ -627,6 +617,21 @@ mrvl_get_qoscfg(const char *key __rte_unused, const char *path,\n \t\t\t\t\t\"Error %d parsing port %d tc %d!\\n\",\n \t\t\t\t\tret, n, i);\n \t\t}\n+\n+\t\tentry = rte_cfgfile_get_entry(file, sec_name,\n+\t\t\t\t\t MRVL_TOK_DEFAULT_TC);\n+\t\tif (entry) {\n+\t\t\tif (get_val_securely(entry, &val) < 0 ||\n+\t\t\t val > USHRT_MAX)\n+\t\t\t\treturn -1;\n+\t\t\t(*cfg)->port[n].default_tc = (uint8_t)val;\n+\t\t} else {\n+\t\t\tif ((*cfg)->port[n].use_global_defaults == 0) {\n+\t\t\t\tMRVL_LOG(ERR,\n+\t\t\t\t\t \"Default Traffic Class required in custom configuration!\");\n+\t\t\t\treturn -1;\n+\t\t\t}\n+\t\t}\n \t}\n \n \treturn 0;\n", "prefixes": [ "v3", "07/13" ] }