Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 45289,
    "url": "http://patches.dpdk.org/api/patches/45289/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1537859109-25659-2-git-send-email-amo@semihalf.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1537859109-25659-2-git-send-email-amo@semihalf.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1537859109-25659-2-git-send-email-amo@semihalf.com",
    "date": "2018-09-25T07:04:57",
    "name": "[v3,01/13] net/mvpp2: initialize ppio only once",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "27df13bbc2ff306efaf032e33f37b0baa4524bf0",
    "submitter": {
        "id": 1112,
        "url": "http://patches.dpdk.org/api/people/1112/?format=api",
        "name": "Andrzej Ostruszka",
        "email": "amo@semihalf.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1537859109-25659-2-git-send-email-amo@semihalf.com/mbox/",
    "series": [
        {
            "id": 1482,
            "url": "http://patches.dpdk.org/api/series/1482/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1482",
            "date": "2018-09-25T07:04:56",
            "name": "net/mvpp2: add new features",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/1482/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/45289/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/45289/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0ED7A4CA0;\n\tTue, 25 Sep 2018 09:05:20 +0200 (CEST)",
            "from mail-lf1-f67.google.com (mail-lf1-f67.google.com\n\t[209.85.167.67]) by dpdk.org (Postfix) with ESMTP id 159BE4C8B\n\tfor <dev@dpdk.org>; Tue, 25 Sep 2018 09:05:13 +0200 (CEST)",
            "by mail-lf1-f67.google.com with SMTP id t22-v6so9229385lfb.7\n\tfor <dev@dpdk.org>; Tue, 25 Sep 2018 00:05:13 -0700 (PDT)",
            "from amok.semihalf.local (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173]) by smtp.googlemail.com with ESMTPSA id\n\t24-v6sm238306ljb.76.2018.09.25.00.05.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tTue, 25 Sep 2018 00:05:11 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=04MIB0RMGEgyR6V2a5m70OBggA0qbXRCSaUSjiTriFo=;\n\tb=df3PTN1AXP826ogZQejFmzEy6VqM5gC0i5DUUcT30TfnvLcc+ZKMErMk4aJ+1YDTgr\n\tZwijSnVr/HFYOMxZzZJcbVRVjdsGIlP2+aczUyIwUmiaJF/2EtxUL5cdKAcLr+wuqfsF\n\tuHMrBTS26aHVXcgK8BVvWyZ2yuXxKvrbkgJWVaAQXtoDYv5nbLYfaTZG70dnP62WCcZq\n\titl7iz3W5GkFKzOFSS0Qe61XiPEk3wxIoRspQdLmwKzAaRdEwDmyvN0IcLeWbkwKbioy\n\tHw27clucpIcCc0kuN3OyODB6LLXy/X+txYC4amBKZ+4vPA+eW2SBMtJr+MebBqtPe7I4\n\tbGzA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=04MIB0RMGEgyR6V2a5m70OBggA0qbXRCSaUSjiTriFo=;\n\tb=ZxyKVw+C9D5+VtRj+tr4u0DUoWVADjLM1C+bVruQCxn4afvotFMTp11O873HG3U3zT\n\tdSwOfNFRVpNZY7C4P4TQPUTYyL3xUp2anj/vb9TaVruyP4zYbQ9uzdharVcpk2XR9Rwi\n\tYFt2vCwxLcQUVt8WjXeXcVnznitwZVtUUda36btKQYn75jbRfIfNg1vkTPovrUZ3zWCn\n\tBvNFtqtsqoDgTqTMx42ipQknujlmVwMP++jkF/GDKtK+51r2LzbxPaJxczUlkbztYFyD\n\tajV5oJzOzXLB/oEicO1YYAIEycg+6rkKb0KNdWyxSBJKuWj5h0cnZsvN0c865xZfLJxw\n\t7jYQ==",
        "X-Gm-Message-State": "ABuFfoiwchdeGlE8OtRvxGQRYqG8z6JRfPZXcMGGQdf1izVy+0PxWBps\n\teeqmAtxd6Ukhl2T/eOmITQK0q3F86itN0Q==",
        "X-Google-Smtp-Source": "ACcGV61DxCvJynbGZnZ7BjY8/sb2uPyVpWnGWMxCHS4pM/Ls/nsxnYxo21rQ70Ri2ssbyTOXQFrFGA==",
        "X-Received": "by 2002:a19:1346:: with SMTP id\n\tj67-v6mr1534649lfi.93.1537859112413; \n\tTue, 25 Sep 2018 00:05:12 -0700 (PDT)",
        "From": "Andrzej Ostruszka <amo@semihalf.com>",
        "To": "dev@dpdk.org",
        "Cc": "mw@semihalf.com, nadavh@marvell.com,\n\tNatalie Samsonov <nsamsono@marvell.com>",
        "Date": "Tue, 25 Sep 2018 09:04:57 +0200",
        "Message-Id": "<1537859109-25659-2-git-send-email-amo@semihalf.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1537859109-25659-1-git-send-email-amo@semihalf.com>",
        "References": "<1536068953-9352-1-git-send-email-tdu@semihalf.com>\n\t<1537859109-25659-1-git-send-email-amo@semihalf.com>",
        "Subject": "[dpdk-dev] [PATCH v3 01/13] net/mvpp2: initialize ppio only once",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Natalie Samsonov <nsamsono@marvell.com>\n\nThis changes stop/start/configure behavior due to issue in MUSDK\nlibrary itself.  From now on, ppio can be reconfigured only after interface\nis closed.\n\nSigned-off-by: Natalie Samsonov <nsamsono@marvell.com>\nReviewed-by: Yuval Caduri <cyuval@marvell.com>\n---\n drivers/net/mvpp2/mrvl_ethdev.c | 53 +++++++++++++++++++++++++----------------\n 1 file changed, 32 insertions(+), 21 deletions(-)",
    "diff": "diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c\nindex fa4af49..dca3ccc 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.c\n+++ b/drivers/net/mvpp2/mrvl_ethdev.c\n@@ -303,6 +303,11 @@ mrvl_dev_configure(struct rte_eth_dev *dev)\n \tstruct mrvl_priv *priv = dev->data->dev_private;\n \tint ret;\n \n+\tif (priv->ppio) {\n+\t\tMRVL_LOG(INFO, \"Device reconfiguration is not supported\");\n+\t\treturn -EINVAL;\n+\t}\n+\n \tif (dev->data->dev_conf.rxmode.mq_mode != ETH_MQ_RX_NONE &&\n \t    dev->data->dev_conf.rxmode.mq_mode != ETH_MQ_RX_RSS) {\n \t\tMRVL_LOG(INFO, \"Unsupported rx multi queue mode %d\",\n@@ -516,6 +521,9 @@ mrvl_dev_start(struct rte_eth_dev *dev)\n \tchar match[MRVL_MATCH_LEN];\n \tint ret = 0, i, def_init_size;\n \n+\tif (priv->ppio)\n+\t\treturn mrvl_dev_set_link_up(dev);\n+\n \tsnprintf(match, sizeof(match), \"ppio-%d:%d\",\n \t\t priv->pp_id, priv->ppio_id);\n \tpriv->ppio_params.match = match;\n@@ -740,28 +748,7 @@ mrvl_flush_bpool(struct rte_eth_dev *dev)\n static void\n mrvl_dev_stop(struct rte_eth_dev *dev)\n {\n-\tstruct mrvl_priv *priv = dev->data->dev_private;\n-\n \tmrvl_dev_set_link_down(dev);\n-\tmrvl_flush_rx_queues(dev);\n-\tmrvl_flush_tx_shadow_queues(dev);\n-\tif (priv->cls_tbl) {\n-\t\tpp2_cls_tbl_deinit(priv->cls_tbl);\n-\t\tpriv->cls_tbl = NULL;\n-\t}\n-\tif (priv->qos_tbl) {\n-\t\tpp2_cls_qos_tbl_deinit(priv->qos_tbl);\n-\t\tpriv->qos_tbl = NULL;\n-\t}\n-\tif (priv->ppio)\n-\t\tpp2_ppio_deinit(priv->ppio);\n-\tpriv->ppio = NULL;\n-\n-\t/* policer must be released after ppio deinitialization */\n-\tif (priv->policer) {\n-\t\tpp2_cls_plcr_deinit(priv->policer);\n-\t\tpriv->policer = NULL;\n-\t}\n }\n \n /**\n@@ -776,6 +763,9 @@ mrvl_dev_close(struct rte_eth_dev *dev)\n \tstruct mrvl_priv *priv = dev->data->dev_private;\n \tsize_t i;\n \n+\tmrvl_flush_rx_queues(dev);\n+\tmrvl_flush_tx_shadow_queues(dev);\n+\n \tfor (i = 0; i < priv->ppio_params.inqs_params.num_tcs; ++i) {\n \t\tstruct pp2_ppio_tc_params *tc_params =\n \t\t\t&priv->ppio_params.inqs_params.tcs_params[i];\n@@ -786,7 +776,28 @@ mrvl_dev_close(struct rte_eth_dev *dev)\n \t\t}\n \t}\n \n+\tif (priv->cls_tbl) {\n+\t\tpp2_cls_tbl_deinit(priv->cls_tbl);\n+\t\tpriv->cls_tbl = NULL;\n+\t}\n+\n+\tif (priv->qos_tbl) {\n+\t\tpp2_cls_qos_tbl_deinit(priv->qos_tbl);\n+\t\tpriv->qos_tbl = NULL;\n+\t}\n+\n \tmrvl_flush_bpool(dev);\n+\n+\tif (priv->ppio) {\n+\t\tpp2_ppio_deinit(priv->ppio);\n+\t\tpriv->ppio = NULL;\n+\t}\n+\n+\t/* policer must be released after ppio deinitialization */\n+\tif (priv->policer) {\n+\t\tpp2_cls_plcr_deinit(priv->policer);\n+\t\tpriv->policer = NULL;\n+\t}\n }\n \n /**\n",
    "prefixes": [
        "v3",
        "01/13"
    ]
}