Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45172/?format=api
http://patches.dpdk.org/api/patches/45172/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1537623216-592-1-git-send-email-fiona.trahe@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1537623216-592-1-git-send-email-fiona.trahe@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1537623216-592-1-git-send-email-fiona.trahe@intel.com", "date": "2018-09-22T13:33:36", "name": "test/crypto: fix number of queue pairs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ee77a086375f112b38a5d3c8936d168762e971f9", "submitter": { "id": 423, "url": "http://patches.dpdk.org/api/people/423/?format=api", "name": "Fiona Trahe", "email": "fiona.trahe@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1537623216-592-1-git-send-email-fiona.trahe@intel.com/mbox/", "series": [ { "id": 1454, "url": "http://patches.dpdk.org/api/series/1454/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1454", "date": "2018-09-22T13:33:36", "name": "test/crypto: fix number of queue pairs", "version": 1, "mbox": "http://patches.dpdk.org/series/1454/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45172/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45172/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E2660F04;\n\tSat, 22 Sep 2018 15:33:48 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 84B7FA49;\n\tSat, 22 Sep 2018 15:33:46 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t22 Sep 2018 06:33:45 -0700", "from sivswdev01.ir.intel.com (HELO localhost.localdomain)\n\t([10.237.217.45])\n\tby fmsmga006.fm.intel.com with ESMTP; 22 Sep 2018 06:33:44 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,289,1534834800\"; d=\"scan'208\";a=\"265806171\"", "From": "Fiona Trahe <fiona.trahe@intel.com>", "To": "dev@dpdk.org", "Cc": "akhil.goyal@nxp.com, stable@dpdk.org, Fiona Trahe <fiona.trahe@intel.com>", "Date": "Sat, 22 Sep 2018 14:33:36 +0100", "Message-Id": "<1537623216-592-1-git-send-email-fiona.trahe@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "Subject": "[dpdk-dev] [PATCH] test/crypto: fix number of queue pairs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Some of the tests use a QAT-specific value (2) for\nmaximum nr of queue pairs to create valid/invalid test cases.\nThis has accidentally worked ok as default max_qps for all PMDs\nis larger. It is incorrect however and would fail if a device\nhad a max lower than the QAT value.\nInstead use the value returned by the PMD in the\nrte_cryptodev_get_info query, this value is stored in the ts_params.\n\nFixes: 202d375c60bc (\"app/test: add cryptodev unit and performance tests\")\nCc: stable@dpdk.org\n\nSigned-off-by: Fiona Trahe <fiona.trahe@intel.com>\n---\n test/test/test_cryptodev.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c\nindex a6044b2..c63662d 100644\n--- a/test/test/test_cryptodev.c\n+++ b/test/test/test_cryptodev.c\n@@ -635,7 +635,7 @@ test_device_configure_invalid_queue_pair_ids(void)\n \n \n \t/* valid - max value queue pairs */\n-\tts_params->conf.nb_queue_pairs = MAX_NUM_QPS_PER_QAT_DEVICE;\n+\tts_params->conf.nb_queue_pairs = orig_nb_qps;\n \n \tTEST_ASSERT_SUCCESS(rte_cryptodev_configure(ts_params->valid_devs[0],\n \t\t\t&ts_params->conf),\n@@ -667,7 +667,7 @@ test_device_configure_invalid_queue_pair_ids(void)\n \n \n \t/* invalid - max value + 1 queue pairs */\n-\tts_params->conf.nb_queue_pairs = MAX_NUM_QPS_PER_QAT_DEVICE + 1;\n+\tts_params->conf.nb_queue_pairs = orig_nb_qps + 1;\n \n \tTEST_ASSERT_FAIL(rte_cryptodev_configure(ts_params->valid_devs[0],\n \t\t\t&ts_params->conf),\n@@ -819,7 +819,7 @@ test_queue_pair_descriptor_setup(void)\n \t/* test invalid queue pair id */\n \tqp_conf.nb_descriptors = DEFAULT_NUM_OPS_INFLIGHT;\t/*valid */\n \n-\tqp_id = DEFAULT_NUM_QPS_PER_QAT_DEVICE;\t\t/*invalid */\n+\tqp_id = ts_params->conf.nb_queue_pairs;\t\t/*invalid */\n \n \tTEST_ASSERT_FAIL(rte_cryptodev_queue_pair_setup(\n \t\t\tts_params->valid_devs[0],\n", "prefixes": [] }{ "id": 45172, "url": "