Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45160/?format=api
http://patches.dpdk.org/api/patches/45160/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180922045559.27438-11-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180922045559.27438-11-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180922045559.27438-11-ajit.khaparde@broadcom.com", "date": "2018-09-22T04:55:57", "name": "[v2,10/12] net/bnxt: set a VNIC as default only once", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "fa543a618b2bb209eafb1f010df2501cf630a33f", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180922045559.27438-11-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 1450, "url": "http://patches.dpdk.org/api/series/1450/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1450", "date": "2018-09-22T04:55:49", "name": "bnxt patchset", "version": 2, "mbox": "http://patches.dpdk.org/series/1450/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45160/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45160/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 19B315688;\n\tSat, 22 Sep 2018 06:56:35 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 495C51B19\n\tfor <dev@dpdk.org>; Sat, 22 Sep 2018 06:56:18 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 720F730C066;\n\tFri, 21 Sep 2018 21:56:13 -0700 (PDT)", "from C02VPB22HTD6.vpn.broadcom.net (unknown [10.10.118.131])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id EF6CDAC0741;\n\tFri, 21 Sep 2018 21:56:12 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 720F730C066", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1537592173;\n\tbh=JyaIjK8ySxu3No4hiOFtjz6b79aJPjRShT+pDFe1CDI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=E2NzQk9a6H+fTyG0cbsHBUw2DECZo4k4pUvcr+Cy6DIsPHt2PbyvfLUYe8G2JN3Uw\n\tDx6a4R79du7ZVELRPJgcGLwujZqJtakpWIIY/cOuFayvgmCaWz+k1Apu6W3jqh73Ir\n\tf3dYtF16PLO3ZiqMaq5AZQGrvZIsOnd5IqHQ1Hko=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Fri, 21 Sep 2018 21:55:57 -0700", "Message-Id": "<20180922045559.27438-11-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.17.1 (Apple Git-112)", "In-Reply-To": "<20180922045559.27438-1-ajit.khaparde@broadcom.com>", "References": "<f08457f7-5a78-c7e4-23ff-f4e253cd54c9@intel.com>\n\t<20180922045559.27438-1-ajit.khaparde@broadcom.com>", "Subject": "[dpdk-dev] [PATCH v2 10/12] net/bnxt: set a VNIC as default only\n\tonce", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If a vnic is configured as default and the setting has not changed,\nthere is no need to issue this setting again to the FW.\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 1 +\n drivers/net/bnxt/bnxt_hwrm.c | 9 ++++++++-\n 2 files changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex 44c3747f2..c95fb9e3d 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -261,6 +261,7 @@ struct bnxt {\n #define BNXT_FLAG_EXT_TX_PORT_STATS\t(1 << 9)\n #define BNXT_FLAG_KONG_MB_EN\t(1 << 10)\n #define BNXT_FLAG_TRUSTED_VF_EN\t(1 << 11)\n+#define BNXT_FLAG_DFLT_VNIC_SET\t(1 << 12)\n #define BNXT_FLAG_NEW_RM\t(1 << 30)\n #define BNXT_FLAG_INIT_DONE\t(1 << 31)\n #define BNXT_PF(bp)\t\t(!((bp)->flags & BNXT_FLAG_VF))\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex b605659ed..38698e214 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -1460,9 +1460,12 @@ int bnxt_hwrm_vnic_cfg(struct bnxt *bp, struct bnxt_vnic_info *vnic)\n \treq.cos_rule = rte_cpu_to_le_16(vnic->cos_rule);\n \treq.lb_rule = rte_cpu_to_le_16(vnic->lb_rule);\n \treq.mru = rte_cpu_to_le_16(vnic->mru);\n-\tif (vnic->func_default)\n+\t/* Configure default VNIC only once. */\n+\tif (vnic->func_default && !(bp->flags & BNXT_FLAG_DFLT_VNIC_SET)) {\n \t\treq.flags |=\n \t\t rte_cpu_to_le_32(HWRM_VNIC_CFG_INPUT_FLAGS_DEFAULT);\n+\t\tbp->flags |= BNXT_FLAG_DFLT_VNIC_SET;\n+\t}\n \tif (vnic->vlan_strip)\n \t\treq.flags |=\n \t\t rte_cpu_to_le_32(HWRM_VNIC_CFG_INPUT_FLAGS_VLAN_STRIP_MODE);\n@@ -1600,6 +1603,10 @@ int bnxt_hwrm_vnic_free(struct bnxt *bp, struct bnxt_vnic_info *vnic)\n \tHWRM_UNLOCK();\n \n \tvnic->fw_vnic_id = INVALID_HW_RING_ID;\n+\t/* Configure default VNIC again if necessary. */\n+\tif (vnic->func_default && (bp->flags & BNXT_FLAG_DFLT_VNIC_SET))\n+\t\tbp->flags &= ~BNXT_FLAG_DFLT_VNIC_SET;\n+\n \treturn rc;\n }\n \n", "prefixes": [ "v2", "10/12" ] }{ "id": 45160, "url": "