Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45156/?format=api
{ "id": 45156, "url": "http://patches.dpdk.org/api/patches/45156/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180922045559.27438-3-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180922045559.27438-3-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180922045559.27438-3-ajit.khaparde@broadcom.com", "date": "2018-09-22T04:55:49", "name": "[v2,02/12] net/bnxt: fix uninitialized ptr access in transmit handler", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "125f1e855335edabc60c39120741ea1e69580c8e", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180922045559.27438-3-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 1450, "url": "http://patches.dpdk.org/api/series/1450/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1450", "date": "2018-09-22T04:55:49", "name": "bnxt patchset", "version": 2, "mbox": "http://patches.dpdk.org/series/1450/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45156/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45156/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 29F94A49;\n\tSat, 22 Sep 2018 06:56:19 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 1B65EA49\n\tfor <dev@dpdk.org>; Sat, 22 Sep 2018 06:56:17 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id E928C30C052;\n\tFri, 21 Sep 2018 21:56:06 -0700 (PDT)", "from C02VPB22HTD6.vpn.broadcom.net (unknown [10.10.118.131])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 515C7AC0741;\n\tFri, 21 Sep 2018 21:56:06 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com E928C30C052", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1537592166;\n\tbh=hJUBpeKc6FQJgcckIt+XsNP+wR7OYx0iK1UTD7mo4Dw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=qgbfEzZPWd4vefpx+JxTRI5aUiltHMG3hSgrt4wpoB5AztYxymUaspZxubAaFXPsS\n\t4hbIL4MjbDqRYKptLygFb4WH12BpCOqxd6ZVe4JdExHV9fl1eiXdhbiAo0rZPQtwnW\n\t+l9ZqLTkf+uDXL5AJiAEzxQXmMp3/LDnt09IWzN8=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Somnath Kotur <somnath.kotur@broadcom.com>,\n\tstable@broadcom.com", "Date": "Fri, 21 Sep 2018 21:55:49 -0700", "Message-Id": "<20180922045559.27438-3-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.17.1 (Apple Git-112)", "In-Reply-To": "<20180922045559.27438-1-ajit.khaparde@broadcom.com>", "References": "<f08457f7-5a78-c7e4-23ff-f4e253cd54c9@intel.com>\n\t<20180922045559.27438-1-ajit.khaparde@broadcom.com>", "Subject": "[dpdk-dev] [PATCH v2 02/12] net/bnxt: fix uninitialized ptr access\n\tin transmit handler", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Somnath Kotur <somnath.kotur@broadcom.com>\n\nbnxt_start_xmit() was attempting to access an uninitialized ptr - txbd1\nwhich would lead to segmentation fault.\nFix to initialize ptr to NULL and check for the same before access.\n\nFixes: f10258e39ec2 (\"net/bnxt: fix HW Tx checksum offload check\")\nCc: stable@broadcom.com\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_txr.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c\nindex 67bb35e06..39be7bdfa 100644\n--- a/drivers/net/bnxt/bnxt_txr.c\n+++ b/drivers/net/bnxt/bnxt_txr.c\n@@ -120,7 +120,7 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n {\n \tstruct bnxt_tx_ring_info *txr = txq->tx_ring;\n \tstruct tx_bd_long *txbd;\n-\tstruct tx_bd_long_hi *txbd1;\n+\tstruct tx_bd_long_hi *txbd1 = NULL;\n \tuint32_t vlan_tag_flags, cfa_action;\n \tbool long_bd = false;\n \tuint16_t last_prod = 0;\n@@ -295,7 +295,8 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \t}\n \n \ttxbd->flags_type |= TX_BD_LONG_FLAGS_PACKET_END;\n-\ttxbd1->lflags = rte_cpu_to_le_32(txbd1->lflags);\n+\tif (txbd1)\n+\t\ttxbd1->lflags = rte_cpu_to_le_32(txbd1->lflags);\n \n \ttxr->tx_prod = RING_NEXT(txr->tx_ring_struct, txr->tx_prod);\n \n", "prefixes": [ "v2", "02/12" ] }