Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45101/?format=api
http://patches.dpdk.org/api/patches/45101/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180921125244.27861-3-tiwei.bie@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180921125244.27861-3-tiwei.bie@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180921125244.27861-3-tiwei.bie@intel.com", "date": "2018-09-21T12:52:43", "name": "[2/3] net/virtio: add the missing supported features", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8aecb61012f1524431418fa1d53242b5afeb9ccb", "submitter": { "id": 617, "url": "http://patches.dpdk.org/api/people/617/?format=api", "name": "Tiwei Bie", "email": "tiwei.bie@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180921125244.27861-3-tiwei.bie@intel.com/mbox/", "series": [ { "id": 1439, "url": "http://patches.dpdk.org/api/series/1439/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1439", "date": "2018-09-21T12:52:41", "name": "Some fixes and doc updates for virtio-user", "version": 1, "mbox": "http://patches.dpdk.org/series/1439/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45101/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45101/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0D7F94F91;\n\tFri, 21 Sep 2018 14:54:23 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 53E5F2BD3;\n\tFri, 21 Sep 2018 14:54:18 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t21 Sep 2018 05:54:17 -0700", "from btwcube1.sh.intel.com ([10.67.104.151])\n\tby orsmga006.jf.intel.com with ESMTP; 21 Sep 2018 05:54:16 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,285,1534834800\"; d=\"scan'208\";a=\"76203870\"", "From": "Tiwei Bie <tiwei.bie@intel.com>", "To": "maxime.coquelin@redhat.com,\n\tzhihong.wang@intel.com,\n\tdev@dpdk.org", "Cc": "stable@dpdk.org", "Date": "Fri, 21 Sep 2018 20:52:43 +0800", "Message-Id": "<20180921125244.27861-3-tiwei.bie@intel.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<20180921125244.27861-1-tiwei.bie@intel.com>", "References": "<20180921125244.27861-1-tiwei.bie@intel.com>", "Subject": "[dpdk-dev] [PATCH 2/3] net/virtio: add the missing supported\n\tfeatures", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The virtio features VIRTIO_NET_F_CSUM, VIRTIO_NET_F_HOST_TSO4\nand VIRTIO_NET_F_HOST_TSO6 are supported by the virtio PMD.\nBut they are missing in the supported feature set. And since\nbelow commit:\n\ncommit 4174a7b59d05 (\"net/virtio: improve Tx offload features negotiation\")\n\nVirtio PMD will announce the Tx offloading capabilities based\non the features read from the device. And virtio-user won't\nreport the features which are not in virtio-PMD's supported\nfeature set. So since that commit, virtio-user won't announce\nthe DEV_TX_OFFLOAD_UDP_CKSUM, DEV_TX_OFFLOAD_TCP_CKSUM and\nDEV_TX_OFFLOAD_TCP_TSO offloading capabilities even if the\nvhost backend supports them.\n\nThis patch adds these missing features, and virtio-user will\nreport them if the backend supports them.\n\nFixes: 142678d42959 (\"net/virtio-user: fix wrongly get/set features\")\nCc: stable@dpdk.org\n\nSigned-off-by: Tiwei Bie <tiwei.bie@intel.com>\n---\n drivers/net/virtio/virtio_ethdev.h | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h\nindex b726ad108..e0f80e5a4 100644\n--- a/drivers/net/virtio/virtio_ethdev.h\n+++ b/drivers/net/virtio/virtio_ethdev.h\n@@ -40,7 +40,10 @@\n \t(VIRTIO_PMD_DEFAULT_GUEST_FEATURES |\t\\\n \t 1u << VIRTIO_NET_F_GUEST_CSUM\t |\t\\\n \t 1u << VIRTIO_NET_F_GUEST_TSO4 |\t\\\n-\t 1u << VIRTIO_NET_F_GUEST_TSO6)\n+\t 1u << VIRTIO_NET_F_GUEST_TSO6 |\t\\\n+\t 1u << VIRTIO_NET_F_CSUM |\t\\\n+\t 1u << VIRTIO_NET_F_HOST_TSO4 |\t\\\n+\t 1u << VIRTIO_NET_F_HOST_TSO6)\n \n /*\n * CQ function prototype\n", "prefixes": [ "2/3" ] }{ "id": 45101, "url": "