Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 45100,
    "url": "http://patches.dpdk.org/api/patches/45100/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180921125244.27861-2-tiwei.bie@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180921125244.27861-2-tiwei.bie@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180921125244.27861-2-tiwei.bie@intel.com",
    "date": "2018-09-21T12:52:42",
    "name": "[1/3] net/virtio-user: fix multiple queue for vhost-kernel",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "0d34647720f9c7095199f8e4476e6f2e4ebd3a27",
    "submitter": {
        "id": 617,
        "url": "http://patches.dpdk.org/api/people/617/?format=api",
        "name": "Tiwei Bie",
        "email": "tiwei.bie@intel.com"
    },
    "delegate": {
        "id": 2642,
        "url": "http://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180921125244.27861-2-tiwei.bie@intel.com/mbox/",
    "series": [
        {
            "id": 1439,
            "url": "http://patches.dpdk.org/api/series/1439/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1439",
            "date": "2018-09-21T12:52:41",
            "name": "Some fixes and doc updates for virtio-user",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/1439/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/45100/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/45100/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B2DB84C9F;\n\tFri, 21 Sep 2018 14:54:20 +0200 (CEST)",
            "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 92818F04;\n\tFri, 21 Sep 2018 14:54:16 +0200 (CEST)",
            "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t21 Sep 2018 05:54:16 -0700",
            "from btwcube1.sh.intel.com ([10.67.104.151])\n\tby orsmga006.jf.intel.com with ESMTP; 21 Sep 2018 05:54:14 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.54,285,1534834800\"; d=\"scan'208\";a=\"76203866\"",
        "From": "Tiwei Bie <tiwei.bie@intel.com>",
        "To": "maxime.coquelin@redhat.com,\n\tzhihong.wang@intel.com,\n\tdev@dpdk.org",
        "Cc": "stable@dpdk.org",
        "Date": "Fri, 21 Sep 2018 20:52:42 +0800",
        "Message-Id": "<20180921125244.27861-2-tiwei.bie@intel.com>",
        "X-Mailer": "git-send-email 2.18.0",
        "In-Reply-To": "<20180921125244.27861-1-tiwei.bie@intel.com>",
        "References": "<20180921125244.27861-1-tiwei.bie@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 1/3] net/virtio-user: fix multiple queue for\n\tvhost-kernel",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The multiple queue support in vhost-kernel is broken because\nthe dev->vhostfd is only available for vhost-user. We should\nalways try to enable queue pairs when it's not in server mode.\n\nFixes: 201a41651715 (\"net/virtio-user: fix multiple queues fail in server mode\")\nCc: stable@dpdk.org\n\nSigned-off-by: Tiwei Bie <tiwei.bie@intel.com>\n---\n drivers/net/virtio/virtio_user/virtio_user_dev.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)",
    "diff": "diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex 869e96f87..55a82e4b0 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -549,13 +549,11 @@ virtio_user_handle_mq(struct virtio_user_dev *dev, uint16_t q_pairs)\n \t/* Server mode can't enable queue pairs if vhostfd is invalid,\n \t * always return 0 in this case.\n \t */\n-\tif (dev->vhostfd >= 0) {\n+\tif (!dev->is_server || dev->vhostfd >= 0) {\n \t\tfor (i = 0; i < q_pairs; ++i)\n \t\t\tret |= dev->ops->enable_qp(dev, i, 1);\n \t\tfor (i = q_pairs; i < dev->max_queue_pairs; ++i)\n \t\t\tret |= dev->ops->enable_qp(dev, i, 0);\n-\t} else if (!dev->is_server) {\n-\t\tret = ~0;\n \t}\n \tdev->queue_pairs = q_pairs;\n \n",
    "prefixes": [
        "1/3"
    ]
}