Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45063/?format=api
http://patches.dpdk.org/api/patches/45063/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1537530998-109749-1-git-send-email-pawelx.wodkowski@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1537530998-109749-1-git-send-email-pawelx.wodkowski@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1537530998-109749-1-git-send-email-pawelx.wodkowski@intel.com", "date": "2018-09-21T11:56:38", "name": "eal: fix '--huge-unlink' option", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e70d487907ffdadb1574243f73aa51e60f98d6b4", "submitter": { "id": 58, "url": "http://patches.dpdk.org/api/people/58/?format=api", "name": "Wodkowski, PawelX", "email": "pawelx.wodkowski@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1537530998-109749-1-git-send-email-pawelx.wodkowski@intel.com/mbox/", "series": [ { "id": 1431, "url": "http://patches.dpdk.org/api/series/1431/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1431", "date": "2018-09-21T11:56:38", "name": "eal: fix '--huge-unlink' option", "version": 1, "mbox": "http://patches.dpdk.org/series/1431/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45063/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45063/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1E6261041;\n\tFri, 21 Sep 2018 10:16:11 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id C202AF04\n\tfor <dev@dpdk.org>; Fri, 21 Sep 2018 10:16:09 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t21 Sep 2018 01:16:08 -0700", "from kraken.imu.intel.com (HELO Sent) ([10.217.246.153])\n\tby fmsmga006.fm.intel.com with SMTP; 21 Sep 2018 01:12:19 -0700", "by Sent (sSMTP sendmail emulation); Fri, 21 Sep 2018 13:56:39 +0200" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,284,1534834800\"; d=\"scan'208\";a=\"265490016\"", "From": "Pawel Wodkowski <pawelx.wodkowski@intel.com>", "To": "dev@dpdk.org", "Cc": "Pawel Wodkowski <pawelx.wodkowski@intel.com>", "Date": "Fri, 21 Sep 2018 13:56:38 +0200", "Message-Id": "<1537530998-109749-1-git-send-email-pawelx.wodkowski@intel.com>", "X-Mailer": "git-send-email 2.7.4", "Subject": "[dpdk-dev] [PATCH] eal: fix '--huge-unlink' option", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The final_va field is set during remap_segment() but this information is\nnot propagated to temporal copy of huge page memory configuration so the\nunlink_hugepage_files() function wrongly assume that there is nothing to\nunlink. Fix this issue by checking orig_va instead of final_va.\n\nFixes: 66cc45e293ed (\"mem: replace memseg with memseg lists\")\nTo: Anatoly Burakov <anatoly.burakov@intel.com>\n\nSigned-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>\n---\n lib/librte_eal/linuxapp/eal/eal_memory.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c\nindex e3ac2481572d..b4a2b2b9e405 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_memory.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_memory.c\n@@ -585,7 +585,7 @@ unlink_hugepage_files(struct hugepage_file *hugepg_tbl,\n \tfor (page = 0; page < nrpages; page++) {\n \t\tstruct hugepage_file *hp = &hugepg_tbl[page];\n \n-\t\tif (hp->final_va != NULL && unlink(hp->filepath)) {\n+\t\tif (hp->orig_va != NULL && unlink(hp->filepath)) {\n \t\t\tRTE_LOG(WARNING, EAL, \"%s(): Removing %s failed: %s\\n\",\n \t\t\t\t__func__, hp->filepath, strerror(errno));\n \t\t}\n", "prefixes": [] }{ "id": 45063, "url": "