Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45038/?format=api
{ "id": 45038, "url": "http://patches.dpdk.org/api/patches/45038/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1537451752-28759-4-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1537451752-28759-4-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1537451752-28759-4-git-send-email-arybchenko@solarflare.com", "date": "2018-09-20T13:55:51", "name": "[v2,3/4] net/failsafe: add Rx queue start and stop functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f52d9920e45dc100651b771960a39578e348f4f2", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1537451752-28759-4-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 1422, "url": "http://patches.dpdk.org/api/series/1422/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1422", "date": "2018-09-20T13:55:48", "name": "net/failsafe: support deferred queue start", "version": 2, "mbox": "http://patches.dpdk.org/series/1422/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45038/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45038/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AC80D5F4D;\n\tThu, 20 Sep 2018 15:56:37 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id E58D25F29\n\tfor <dev@dpdk.org>; Thu, 20 Sep 2018 15:56:32 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id 481FDB80121; Thu, 20 Sep 2018 13:56:31 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Thu, 20 Sep 2018 06:56:10 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Thu, 20 Sep 2018 06:56:10 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw8KDu9XG005368; Thu, 20 Sep 2018 14:56:09 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t18BA71626D2; Thu, 20 Sep 2018 14:56:09 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Gaetan Rivet <gaetan.rivet@6wind.com>", "CC": "<dev@dpdk.org>, Ian Dolzhansky <Ian.Dolzhansky@oktetlabs.ru>", "Date": "Thu, 20 Sep 2018 14:55:51 +0100", "Message-ID": "<1537451752-28759-4-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1537451752-28759-1-git-send-email-arybchenko@solarflare.com>", "References": "<1535526966-32456-1-git-send-email-arybchenko@solarflare.com>\n\t<1537451752-28759-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24106.004", "X-TM-AS-Result": "No-7.302600-4.000000-10", "X-TMASE-MatchedRID": "F7iwnmW7ThE2jeY+Udg/Ip7tR0mnRAg1RWnXH60ddk8s/uUAk6xP7Gb6\n\tPphVtfZgn/eS10qcoVIVmqZXmnc/Uhm45uWXWpVB7spMO3HwKCDDHSNFHFxB8/gnJH5vm2+gxxE\n\tlGvP0lfiA9OOaTInVlYpnZiLRDhQK3huBcHFqgEvil2r2x2PwtY6ESGgCXvgoJLfQYoCQHFbZGr\n\tfobCG631VG+ntCcXddFBNBqLARgRuxpgqXoiq0QU3dRRsh/h6ylhxhDXU/lT/FMsgnB1Q/WGfLK\n\tEW7qlsH9J9T2E2v3qwyh2C7EeKtCx8TzIzimOwPC24oEZ6SpSkj80Za3RRg8Dsslt8GT2cwKvfK\n\t4Wl5tb0nSe7p+a2QUNOrrjfs4gsw1PYfTfPNTUk=", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--7.302600-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24106.004", "X-MDID": "1537451792-UquY-Lp63GhA", "Subject": "[dpdk-dev] [PATCH v2 3/4] net/failsafe: add Rx queue start and stop\n\tfunctions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ian Dolzhansky <Ian.Dolzhansky@oktetlabs.ru>\n\nSupport Rx queue deferred start.\n\nSigned-off-by: Ian Dolzhansky <Ian.Dolzhansky@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nAcked-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n doc/guides/nics/features/failsafe.ini | 1 +\n doc/guides/rel_notes/release_18_11.rst | 7 ++\n drivers/net/failsafe/failsafe_ether.c | 44 ++++++++++++\n drivers/net/failsafe/failsafe_ops.c | 96 ++++++++++++++++++++++++--\n 4 files changed, 143 insertions(+), 5 deletions(-)", "diff": "diff --git a/doc/guides/nics/features/failsafe.ini b/doc/guides/nics/features/failsafe.ini\nindex 39ee57965..712c0b7f7 100644\n--- a/doc/guides/nics/features/failsafe.ini\n+++ b/doc/guides/nics/features/failsafe.ini\n@@ -7,6 +7,7 @@\n Link status = Y\n Link status event = Y\n Rx interrupt = Y\n+Queue start/stop = P\n MTU update = Y\n Jumbo frame = Y\n Promiscuous mode = Y\ndiff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst\nindex e9f3a415c..d6af403b1 100644\n--- a/doc/guides/rel_notes/release_18_11.rst\n+++ b/doc/guides/rel_notes/release_18_11.rst\n@@ -72,6 +72,13 @@ New Features\n choose the latest vector path that the platform supported. For example, users\n can use AVX2 vector path on BDW/HSW to get better performance.\n \n+* **Updated failsafe driver.**\n+\n+ Updated the failsafe driver including the following changes:\n+\n+ * Support for Rx queues start and stop.\n+ * Support for Rx queues deferred start.\n+\n * **Added ability to switch queue deferred start flag on testpmd app.**\n \n Added a console command to testpmd app, giving ability to switch\ndiff --git a/drivers/net/failsafe/failsafe_ether.c b/drivers/net/failsafe/failsafe_ether.c\nindex 5b5cb3b49..305deed63 100644\n--- a/drivers/net/failsafe/failsafe_ether.c\n+++ b/drivers/net/failsafe/failsafe_ether.c\n@@ -366,6 +366,47 @@ failsafe_dev_remove(struct rte_eth_dev *dev)\n \t\t}\n }\n \n+static int\n+failsafe_eth_dev_rx_queues_sync(struct rte_eth_dev *dev)\n+{\n+\tstruct rxq *rxq;\n+\tint ret;\n+\tuint16_t i;\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\trxq = dev->data->rx_queues[i];\n+\n+\t\tif (rxq->info.conf.rx_deferred_start &&\n+\t\t dev->data->rx_queue_state[i] ==\n+\t\t\t\t\t\tRTE_ETH_QUEUE_STATE_STARTED) {\n+\t\t\t/*\n+\t\t\t * The subdevice Rx queue does not launch on device\n+\t\t\t * start if deferred start flag is set. It needs to be\n+\t\t\t * started manually in case an appropriate failsafe Rx\n+\t\t\t * queue has been started earlier.\n+\t\t\t */\n+\t\t\tret = dev->dev_ops->rx_queue_start(dev, i);\n+\t\t\tif (ret) {\n+\t\t\t\tERROR(\"Could not synchronize Rx queue %d\", i);\n+\t\t\t\treturn ret;\n+\t\t\t}\n+\t\t} else if (dev->data->rx_queue_state[i] ==\n+\t\t\t\t\t\tRTE_ETH_QUEUE_STATE_STOPPED) {\n+\t\t\t/*\n+\t\t\t * The subdevice Rx queue needs to be stopped manually\n+\t\t\t * in case an appropriate failsafe Rx queue has been\n+\t\t\t * stopped earlier.\n+\t\t\t */\n+\t\t\tret = dev->dev_ops->rx_queue_stop(dev, i);\n+\t\t\tif (ret) {\n+\t\t\t\tERROR(\"Could not synchronize Rx queue %d\", i);\n+\t\t\t\treturn ret;\n+\t\t\t}\n+\t\t}\n+\t}\n+\treturn 0;\n+}\n+\n int\n failsafe_eth_dev_state_sync(struct rte_eth_dev *dev)\n {\n@@ -422,6 +463,9 @@ failsafe_eth_dev_state_sync(struct rte_eth_dev *dev)\n \tif (PRIV(dev)->state < DEV_STARTED)\n \t\treturn 0;\n \tret = dev->dev_ops->dev_start(dev);\n+\tif (ret)\n+\t\tgoto err_remove;\n+\tret = failsafe_eth_dev_rx_queues_sync(dev);\n \tif (ret)\n \t\tgoto err_remove;\n \treturn 0;\ndiff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c\nindex 9608d09cb..402c5b62c 100644\n--- a/drivers/net/failsafe/failsafe_ops.c\n+++ b/drivers/net/failsafe/failsafe_ops.c\n@@ -168,6 +168,20 @@ fs_dev_configure(struct rte_eth_dev *dev)\n \treturn 0;\n }\n \n+static void\n+fs_set_queues_state_start(struct rte_eth_dev *dev)\n+{\n+\tstruct rxq *rxq;\n+\tuint16_t i;\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\trxq = dev->data->rx_queues[i];\n+\t\tif (!rxq->info.conf.rx_deferred_start)\n+\t\t\tdev->data->rx_queue_state[i] =\n+\t\t\t\t\t\tRTE_ETH_QUEUE_STATE_STARTED;\n+\t}\n+}\n+\n static int\n fs_dev_start(struct rte_eth_dev *dev)\n {\n@@ -202,13 +216,24 @@ fs_dev_start(struct rte_eth_dev *dev)\n \t\t}\n \t\tsdev->state = DEV_STARTED;\n \t}\n-\tif (PRIV(dev)->state < DEV_STARTED)\n+\tif (PRIV(dev)->state < DEV_STARTED) {\n \t\tPRIV(dev)->state = DEV_STARTED;\n+\t\tfs_set_queues_state_start(dev);\n+\t}\n \tfs_switch_dev(dev, NULL);\n \tfs_unlock(dev, 0);\n \treturn 0;\n }\n \n+static void\n+fs_set_queues_state_stop(struct rte_eth_dev *dev)\n+{\n+\tuint16_t i;\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++)\n+\t\tdev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;\n+}\n+\n static void\n fs_dev_stop(struct rte_eth_dev *dev)\n {\n@@ -223,6 +248,7 @@ fs_dev_stop(struct rte_eth_dev *dev)\n \t\tsdev->state = DEV_STARTED - 1;\n \t}\n \tfailsafe_rx_intr_uninstall(dev);\n+\tfs_set_queues_state_stop(dev);\n \tfs_unlock(dev, 0);\n }\n \n@@ -292,6 +318,59 @@ fs_dev_close(struct rte_eth_dev *dev)\n \tfs_unlock(dev, 0);\n }\n \n+static int\n+fs_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n+{\n+\tstruct sub_device *sdev;\n+\tuint8_t i;\n+\tint ret;\n+\tint err = 0;\n+\tbool failure = true;\n+\n+\tfs_lock(dev, 0);\n+\tFOREACH_SUBDEV_STATE(sdev, i, dev, DEV_ACTIVE) {\n+\t\tuint16_t port_id = ETH(sdev)->data->port_id;\n+\n+\t\tret = rte_eth_dev_rx_queue_stop(port_id, rx_queue_id);\n+\t\tret = fs_err(sdev, ret);\n+\t\tif (ret) {\n+\t\t\tERROR(\"Rx queue stop failed for subdevice %d\", i);\n+\t\t\terr = ret;\n+\t\t} else {\n+\t\t\tfailure = false;\n+\t\t}\n+\t}\n+\tdev->data->rx_queue_state[rx_queue_id] = RTE_ETH_QUEUE_STATE_STOPPED;\n+\tfs_unlock(dev, 0);\n+\t/* Return 0 in case of at least one successful queue stop */\n+\treturn (failure) ? err : 0;\n+}\n+\n+static int\n+fs_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n+{\n+\tstruct sub_device *sdev;\n+\tuint8_t i;\n+\tint ret;\n+\n+\tfs_lock(dev, 0);\n+\tFOREACH_SUBDEV_STATE(sdev, i, dev, DEV_ACTIVE) {\n+\t\tuint16_t port_id = ETH(sdev)->data->port_id;\n+\n+\t\tret = rte_eth_dev_rx_queue_start(port_id, rx_queue_id);\n+\t\tret = fs_err(sdev, ret);\n+\t\tif (ret) {\n+\t\t\tERROR(\"Rx queue start failed for subdevice %d\", i);\n+\t\t\tfs_rx_queue_stop(dev, rx_queue_id);\n+\t\t\tfs_unlock(dev, 0);\n+\t\t\treturn ret;\n+\t\t}\n+\t}\n+\tdev->data->rx_queue_state[rx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED;\n+\tfs_unlock(dev, 0);\n+\treturn 0;\n+}\n+\n static void\n fs_rx_queue_release(void *queue)\n {\n@@ -338,12 +417,17 @@ fs_rx_queue_setup(struct rte_eth_dev *dev,\n \tuint8_t i;\n \tint ret;\n \n+\tfs_lock(dev, 0);\n \tif (rx_conf->rx_deferred_start) {\n-\t\tERROR(\"Rx queue deferred start is not supported\");\n-\t\treturn -EINVAL;\n+\t\tFOREACH_SUBDEV_STATE(sdev, i, dev, DEV_PROBED) {\n+\t\t\tif (SUBOPS(sdev, rx_queue_start) == NULL) {\n+\t\t\t\tERROR(\"Rx queue deferred start is not \"\n+\t\t\t\t\t\"supported for subdevice %d\", i);\n+\t\t\t\tfs_unlock(dev, 0);\n+\t\t\t\treturn -EINVAL;\n+\t\t\t}\n+\t\t}\n \t}\n-\n-\tfs_lock(dev, 0);\n \trxq = dev->data->rx_queues[rx_queue_id];\n \tif (rxq != NULL) {\n \t\tfs_rx_queue_release(rxq);\n@@ -1033,6 +1117,8 @@ const struct eth_dev_ops failsafe_ops = {\n \t.dev_supported_ptypes_get = fs_dev_supported_ptypes_get,\n \t.mtu_set = fs_mtu_set,\n \t.vlan_filter_set = fs_vlan_filter_set,\n+\t.rx_queue_start = fs_rx_queue_start,\n+\t.rx_queue_stop = fs_rx_queue_stop,\n \t.rx_queue_setup = fs_rx_queue_setup,\n \t.tx_queue_setup = fs_tx_queue_setup,\n \t.rx_queue_release = fs_rx_queue_release,\n", "prefixes": [ "v2", "3/4" ] }