Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44975/?format=api
{ "id": 44975, "url": "http://patches.dpdk.org/api/patches/44975/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180919195549.5585-2-dg@adax.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180919195549.5585-2-dg@adax.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180919195549.5585-2-dg@adax.com", "date": "2018-09-19T19:55:45", "name": "[v2,1/5] kni: add API to set link status on kernel interface", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "e60ad38109837714a5c5fa2eeb67bef757334167", "submitter": { "id": 1040, "url": "http://patches.dpdk.org/api/people/1040/?format=api", "name": "Dan Gora", "email": "dg@adax.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180919195549.5585-2-dg@adax.com/mbox/", "series": [ { "id": 1401, "url": "http://patches.dpdk.org/api/series/1401/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1401", "date": "2018-09-19T19:55:44", "name": "kni: add API to set link status on kernel interface", "version": 2, "mbox": "http://patches.dpdk.org/series/1401/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/44975/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/44975/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9F5D51B128;\n\tWed, 19 Sep 2018 21:56:21 +0200 (CEST)", "from mail-qt0-f193.google.com (mail-qt0-f193.google.com\n\t[209.85.216.193]) by dpdk.org (Postfix) with ESMTP id 6F0D11B126\n\tfor <dev@dpdk.org>; Wed, 19 Sep 2018 21:56:20 +0200 (CEST)", "by mail-qt0-f193.google.com with SMTP id l42-v6so6285954qtf.13\n\tfor <dev@dpdk.org>; Wed, 19 Sep 2018 12:56:20 -0700 (PDT)", "from snappy.local.lan ([187.10.145.241])\n\tby smtp.gmail.com with ESMTPSA id\n\tg184-v6sm12431369qkb.15.2018.09.19.12.56.16\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 19 Sep 2018 12:56:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Nz/UmoQLVRgRqvHKfUeCvxAYUgThgWKOV7tL6gEQha0=;\n\tb=XzskoyeigMPc/wghr+5Eh2eAbW4mvc3tJHl3lyrnh9iuhEwcsC6BLQjDahTydLf+7g\n\tpmwVywxlInZ4TE7Lrl/uP0tCrnSwZ3BrNkHJhMKXsE8PXxYioYcZzs0VdX4q3F3YVWSX\n\txpbWsV2T85J1JsJb/rPiSH/kdyRg5YOcATP2Uevq0lA7UqOx8ebw06yFb/kf1yYeChfm\n\t7IXSjVNtuNTLCVfRh9xwr5AmUwY7vcwDR3ow3c6WGPhMx8l3OOgAq9mFhiSauAu3mse1\n\tc+cphdNdsPM8kPB7eEqPlP8WHY9zj3pfyqzwHWtX4CcvrXpKirMKkrWZdHIU8X1QqOcE\n\tZwsg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=Nz/UmoQLVRgRqvHKfUeCvxAYUgThgWKOV7tL6gEQha0=;\n\tb=AVvdM6hQJTLtX2LNoJG8kty6GCWBauyLUlH0CGF/FexjBuIjTCc4x3GpqLjywZ+Qna\n\tyZqEKyQr3st/SGZ4IcPyiQ8tbDebS9Xz5vo19c263mbf7sB1F2xnDvh4Zgfs6te7NBaX\n\tosq3UsvBH1YHDH/09wd18xwQe55a0Pa7TR5qCFrNo9SnfeojZbpsnOiusA+x/i1Hoe8G\n\tjlpRbpsEgeUuRSXP4f+M3M/prHkVr64thF2sGHoYp2ENQmMSh9Uv9xYEa4gWrKAB/7UV\n\t13oPYS2VLFsH5ZyOQYo5tLTOkAd4pmCVi/Loi4cRxMz+cW6I8rhbexQGXfK2bEiaEiMo\n\tri6A==", "X-Gm-Message-State": "APzg51Dp9jxMSMfn1f1ixE36ZyIzxYm1NPQjVnMg5K2fNZ2+EKWa7/Sr\n\tmuYRbzNmFs7pw1YPSlGQchmBUanl", "X-Google-Smtp-Source": "ANB0VdbWlgCbCh+jJZ6jl8Qs3bk594hIM42/tn5gp3In7a00t7hKccSyq3ROFIpAbxxny/giXnP8fQ==", "X-Received": "by 2002:a0c:80a8:: with SMTP id\n\t37-v6mr25651473qvb.13.1537386979348; \n\tWed, 19 Sep 2018 12:56:19 -0700 (PDT)", "From": "Dan Gora <dg@adax.com>", "To": "dev@dpdk.org", "Cc": "Igor Ryzhov <iryzhov@nfware.com>,\n\tStephen Hemminger <stephen@networkplumber.org>, Dan Gora <dg@adax.com>,\n\tFerruh Yigit <ferruh.yigit@intel.com>", "Date": "Wed, 19 Sep 2018 16:55:45 -0300", "Message-Id": "<20180919195549.5585-2-dg@adax.com>", "X-Mailer": "git-send-email 2.19.0", "In-Reply-To": "<20180919195549.5585-1-dg@adax.com>", "References": "<20180911232906.18352-1-dg@adax.com>\n\t<20180919195549.5585-1-dg@adax.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel\n\tinterface", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add a new API function to KNI, rte_kni_update_link() to allow DPDK\napplications to update the link status for KNI network interfaces in\nthe linux kernel.\n\nSigned-off-by: Dan Gora <dg@adax.com>\n---\n lib/librte_kni/rte_kni.c | 57 ++++++++++++++++\n lib/librte_kni/rte_kni.h | 18 ++++++\n lib/librte_kni/rte_kni_version.map | 6 ++\n test/test/test_kni.c | 100 ++++++++++++++++++++++++++++-\n 4 files changed, 180 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c\nindex 65f6a2b03..0c3e17dbb 100644\n--- a/lib/librte_kni/rte_kni.c\n+++ b/lib/librte_kni/rte_kni.c\n@@ -790,6 +790,63 @@ rte_kni_unregister_handlers(struct rte_kni *kni)\n \n \treturn 0;\n }\n+\n+int __rte_experimental\n+rte_kni_update_link(struct rte_kni *kni, struct rte_eth_link *link)\n+{\n+\tchar path[64];\n+\tchar carrier[2];\n+\tconst char *new_carrier;\n+\tint fd, ret;\n+\n+\tif (kni == NULL || link == NULL)\n+\t\treturn -1;\n+\n+\tsnprintf(path, sizeof(path), \"/sys/devices/virtual/net/%s/carrier\",\n+\t\tkni->name);\n+\n+\tfd = open(path, O_RDWR);\n+\tif (fd == -1) {\n+\t\tRTE_LOG(ERR, KNI, \"Failed to open file: %s.\\n\", path);\n+\t\treturn -1;\n+\t}\n+\n+\tret = read(fd, carrier, 2);\n+\tif (ret < 1) {\n+\t\t/* Cannot read carrier until interface is marked\n+\t\t * 'up', so don't log an error.\n+\t\t */\n+\t\tclose(fd);\n+\t\treturn -1;\n+\t}\n+\n+\tnew_carrier = (link->link_status == ETH_LINK_UP) ? \"1\" : \"0\";\n+\tret = write(fd, new_carrier, 1);\n+\tif (ret < 1) {\n+\t\tRTE_LOG(ERR, KNI, \"Failed to write file: %s.\\n\", path);\n+\t\tclose(fd);\n+\t\treturn -1;\n+\t}\n+\n+\tif (strncmp(carrier, new_carrier, 1)) {\n+\t\tif (link->link_status == ETH_LINK_UP) {\n+\t\t\tRTE_LOG(INFO, KNI, \"%s NIC Link is Up %d Mbps %s %s.\\n\",\n+\t\t\t\tkni->name,\n+\t\t\t\tlink->link_speed,\n+\t\t\t\tlink->link_autoneg ? \"(AutoNeg)\" : \"(Fixed)\",\n+\t\t\t\tlink->link_duplex ?\n+\t\t\t\t\t\"Full Duplex\" : \"Half Duplex\");\n+\t\t} else {\n+\t\t\tRTE_LOG(INFO, KNI, \"%s NIC Link is Down.\\n\",\n+\t\t\t\tkni->name);\n+\t\t}\n+\t}\n+\n+\tclose(fd);\n+\n+\treturn 0;\n+}\n+\n void\n rte_kni_close(void)\n {\ndiff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h\nindex 99055e2c2..4118ae97a 100644\n--- a/lib/librte_kni/rte_kni.h\n+++ b/lib/librte_kni/rte_kni.h\n@@ -21,6 +21,7 @@\n #include <rte_memory.h>\n #include <rte_mempool.h>\n #include <rte_ether.h>\n+#include <rte_ethdev.h>\n \n #include <exec-env/rte_kni_common.h>\n \n@@ -228,6 +229,23 @@ int rte_kni_register_handlers(struct rte_kni *kni, struct rte_kni_ops *ops);\n */\n int rte_kni_unregister_handlers(struct rte_kni *kni);\n \n+/**\n+ * Update link status info for KNI port.\n+ *\n+ * Update the linkup/linkdown status of a KNI interface in the kernel.\n+ *\n+ * @param kni\n+ * pointer to struct rte_kni.\n+ * @param link\n+ * pointer to struct rte_eth_link containing new interface status.\n+ *\n+ * @return\n+ * On success: 0\n+ * On failure: -1\n+ */\n+int __rte_experimental\n+rte_kni_update_link(struct rte_kni *kni, struct rte_eth_link *link);\n+\n /**\n * Close KNI device.\n */\ndiff --git a/lib/librte_kni/rte_kni_version.map b/lib/librte_kni/rte_kni_version.map\nindex acd515eb0..c877dc6aa 100644\n--- a/lib/librte_kni/rte_kni_version.map\n+++ b/lib/librte_kni/rte_kni_version.map\n@@ -15,3 +15,9 @@ DPDK_2.0 {\n \n \tlocal: *;\n };\n+\n+EXPERIMENTAL {\n+\tglobal:\n+\n+\trte_kni_update_link;\n+};\ndiff --git a/test/test/test_kni.c b/test/test/test_kni.c\nindex 3dcadcebd..d450cc342 100644\n--- a/test/test/test_kni.c\n+++ b/test/test/test_kni.c\n@@ -118,6 +118,97 @@ kni_change_mtu(uint16_t port_id, unsigned int new_mtu)\n \t\t\t\t\t port_id, kni_pkt_mtu);\n \treturn 0;\n }\n+\n+static int\n+kni_change_link(void)\n+{\n+\tstruct rte_eth_link link;\n+\tint ret;\n+\n+\tlink.link_speed = 10;\n+\tlink.link_status = ETH_LINK_UP;\n+\tlink.link_autoneg = ETH_LINK_AUTONEG;\n+\tlink.link_duplex = ETH_LINK_FULL_DUPLEX;\n+\tret = rte_kni_update_link(test_kni_ctx, &link);\n+\tif (ret != 0) {\n+\t\tprintf(\"Failed to change link state to \"\n+\t\t\t\t\"Up/10Mbps/AutoNeg/Full ret=%d.\\n\", ret);\n+\t\treturn -1;\n+\t}\n+\trte_delay_ms(1000);\n+\n+\tlink.link_speed = 0;\n+\tlink.link_status = ETH_LINK_DOWN;\n+\tlink.link_autoneg = ETH_LINK_FIXED;\n+\tlink.link_duplex = ETH_LINK_FULL_DUPLEX;\n+\tret = rte_kni_update_link(test_kni_ctx, &link);\n+\tif (ret != 0) {\n+\t\tprintf(\"Failed to change link state to Down ret=%d.\\n\", ret);\n+\t\treturn -1;\n+\t}\n+\trte_delay_ms(1000);\n+\n+\tlink.link_speed = 1000;\n+\tlink.link_status = ETH_LINK_UP;\n+\tlink.link_autoneg = ETH_LINK_AUTONEG;\n+\tlink.link_duplex = ETH_LINK_HALF_DUPLEX;\n+\tret = rte_kni_update_link(test_kni_ctx, &link);\n+\tif (ret != 0) {\n+\t\tprintf(\"Failed to change link state to \"\n+\t\t\t\t\"Up/1Gbps/AutoNeg/Half ret=%d.\\n\", ret);\n+\t\treturn -1;\n+\t}\n+\trte_delay_ms(1000);\n+\n+\tlink.link_speed = 0;\n+\tlink.link_status = ETH_LINK_DOWN;\n+\tlink.link_autoneg = ETH_LINK_FIXED;\n+\tlink.link_duplex = ETH_LINK_FULL_DUPLEX;\n+\tret = rte_kni_update_link(test_kni_ctx, &link);\n+\tif (ret != 0) {\n+\t\tprintf(\"Failed to change link state to Down ret=%d.\\n\", ret);\n+\t\treturn -1;\n+\t}\n+\trte_delay_ms(1000);\n+\n+\tlink.link_speed = 40000;\n+\tlink.link_status = ETH_LINK_UP;\n+\tlink.link_autoneg = ETH_LINK_FIXED;\n+\tlink.link_duplex = ETH_LINK_FULL_DUPLEX;\n+\tret = rte_kni_update_link(test_kni_ctx, &link);\n+\tif (ret != 0) {\n+\t\tprintf(\"Failed to change link state to \"\n+\t\t\t\t\"Up/40Gbps/Fixed/Full ret=%d.\\n\", ret);\n+\t\treturn -1;\n+\t}\n+\trte_delay_ms(1000);\n+\n+\tlink.link_speed = 0;\n+\tlink.link_status = ETH_LINK_DOWN;\n+\tlink.link_autoneg = ETH_LINK_FIXED;\n+\tlink.link_duplex = ETH_LINK_FULL_DUPLEX;\n+\tret = rte_kni_update_link(test_kni_ctx, &link);\n+\tif (ret != 0) {\n+\t\tprintf(\"Failed to change link state to Down ret=%d.\\n\", ret);\n+\t\treturn -1;\n+\t}\n+\trte_delay_ms(1000);\n+\n+\tlink.link_speed = 100000;\n+\tlink.link_status = ETH_LINK_UP;\n+\tlink.link_autoneg = ETH_LINK_FIXED;\n+\tlink.link_duplex = ETH_LINK_FULL_DUPLEX;\n+\tret = rte_kni_update_link(test_kni_ctx, &link);\n+\tif (ret != 0) {\n+\t\tprintf(\"Failed to change link state to \"\n+\t\t\t\t\"Up/100Gbps/Fixed/Full ret=%d.\\n\", ret);\n+\t\treturn -1;\n+\t}\n+\trte_delay_ms(1000);\n+\n+\treturn 0;\n+}\n+\n /**\n * This loop fully tests the basic functions of KNI. e.g. transmitting,\n * receiving to, from kernel space, and kernel requests.\n@@ -148,9 +239,16 @@ test_kni_loop(__rte_unused void *arg)\n \t\t\tret = -1;\n \t\tif (system(IFCONFIG TEST_KNI_PORT\" mtu 1400\") == -1)\n \t\t\tret = -1;\n+\n+\t\tret = kni_change_link();\n+\t\tif (ret != 0) {\n+\t\t\ttest_kni_processing_flag = 1;\n+\t\t\treturn ret;\n+\t\t}\n+\t\trte_delay_ms(KNI_TIMEOUT_MS);\n \t\tif (system(IFCONFIG TEST_KNI_PORT\" down\") == -1)\n \t\t\tret = -1;\n-\t\trte_delay_ms(KNI_TIMEOUT_MS);\n+\t\trte_delay_ms(1000);\n \t\ttest_kni_processing_flag = 1;\n \t} else if (lcore_id == lcore_ingress) {\n \t\tstruct rte_mempool *mp = test_kni_lookup_mempool();\n", "prefixes": [ "v2", "1/5" ] }