Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44953/?format=api
{ "id": 44953, "url": "http://patches.dpdk.org/api/patches/44953/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180919150409.22880-3-didier.pallard@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180919150409.22880-3-didier.pallard@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180919150409.22880-3-didier.pallard@6wind.com", "date": "2018-09-19T15:04:07", "name": "[2/4] net/fm10k: fix missing Tx multi segs capability", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "34142c80c0de33d423fbe013d1666569c5a26cf1", "submitter": { "id": 126, "url": "http://patches.dpdk.org/api/people/126/?format=api", "name": "Didier Pallard", "email": "didier.pallard@6wind.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180919150409.22880-3-didier.pallard@6wind.com/mbox/", "series": [ { "id": 1395, "url": "http://patches.dpdk.org/api/series/1395/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1395", "date": "2018-09-19T15:04:05", "name": "fix missing Tx multi segs capabilities", "version": 1, "mbox": "http://patches.dpdk.org/series/1395/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/44953/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/44953/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 704E35689;\n\tWed, 19 Sep 2018 17:04:55 +0200 (CEST)", "from mail-wm1-f67.google.com (mail-wm1-f67.google.com\n\t[209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 5FB234F90\n\tfor <dev@dpdk.org>; Wed, 19 Sep 2018 17:04:53 +0200 (CEST)", "by mail-wm1-f67.google.com with SMTP id s12-v6so6669649wmc.0\n\tfor <dev@dpdk.org>; Wed, 19 Sep 2018 08:04:53 -0700 (PDT)", "from pala.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tz21-v6sm3572751wmi.29.2018.09.19.08.04.52\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 19 Sep 2018 08:04:52 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=hcDqZK8Fc0rYXRWol9IIU+9WaAPz8RioncAIygvBu6Y=;\n\tb=XMtcTnXaFeBlLF4nZNrmD3cVCO+6tOdl8cCCN2mxld5QgkbeTBD2cMaTFSJm5SkVIC\n\tFgPCQpBgjxAwadwWiAXm0hvKiEPsSW7s+LCS7efuCjmFpJaXnpxqpynjQSPxONWHI4Nb\n\tjJAyVj/okRzo3FkY6kmmwQl7woARIPDiZFm7VjRkjblhZmTiuw791lpgjvrDaDVQ7GxZ\n\tlI8i+Cl9OpbPfRnwShHUiwLMmqdPDCxQ46WiWxzVcThzuq2H7DD66XkkkI2X+Id6XR9+\n\t2611dN6sobnHpUCjBB+Rn5x5o9PQjOVpJSU92ExI2qh2f/AVbxNvT9LygGokxp07iUxU\n\t1tUA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=hcDqZK8Fc0rYXRWol9IIU+9WaAPz8RioncAIygvBu6Y=;\n\tb=sduzHBNgUONblibJoSLXKzYTyVfExS9aV72AV7OXgy9zOhdIVghN/SWH82t3R0As9W\n\tSWIeQw4zC9cMslg9AOWzx7lMARJRwF/fBv2pG6GK8A6JAiX1PpOX6XdU8nb3XQ2zFBmb\n\tb9PosmffJzYSLXrh+IQ54bkzClk+AneqJteS9G430dGbko7KTOCWmRaJGKrszSuEAZXk\n\tW4TZrNnAtljxNp1eJj+yj2lGfE0n/93IKeI2gs1mgsbQt8eNreDn/8edlhUk92L8SDDW\n\tQviQ/HGKHD7iHVQDwSpn16Cdrpw+as5HKtQFMKDuEoan9XnmBBYQioUAPmly6Bg2LAqQ\n\t2lVg==", "X-Gm-Message-State": "APzg51B1pbOVuhrXzyX+LWAEDh9RCGfIH4rIeG+rrqgYMHUAxTI27ElT\n\tBQBBeAt5UYy58jmX4zOdeKUpckbjxBTHrg==", "X-Google-Smtp-Source": "ANB0VdZ6jR9B2RGYQojbjf9roJgi0XKdA0QmvmDKA9SJqfRTqcoMAEEvBbBel0H0sB/ys887iTFL5w==", "X-Received": "by 2002:a1c:a614:: with SMTP id\n\tp20-v6mr21311284wme.68.1537369492867; \n\tWed, 19 Sep 2018 08:04:52 -0700 (PDT)", "From": "Didier Pallard <didier.pallard@6wind.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org", "Date": "Wed, 19 Sep 2018 17:04:07 +0200", "Message-Id": "<20180919150409.22880-3-didier.pallard@6wind.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20180919150409.22880-1-didier.pallard@6wind.com>", "References": "<20180919150409.22880-1-didier.pallard@6wind.com>", "Subject": "[dpdk-dev] [PATCH 2/4] net/fm10k: fix missing Tx multi segs\n\tcapability", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating\nthat application will never send multisegmented packets, allowing\npmd to choose different tx methods accordingly.\nIn new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability\nthat is advertised by pmds, some of them do not advertise it and\nexpect to never receive fragmented packets (octeontx, axgbe)\nSo an ethdev that supports multisegmented packets should properly\nadvertise it.\n\nProblem was spotted and tested on e1000, should be also present in\nfm10k.\n\nFixes: 30f3ce999e6a (\"net/fm10k: convert to new Tx offloads API\")\nCc: stable@dpdk.org\n\nSigned-off-by: Didier Pallard <didier.pallard@6wind.com>\n---\n drivers/net/fm10k/fm10k_ethdev.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex 3359df3c8b9c..7cf5b0314c75 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -1975,6 +1975,7 @@ static uint64_t fm10k_get_tx_port_offloads_capa(struct rte_eth_dev *dev)\n \tRTE_SET_USED(dev);\n \n \treturn (uint64_t)(DEV_TX_OFFLOAD_VLAN_INSERT |\n+\t\t\t DEV_TX_OFFLOAD_MULTI_SEGS |\n \t\t\t DEV_TX_OFFLOAD_IPV4_CKSUM |\n \t\t\t DEV_TX_OFFLOAD_UDP_CKSUM |\n \t\t\t DEV_TX_OFFLOAD_TCP_CKSUM |\n", "prefixes": [ "2/4" ] }