Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44950/?format=api
{ "id": 44950, "url": "http://patches.dpdk.org/api/patches/44950/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1537369294-17099-9-git-send-email-amo@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1537369294-17099-9-git-send-email-amo@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1537369294-17099-9-git-send-email-amo@semihalf.com", "date": "2018-09-19T15:01:34", "name": "[v4,8/8] net/mvneta: add reset statistics callback", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b4fe51d3d11dde69dbe8da1f595a492ae63539ee", "submitter": { "id": 1112, "url": "http://patches.dpdk.org/api/people/1112/?format=api", "name": "Andrzej Ostruszka", "email": "amo@semihalf.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1537369294-17099-9-git-send-email-amo@semihalf.com/mbox/", "series": [ { "id": 1394, "url": "http://patches.dpdk.org/api/series/1394/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1394", "date": "2018-09-19T15:01:26", "name": "Add Marvell NETA PMD", "version": 4, "mbox": "http://patches.dpdk.org/series/1394/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/44950/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/44950/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 60A8A5B2E;\n\tWed, 19 Sep 2018 17:01:54 +0200 (CEST)", "from mail-lf1-f52.google.com (mail-lf1-f52.google.com\n\t[209.85.167.52]) by dpdk.org (Postfix) with ESMTP id 058B15B2E\n\tfor <dev@dpdk.org>; Wed, 19 Sep 2018 17:01:52 +0200 (CEST)", "by mail-lf1-f52.google.com with SMTP id x20-v6so5438997lfg.2\n\tfor <dev@dpdk.org>; Wed, 19 Sep 2018 08:01:52 -0700 (PDT)", "from amok.semihalf.local (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173]) by smtp.googlemail.com with ESMTPSA id\n\tz3-v6sm1107711lfj.89.2018.09.19.08.01.45\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 19 Sep 2018 08:01:45 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=J/Mpxh0iAbquGER4dyKuSlIWsF8x+BHd1AY1KimlB6M=;\n\tb=BnCB7MtSnxJB81IrU7jQsYwZTYfXiPVqEyZnGt9cmjX8hUXDaHhdcgs+AHYM7dNWpL\n\tniK1RW6p+g3sDCuM4q/EeO0kU3RCO3wwq1vNaXvD5EkmKZtw44sqvsYCluynWZooBnv+\n\tQF+vCg+YhvC6Z9TWWX1DYlvr/vLbGdM2xti2vhxwOBSsbQNkApbc23l80WGZj157SpQI\n\teWeHByFtJQ1tfQHjdxwua08Ey8n8pt4YSA6Uhjl6xQuFJQiF+D11FUKDKE/b6KzUFs1g\n\tQglhdXF/FHGRvYwimUne3ImBY0UY0a8zPQa9Sv163pl6DSYxPkxFfximnGbkD9pSDHxk\n\tr28A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=J/Mpxh0iAbquGER4dyKuSlIWsF8x+BHd1AY1KimlB6M=;\n\tb=LL6I2ad0s7Iv0dQ/9IjchvixW0U8O5JV3Zf/hf7VjGgKBir9NbmzOP5tPJ1Hb0uNvf\n\tTGnmTU52EYIhq5f0GTsODpl+uOgOhfvA2LTwa4na+EZZdttEpx5Mv3Utaf31NCtkb8hW\n\t4onD1F08Trx6mLfHMUQesFlwb86e6S0kMEkgnebsyGoUxxvlz/ikz4o9HYQJKePXFmul\n\tsBcSx0iOmiOWnZDvIA0kEPra8VkZc/6KjTcIf4jxmqb0yv/IEeel8zgXoZGhAdg3CvJg\n\tC4Qdq89Z41yYktg8M5dtuFle9pqt8crUpwQm40YyfzoTHcAdLgu2ywER1FtfE5EGeRjV\n\tvteQ==", "X-Gm-Message-State": "APzg51AefcDJlriV3Pj3iEMu+MidL5isKAdMoS0v6B7kLCns6MbFTNyn\n\taZKDdpoE5J3xLBe+IZ+iQU+6zFE90Nw=", "X-Google-Smtp-Source": "ANB0VdY/agRWXs1R+Z8fzXYjoAGaujgia7CtYr8MI6GhxJHrHkW9j48CzI77uTrlSGD1+BwHcmzdkg==", "X-Received": "by 2002:a19:9601:: with SMTP id\n\ty1-v6mr23896763lfd.91.1537369307396; \n\tWed, 19 Sep 2018 08:01:47 -0700 (PDT)", "From": "Andrzej Ostruszka <amo@semihalf.com>", "To": "dev@dpdk.org", "Cc": "mw@semihalf.com, zr@semihalf.com, tdu@semihalf.com, nadavh@marvell.com, \n\tNatalie Samsonov <nsamsono@marvell.com>", "Date": "Wed, 19 Sep 2018 17:01:34 +0200", "Message-Id": "<1537369294-17099-9-git-send-email-amo@semihalf.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1537369294-17099-1-git-send-email-amo@semihalf.com>", "References": "<1535720386-18775-1-git-send-email-amo@semihalf.com>\n\t<1537369294-17099-1-git-send-email-amo@semihalf.com>", "Subject": "[dpdk-dev] [PATCH v4 8/8] net/mvneta: add reset statistics callback", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Natalie Samsonov <nsamsono@marvell.com>\n\nAdd support for resetting of driver statistics.\n\nSigned-off-by: Natalie Samsonov <nsamsono@marvell.com>\n---\n drivers/net/mvneta/mvneta_ethdev.c | 40 +++++++++++++++++++++++++++++++-------\n drivers/net/mvneta/mvneta_ethdev.h | 1 +\n 2 files changed, 34 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/net/mvneta/mvneta_ethdev.c\nindex 3ea1dba..40c33cd 100644\n--- a/drivers/net/mvneta/mvneta_ethdev.c\n+++ b/drivers/net/mvneta/mvneta_ethdev.c\n@@ -720,23 +720,48 @@ mvneta_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \n \tstats->ipackets += ppio_stats.rx_packets +\n \t\t\tppio_stats.rx_broadcast_packets +\n-\t\t\tppio_stats.rx_multicast_packets;\n+\t\t\tppio_stats.rx_multicast_packets -\n+\t\t\tpriv->prev_stats.ipackets;\n \tstats->opackets += ppio_stats.tx_packets +\n \t\t\tppio_stats.tx_broadcast_packets +\n-\t\t\tppio_stats.tx_multicast_packets;\n-\tstats->ibytes += ppio_stats.rx_bytes;\n-\tstats->obytes += ppio_stats.tx_bytes;\n+\t\t\tppio_stats.tx_multicast_packets -\n+\t\t\tpriv->prev_stats.opackets;\n+\tstats->ibytes += ppio_stats.rx_bytes - priv->prev_stats.ibytes;\n+\tstats->obytes += ppio_stats.tx_bytes - priv->prev_stats.obytes;\n \tstats->imissed += ppio_stats.rx_discard +\n-\t\t\t ppio_stats.rx_overrun;\n+\t\t\t ppio_stats.rx_overrun -\n+\t\t\t priv->prev_stats.imissed;\n \n \tstats->ierrors = ppio_stats.rx_packets_err +\n \t\t\tppio_stats.rx_errors +\n-\t\t\tppio_stats.rx_crc_error;\n-\tstats->oerrors = ppio_stats.tx_errors;\n+\t\t\tppio_stats.rx_crc_error -\n+\t\t\tpriv->prev_stats.ierrors;\n+\tstats->oerrors = ppio_stats.tx_errors - priv->prev_stats.oerrors;\n \n \treturn 0;\n }\n \n+/**\n+ * DPDK callback to clear device statistics.\n+ *\n+ * @param dev\n+ * Pointer to Ethernet device structure.\n+ */\n+static void\n+mvneta_stats_reset(struct rte_eth_dev *dev)\n+{\n+\tstruct mvneta_priv *priv = dev->data->dev_private;\n+\tunsigned int ret;\n+\n+\tif (!priv->ppio)\n+\t\treturn;\n+\n+\tret = mvneta_stats_get(dev, &priv->prev_stats);\n+\tif (unlikely(ret))\n+\t\tRTE_LOG(ERR, PMD, \"Failed to reset port statistics\");\n+}\n+\n+\n static const struct eth_dev_ops mvneta_ops = {\n \t.dev_configure = mvneta_dev_configure,\n \t.dev_start = mvneta_dev_start,\n@@ -752,6 +777,7 @@ static const struct eth_dev_ops mvneta_ops = {\n \t.mac_addr_set = mvneta_mac_addr_set,\n \t.mtu_set = mvneta_mtu_set,\n \t.stats_get = mvneta_stats_get,\n+\t.stats_reset = mvneta_stats_reset,\n \t.dev_infos_get = mvneta_dev_infos_get,\n \t.dev_supported_ptypes_get = mvneta_dev_supported_ptypes_get,\n \t.rxq_info_get = mvneta_rxq_info_get,\ndiff --git a/drivers/net/mvneta/mvneta_ethdev.h b/drivers/net/mvneta/mvneta_ethdev.h\nindex 1a78a41..eeea31a 100644\n--- a/drivers/net/mvneta/mvneta_ethdev.h\n+++ b/drivers/net/mvneta/mvneta_ethdev.h\n@@ -67,6 +67,7 @@ struct mvneta_priv {\n \tuint16_t nb_rx_queues;\n \n \tuint64_t rate_max;\n+\tstruct rte_eth_stats prev_stats;\n };\n \n /** Current log type. */\n", "prefixes": [ "v4", "8/8" ] }