Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44941/?format=api
{ "id": 44941, "url": "http://patches.dpdk.org/api/patches/44941/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180919144208.17064-1-didier.pallard@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180919144208.17064-1-didier.pallard@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180919144208.17064-1-didier.pallard@6wind.com", "date": "2018-09-19T14:42:08", "name": "net: fix Intel prepare function for IP checksum offload", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d027fa76c9480c8f6301641715ca1ba15ea47d82", "submitter": { "id": 126, "url": "http://patches.dpdk.org/api/people/126/?format=api", "name": "Didier Pallard", "email": "didier.pallard@6wind.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180919144208.17064-1-didier.pallard@6wind.com/mbox/", "series": [ { "id": 1393, "url": "http://patches.dpdk.org/api/series/1393/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1393", "date": "2018-09-19T14:42:08", "name": "net: fix Intel prepare function for IP checksum offload", "version": 1, "mbox": "http://patches.dpdk.org/series/1393/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/44941/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/44941/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 648823772;\n\tWed, 19 Sep 2018 16:42:33 +0200 (CEST)", "from mail-wm1-f68.google.com (mail-wm1-f68.google.com\n\t[209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 150601B53\n\tfor <dev@dpdk.org>; Wed, 19 Sep 2018 16:42:31 +0200 (CEST)", "by mail-wm1-f68.google.com with SMTP id q8-v6so7298227wmq.4\n\tfor <dev@dpdk.org>; Wed, 19 Sep 2018 07:42:31 -0700 (PDT)", "from pala.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tc3-v6sm25716246wrm.56.2018.09.19.07.42.29\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 19 Sep 2018 07:42:29 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=K92hwt4uK6szi6ZRlIUxBr+M9JNRbALGThdZANMlflI=;\n\tb=aRoEvtSs4670cqkIUHiJNhCSU3kOVAtmQfP8TvnBTeUhj1cSEnCy2JIDUZjbdAxOPI\n\tg+A6SH36rMNztv7vwIK5cJe3RVjCjhRPDkO7QOyJp+F4E27X6J1nIISi+oebh9z/dQCE\n\tIHA+lHkWnq81UY6e+uvKY78GbmIEnV0E7XkPEk8JaOy/uiHuukjjSDh2XcYCr76KgFjm\n\tcvDk84ZiIW7+uMkqXAUlniJeQJ+dnVVJ5kHCj6xUqO4e69DMcR8iqlm5CTsFAx5uzEmH\n\tziL5BEuuUJbjTU4sYklAui9EhNo0lg2tgdOEXp+SYl8dxTaDe1RS7MJITTAobxxD3M/M\n\tUvDQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=K92hwt4uK6szi6ZRlIUxBr+M9JNRbALGThdZANMlflI=;\n\tb=a72TwY6vGmjZ4YB2gPh1XuSpeUN5YHGVX0xnSPcbRWA5Vb+yGDdntb2Bnl5sSWiEGc\n\tki8ZF6AMc01U6C3SlTpuMsj9puVi+ZJTAUXPYJztPA6ZknueXr35Zc0NuafQGgePuVOt\n\ttTfY/L1M4ofryhH1dh5pY4rucupP1S/B0VUxrg7T8UALholBqL14hVNoT41puvuDtq2D\n\typsp3x+9aA+Gx8BMFTVwYJ35zRSfd2rpexoyHlNLoi/Cv/6Gd0aFe0vhaaVc0LUVehFy\n\tXylsBZrmz68Ek6p93zpAHL8iPiRrde0zT0MKlRcZEgMVlVnVu9I1SRtX7a6vZODG6Yke\n\tBpGQ==", "X-Gm-Message-State": "APzg51DwNzqznB6N98c2Kma4OooiN3QMoC9+3o7OFAGtdSNhsSgroakz\n\t3X+wy6LHzkITwgK63Wxsi6g8fJGgiovPaw==", "X-Google-Smtp-Source": "ANB0Vdb5+RP/2dX5VyrjDm3lpKItil5kpLq1CbJ1IqEDvNdvR/r3TlkzmwV9TsdkM3kZssBC6kYZqQ==", "X-Received": "by 2002:a1c:3d07:: with SMTP id\n\tk7-v6mr21414774wma.146.1537368150740; \n\tWed, 19 Sep 2018 07:42:30 -0700 (PDT)", "From": "Didier Pallard <didier.pallard@6wind.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org", "Date": "Wed, 19 Sep 2018 16:42:08 +0200", "Message-Id": "<20180919144208.17064-1-didier.pallard@6wind.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[dpdk-dev] [PATCH] net: fix Intel prepare function for IP checksum\n\toffload", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Current Intel tx prepare function does not properly handle the\ncase where only IP checksum is requested, without requesting\nany L4 checksum or TSO: IP checksum is not properly reset to 0\nand output packet may contain invalid IP checksum.\n\nFixes: 4fb7e803eb1a (\"ethdev: add Tx preparation\")\nCc: stable@dpdk.org\n\nSigned-off-by: Didier Pallard <didier.pallard@6wind.com>\n---\n lib/librte_net/rte_net.h | 20 ++++++++------------\n 1 file changed, 8 insertions(+), 12 deletions(-)", "diff": "diff --git a/lib/librte_net/rte_net.h b/lib/librte_net/rte_net.h\nindex b6ab6e1d57b2..e59760a0a108 100644\n--- a/lib/librte_net/rte_net.h\n+++ b/lib/librte_net/rte_net.h\n@@ -122,14 +122,16 @@ rte_net_intel_cksum_flags_prepare(struct rte_mbuf *m, uint64_t ol_flags)\n \t\t(ol_flags & PKT_TX_OUTER_IPV6))\n \t\tinner_l3_offset += m->outer_l2_len + m->outer_l3_len;\n \n-\tif ((ol_flags & PKT_TX_UDP_CKSUM) == PKT_TX_UDP_CKSUM) {\n-\t\tif (ol_flags & PKT_TX_IPV4) {\n-\t\t\tipv4_hdr = rte_pktmbuf_mtod_offset(m, struct ipv4_hdr *,\n-\t\t\t\t\tinner_l3_offset);\n+\tif (ol_flags & PKT_TX_IPV4) {\n+\t\tipv4_hdr = rte_pktmbuf_mtod_offset(m, struct ipv4_hdr *,\n+\t\t\t\tinner_l3_offset);\n \n-\t\t\tif (ol_flags & PKT_TX_IP_CKSUM)\n-\t\t\t\tipv4_hdr->hdr_checksum = 0;\n+\t\tif (ol_flags & PKT_TX_IP_CKSUM)\n+\t\t\tipv4_hdr->hdr_checksum = 0;\n+\t}\n \n+\tif ((ol_flags & PKT_TX_UDP_CKSUM) == PKT_TX_UDP_CKSUM) {\n+\t\tif (ol_flags & PKT_TX_IPV4) {\n \t\t\tudp_hdr = (struct udp_hdr *)((char *)ipv4_hdr +\n \t\t\t\t\tm->l3_len);\n \t\t\tudp_hdr->dgram_cksum = rte_ipv4_phdr_cksum(ipv4_hdr,\n@@ -146,12 +148,6 @@ rte_net_intel_cksum_flags_prepare(struct rte_mbuf *m, uint64_t ol_flags)\n \t} else if ((ol_flags & PKT_TX_TCP_CKSUM) ||\n \t\t\t(ol_flags & PKT_TX_TCP_SEG)) {\n \t\tif (ol_flags & PKT_TX_IPV4) {\n-\t\t\tipv4_hdr = rte_pktmbuf_mtod_offset(m, struct ipv4_hdr *,\n-\t\t\t\t\tinner_l3_offset);\n-\n-\t\t\tif (ol_flags & PKT_TX_IP_CKSUM)\n-\t\t\t\tipv4_hdr->hdr_checksum = 0;\n-\n \t\t\t/* non-TSO tcp or TSO */\n \t\t\ttcp_hdr = (struct tcp_hdr *)((char *)ipv4_hdr +\n \t\t\t\t\tm->l3_len);\n", "prefixes": [] }