Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44895/?format=api
{ "id": 44895, "url": "http://patches.dpdk.org/api/patches/44895/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180919064814.21645-11-yskoh@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180919064814.21645-11-yskoh@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180919064814.21645-11-yskoh@mellanox.com", "date": "2018-09-19T06:48:46", "name": "[10/11] net/mlx5: add Direct Verbs final functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "61dad709ecd6bda71d4dbd74c00ea7e95e08b9a3", "submitter": { "id": 636, "url": "http://patches.dpdk.org/api/people/636/?format=api", "name": "Yongseok Koh", "email": "yskoh@mellanox.com" }, "delegate": { "id": 6624, "url": "http://patches.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180919064814.21645-11-yskoh@mellanox.com/mbox/", "series": [ { "id": 1380, "url": "http://patches.dpdk.org/api/series/1380/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1380", "date": "2018-09-19T06:48:29", "name": "net/mlx5: add Direct Verbs flow driver support", "version": 1, "mbox": "http://patches.dpdk.org/series/1380/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/44895/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/44895/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9C7305F13;\n\tWed, 19 Sep 2018 08:48:53 +0200 (CEST)", "from EUR03-VE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr50089.outbound.protection.outlook.com [40.107.5.89])\n\tby dpdk.org (Postfix) with ESMTP id 570162BD3\n\tfor <dev@dpdk.org>; Wed, 19 Sep 2018 08:48:47 +0200 (CEST)", "from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by\n\tDB3PR0502MB4010.eurprd05.prod.outlook.com (52.134.72.139) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1143.18; Wed, 19 Sep 2018 06:48:46 +0000", "from DB3PR0502MB3980.eurprd05.prod.outlook.com\n\t([fe80::452:cfe7:8363:61c1]) by\n\tDB3PR0502MB3980.eurprd05.prod.outlook.com\n\t([fe80::452:cfe7:8363:61c1%2]) with mapi id 15.20.1143.017;\n\tWed, 19 Sep 2018 06:48:46 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=CIHgVYJtMMM1uwLlHlEOnf1JEi8dQXRW/Zf7RBrCz8U=;\n\tb=oHQv+zm3b5m51feAStud6HayOzL0gaf25QQEm7XBkp1TgdrtCYGPFts0yiwokyudI/e5bAofD9xN4ziyQ5Rv3hwAOm9MmgFBddWHwWN+ob4SiWS35xIOTqDvy/nE5FbJKv3XogFA7x4FMIMyTiUSglQhBHdYZsbUwGOCsvwOu6Q=", "From": "Yongseok Koh <yskoh@mellanox.com>", "To": "Shahaf Shuler <shahafs@mellanox.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, Ori Kam <orika@mellanox.com>", "Thread-Topic": "[PATCH 10/11] net/mlx5: add Direct Verbs final functions", "Thread-Index": "AQHUT+TPkhNIcEy0UUuOWHhqVT2/kw==", "Date": "Wed, 19 Sep 2018 06:48:46 +0000", "Message-ID": "<20180919064814.21645-11-yskoh@mellanox.com>", "References": "<20180919064814.21645-1-yskoh@mellanox.com>", "In-Reply-To": "<20180919064814.21645-1-yskoh@mellanox.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "CY4PR19CA0042.namprd19.prod.outlook.com\n\t(2603:10b6:903:103::28) To DB3PR0502MB3980.eurprd05.prod.outlook.com\n\t(2603:10a6:8:10::27)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=yskoh@mellanox.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-originating-ip": "[209.116.155.178]", "x-ms-publictraffictype": "Email", "x-microsoft-exchange-diagnostics": "1; DB3PR0502MB4010;\n\t6:tCNw4lnbUBTUzZRaqmCMT9d5oZ2xKDSjgMKZqdzIAlAH5dJzjHrSpIqRsINnkm/PO6zLSOvCrO6pgu4h824cxpkRz/cq3TNC/Kr/RsFzWf+JHrcDgI4/X3oCXSmn1DE9sE635gL+XMQgP9XkumvYtjh1C/D7CTvaKRiasr2dpCQWU+T6luVZcqkxEYn6oJzuQVRYQVBiFuE/hx77O4dbyG0gu6y2bVA2Ic0z3KxiH9juKiKkHJUlO40+m7d+4GxygRt+/stiJ88GFSkBITolDFG24rp0sKd32ldT7C4rW4rO+aEuwMjZH1ytH23QqQloKb1XisO46Fzv9kTKbZjZZWYBfBGdk1jluLQ8BOwGBTXvUioIP+JYMsNGCsc4Nl7h8ZKMqJosRBydf3VENONr5p4yNCVxbSiEk5WlP6jYBd9WE+xjfmymX2Xoh3NnsPMjrhtpTDufaPMejILM1zSh0Q==;\n\t5:Ji5idoZoCbd50pLHWZi0+nL/xVKqSkkRK98f8nsdASxQpxSFjqywIQ8XdxCjKN52DQUmcRb1mXwp4anqXaaD71oMqxvN89RtnNF40yaBdiR91pOo/NTvR+jHA9aWJmRvo+KGZm32henCaNYw4opo1qjAz1DbMoVG4qqybx/Fdw4=;\n\t7:3OecPwHVWmkoGQhV6yZwnLPlmVl+SoR1uHtJE5KfuEyAqMZvWGVU3FmBNgSh1ebSIi6JiSTbKjIIQVGOVPuFQoESJI/P3URDn04DSzeqIVaZTzlKUYTgnjZ5PCeqabCi26kgev/skp9veJrWnNa98iKW3PzUWABvij2hpBTvrPGzJk9jCt/SQR3UInBdutu/ZSG0/6MJPG4EtgQXYf5fCQ+4Q59ZQt2WtKq/2lp/iV+E6z9M1QFYsmZ6mhrVd0Gu", "x-ms-office365-filtering-correlation-id": "ace1a85b-cc79-45c1-b745-08d61dfbf24c", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);\n\tSRVR:DB3PR0502MB4010; ", "x-ms-traffictypediagnostic": "DB3PR0502MB4010:", "x-microsoft-antispam-prvs": "<DB3PR0502MB40105141229B35E346A453F9C31C0@DB3PR0502MB4010.eurprd05.prod.outlook.com>", "x-exchange-antispam-report-test": "UriScan:;", "x-ms-exchange-senderadcheck": "1", "x-exchange-antispam-report-cfa-test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231355)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699050);\n\tSRVR:DB3PR0502MB4010; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB4010; ", "x-forefront-prvs": "0800C0C167", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(1496009)(396003)(376002)(39860400002)(346002)(366004)(136003)(189003)(199004)(5250100002)(6512007)(107886003)(6862004)(54906003)(97736004)(6636002)(478600001)(8936002)(8676002)(76176011)(14454004)(36756003)(4326008)(26005)(37006003)(25786009)(53936002)(5660300001)(68736007)(52116002)(99286004)(6506007)(86362001)(386003)(6116002)(7736002)(81156014)(305945005)(81166006)(106356001)(316002)(446003)(2900100001)(105586002)(102836004)(66066001)(2616005)(6436002)(11346002)(6486002)(476003)(256004)(1076002)(14444005)(575784001)(2906002)(486006)(3846002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4010;\n\tH:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; \n\tPTR:InfoNoRecords; MX:1; A:1; ", "received-spf": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)", "x-microsoft-antispam-message-info": "Yzmaip3g4sbpXkAQ0ZVW4igi1fc5aMrjtHUhOlJZuoiTcqarbek6Xnfn/0bh9USE2EmH6fP9ZDtfP/ONnSJ5xw/xjt8NyIzQzM6VbbGnaiosNfyJT9wS0l/4BoACMmEBpovrqc84kBSV28k9uxWpFPktFe47rGfUWTe0aoBdMThGVGKqp34C5oy+MiYvmGnElA6S1jWNeluTaZN6EIbejzQHtoYvl8qiWtlWPJDTq1EY/fzil8BWHMJNfwtLilSnnR+oBHUtoovA0hrme/OCTmlg1AWuXScI0OH5i49TYpw+bfJ4GThbDcfKOjm29T9OJHrPqFjmitONoqbcjf+zEJpDqdi5HdD6v/sM+0dfp8Y=", "spamdiagnosticoutput": "1:99", "spamdiagnosticmetadata": "NSPM", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "ace1a85b-cc79-45c1-b745-08d61dfbf24c", "X-MS-Exchange-CrossTenant-originalarrivaltime": "19 Sep 2018 06:48:46.2327\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB3PR0502MB4010", "Subject": "[dpdk-dev] [PATCH 10/11] net/mlx5: add Direct Verbs final functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ori Kam <orika@mellanox.com>\n\nThis commits add the missing function which are apply, remove, and\ndestroy.\n\nSigned-off-by: Ori Kam <orika@mellanox.com>\nAcked-by: Yongseok Koh <yskoh@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 4 +\n drivers/net/mlx5/mlx5_flow.h | 2 +\n drivers/net/mlx5/mlx5_flow_dv.c | 192 +++++++++++++++++++++++++++++++++++++++-\n 3 files changed, 194 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex c0c7cfd78..6aec6b1d8 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -2474,5 +2474,9 @@ mlx5_dev_filter_ctrl(struct rte_eth_dev *dev,\n void\n mlx5_flow_init_driver_ops(struct rte_eth_dev *dev __rte_unused)\n {\n+#ifdef HAVE_IBV_FLOW_DV_SUPPORT\n+\tmlx5_flow_dv_get_driver_ops(&nic_ops);\n+#else\n \tmlx5_flow_verbs_get_driver_ops(&nic_ops);\n+#endif\n }\ndiff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h\nindex ec860ef4b..53c0eeb56 100644\n--- a/drivers/net/mlx5/mlx5_flow.h\n+++ b/drivers/net/mlx5/mlx5_flow.h\n@@ -189,7 +189,9 @@ struct mlx5_flow {\n \tstruct rte_flow *flow; /**< Pointer to the main flow. */\n \tuint32_t layers; /**< Bit-fields that holds the detected layers. */\n \tunion {\n+#ifdef HAVE_IBV_FLOW_DV_SUPPORT\n \t\tstruct mlx5_flow_dv dv;\n+#endif\n \t\tstruct mlx5_flow_verbs verbs;\n \t};\n };\ndiff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 916989988..71af410b2 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -2,6 +2,7 @@\n * Copyright 2018 Mellanox Technologies, Ltd\n */\n \n+\n #include <sys/queue.h>\n #include <stdalign.h>\n #include <stdint.h>\n@@ -1095,7 +1096,7 @@ flow_dv_matcher_register(struct rte_eth_dev *dev,\n \tif (matcher->egress)\n \t\tdv_attr.flags |= IBV_FLOW_ATTR_FLAGS_EGRESS;\n \tcache->cache.resource =\n-\t\tmlx5dv_create_flow_matcher(priv->ctx, &dv_attr);\n+\t\tmlx5_glue->dv_create_flow_matcher(priv->ctx, &dv_attr);\n \tif (!cache->cache.resource)\n \t\treturn rte_flow_error_set(error, ENOMEM,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n@@ -1168,6 +1169,189 @@ flow_dv_translate(struct rte_eth_dev *dev,\n }\n \n /**\n+ * Apply the flow to the NIC.\n+ *\n+ * @param[in] dev\n+ * Pointer to the Ethernet device structure.\n+ * @param[in, out] flow\n+ * Pointer to flow structure.\n+ * @param[out] error\n+ * Pointer to error structure.\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+static int\n+flow_dv_apply(struct rte_eth_dev *dev, struct rte_flow *flow,\n+\t struct rte_flow_error *error)\n+{\n+\tstruct mlx5_flow_dv *dv;\n+\tstruct mlx5_flow *dev_flow;\n+\tint n;\n+\tint err;\n+\n+\tLIST_FOREACH(dev_flow, &flow->dev_flows, next) {\n+\t\tdv = &dev_flow->dv;\n+\t\tn = dv->actions_n;\n+\t\tif (flow->actions & MLX5_ACTION_DROP) {\n+\t\t\tdv->hrxq = mlx5_hrxq_drop_new(dev);\n+\t\t\tif (!dv->hrxq) {\n+\t\t\t\trte_flow_error_set\n+\t\t\t\t\t(error, errno,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,\n+\t\t\t\t\t \"cannot get drop hash queue\");\n+\t\t\t\tgoto error;\n+\t\t\t}\n+\t\t\tdv->actions[n].type = MLX5DV_FLOW_ACTION_DEST_IBV_QP;\n+\t\t\tdv->actions[n].qp = dv->hrxq->qp;\n+\t\t\tn++;\n+\t\t} else {\n+\t\t\tstruct mlx5_hrxq *hrxq;\n+\t\t\thrxq = mlx5_hrxq_get(dev, flow->key,\n+\t\t\t\t\t MLX5_RSS_HASH_KEY_LEN,\n+\t\t\t\t\t dv->hash_fields,\n+\t\t\t\t\t (*flow->queue),\n+\t\t\t\t\t flow->rss.queue_num);\n+\t\t\tif (!hrxq)\n+\t\t\t\thrxq = mlx5_hrxq_new\n+\t\t\t\t\t(dev, flow->key, MLX5_RSS_HASH_KEY_LEN,\n+\t\t\t\t\t dv->hash_fields, (*flow->queue),\n+\t\t\t\t\t flow->rss.queue_num,\n+\t\t\t\t\t !!(flow->layers &\n+\t\t\t\t\t MLX5_FLOW_LAYER_TUNNEL));\n+\t\t\tif (!hrxq) {\n+\t\t\t\trte_flow_error_set\n+\t\t\t\t\t(error, rte_errno,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,\n+\t\t\t\t\t \"cannot get hash queue\");\n+\t\t\t\tgoto error;\n+\t\t\t}\n+\t\t\tdv->hrxq = hrxq;\n+\t\t\tdv->actions[n].type = MLX5DV_FLOW_ACTION_DEST_IBV_QP;\n+\t\t\tdv->actions[n].qp = hrxq->qp;\n+\t\t\tn++;\n+\t\t}\n+\t\tdv->flow =\n+\t\t\tmlx5_glue->dv_create_flow(dv->matcher->cache.resource,\n+\t\t\t\t\t\t (void *)&dv->value, n,\n+\t\t\t\t\t\t dv->actions);\n+\t\tif (!dv->flow) {\n+\t\t\trte_flow_error_set(error, errno,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t \"hardware refuses to create flow\");\n+\t\t\tgoto error;\n+\t\t}\n+\t}\n+\treturn 0;\n+error:\n+\terr = rte_errno; /* Save rte_errno before cleanup. */\n+\tLIST_FOREACH(dev_flow, &flow->dev_flows, next) {\n+\t\tstruct mlx5_flow_dv *dv = &dev_flow->dv;\n+\t\tif (dv->hrxq) {\n+\t\t\tif (flow->actions & MLX5_FLOW_FATE_DROP)\n+\t\t\t\tmlx5_hrxq_drop_release(dev);\n+\t\t\telse\n+\t\t\t\tmlx5_hrxq_release(dev, dv->hrxq);\n+\t\t\tdv->hrxq = NULL;\n+\t\t}\n+\t}\n+\trte_errno = err; /* Restore rte_errno. */\n+\treturn -rte_errno;\n+}\n+\n+/**\n+ * Release the flow matcher.\n+ *\n+ * @param dev\n+ * Pointer to Ethernet device.\n+ * @param matcher\n+ * Pointer to flow matcher.\n+ *\n+ * @return\n+ * 1 while a reference on it exists, 0 when freed.\n+ */\n+static int\n+flow_dv_matcher_release(struct rte_eth_dev *dev,\n+\t\t\tstruct mlx5_flow_dv_matcher *matcher)\n+{\n+\tstruct mlx5_cache *cache = &matcher->cache;\n+\n+\tassert(cache->resource);\n+\tDRV_LOG(DEBUG, \"port %u matcher %p: refcnt %d--\",\n+\t\tdev->data->port_id, (void *)cache,\n+\t\trte_atomic32_read(&cache->refcnt));\n+\tif (rte_atomic32_dec_and_test(&cache->refcnt)) {\n+\t\tclaim_zero(mlx5_glue->dv_destroy_flow_matcher(cache->resource));\n+\t\tLIST_REMOVE(cache, next);\n+\t\trte_free(cache);\n+\t\tDRV_LOG(DEBUG, \"port %u matcher %p: removed\",\n+\t\t\tdev->data->port_id, (void *)cache);\n+\t\treturn 0;\n+\t}\n+\treturn 1;\n+}\n+\n+/**\n+ * Remove the flow from the NIC but keeps it in memory.\n+ *\n+ * @param[in] dev\n+ * Pointer to Ethernet device.\n+ * @param[in, out] flow\n+ * Pointer to flow structure.\n+ */\n+static void\n+flow_dv_remove(struct rte_eth_dev *dev, struct rte_flow *flow)\n+{\n+\tstruct mlx5_flow_dv *dv;\n+\tstruct mlx5_flow *dev_flow;\n+\n+\tif (!flow)\n+\t\treturn;\n+\tLIST_FOREACH(dev_flow, &flow->dev_flows, next) {\n+\t\tdv = &dev_flow->dv;\n+\t\tif (dv->flow) {\n+\t\t\tclaim_zero(mlx5_glue->destroy_flow(dv->flow));\n+\t\t\tdv->flow = NULL;\n+\t\t}\n+\t\tif (dv->hrxq) {\n+\t\t\tif (flow->actions & MLX5_ACTION_DROP)\n+\t\t\t\tmlx5_hrxq_drop_release(dev);\n+\t\t\telse\n+\t\t\t\tmlx5_hrxq_release(dev, dv->hrxq);\n+\t\t\tdv->hrxq = NULL;\n+\t\t}\n+\t}\n+\tif (flow->counter)\n+\t\tflow->counter = NULL;\n+}\n+\n+/**\n+ * Remove the flow from the NIC and the memory.\n+ *\n+ * @param[in] dev\n+ * Pointer to the Ethernet device structure.\n+ * @param[in, out] flow\n+ * Pointer to flow structure.\n+ */\n+static void\n+flow_dv_destroy(struct rte_eth_dev *dev, struct rte_flow *flow)\n+{\n+\tstruct mlx5_flow *dev_flow;\n+\n+\tif (!flow)\n+\t\treturn;\n+\tflow_dv_remove(dev, flow);\n+\twhile (!LIST_EMPTY(&flow->dev_flows)) {\n+\t\tdev_flow = LIST_FIRST(&flow->dev_flows);\n+\t\tLIST_REMOVE(dev_flow, next);\n+\t\tif (dev_flow->dv.matcher)\n+\t\t\tflow_dv_matcher_release(dev, dev_flow->dv.matcher);\n+\t\trte_free(dev_flow);\n+\t}\n+}\n+\n+/**\n * Fills the flow_ops with the function pointers.\n *\n * @param[out] flow_ops\n@@ -1180,9 +1364,9 @@ mlx5_flow_dv_get_driver_ops(struct mlx5_flow_driver_ops *flow_ops)\n \t\t.validate = flow_dv_validate,\n \t\t.prepare = flow_dv_prepare,\n \t\t.translate = flow_dv_translate,\n-\t\t.apply = NULL,\n-\t\t.remove = NULL,\n-\t\t.destroy = NULL,\n+\t\t.apply = flow_dv_apply,\n+\t\t.remove = flow_dv_remove,\n+\t\t.destroy = flow_dv_destroy,\n \t};\n }\n \n", "prefixes": [ "10/11" ] }