Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 44876,
    "url": "http://patches.dpdk.org/api/patches/44876/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180918165835.107593-8-jasvinder.singh@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180918165835.107593-8-jasvinder.singh@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180918165835.107593-8-jasvinder.singh@intel.com",
    "date": "2018-09-18T16:58:32",
    "name": "[v4,07/10] net/softnic: update dscp table",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "dab913ee4188c501b58e704906a22078c00f24ff",
    "submitter": {
        "id": 285,
        "url": "http://patches.dpdk.org/api/people/285/?format=api",
        "name": "Jasvinder Singh",
        "email": "jasvinder.singh@intel.com"
    },
    "delegate": {
        "id": 10018,
        "url": "http://patches.dpdk.org/api/users/10018/?format=api",
        "username": "cristian_dumitrescu",
        "first_name": "Cristian",
        "last_name": "Dumitrescu",
        "email": "cristian.dumitrescu@intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180918165835.107593-8-jasvinder.singh@intel.com/mbox/",
    "series": [
        {
            "id": 1374,
            "url": "http://patches.dpdk.org/api/series/1374/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1374",
            "date": "2018-09-18T16:58:25",
            "name": "net/softnic: implement metering and policing API",
            "version": 4,
            "mbox": "http://patches.dpdk.org/series/1374/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/44876/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/44876/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D844B5F57;\n\tTue, 18 Sep 2018 18:59:05 +0200 (CEST)",
            "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 980D35B1C\n\tfor <dev@dpdk.org>; Tue, 18 Sep 2018 18:58:49 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Sep 2018 09:58:46 -0700",
            "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.222.149])\n\tby fmsmga002.fm.intel.com with ESMTP; 18 Sep 2018 09:58:42 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.53,390,1531810800\"; d=\"scan'208\";a=\"87193999\"",
        "From": "Jasvinder Singh <jasvinder.singh@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "cristian.dumitrescu@intel.com",
        "Date": "Tue, 18 Sep 2018 17:58:32 +0100",
        "Message-Id": "<20180918165835.107593-8-jasvinder.singh@intel.com>",
        "X-Mailer": "git-send-email 2.9.3",
        "In-Reply-To": "<20180918165835.107593-1-jasvinder.singh@intel.com>",
        "References": "<20180914174554.90135-2-jasvinder.singh@intel.com>\n\t<20180918165835.107593-1-jasvinder.singh@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v4 07/10] net/softnic: update dscp table",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Implement meter object dscp table update.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\n---\n drivers/net/softnic/rte_eth_softnic_internals.h |  1 +\n drivers/net/softnic/rte_eth_softnic_meter.c     | 54 ++++++++++++++++++++++++-\n drivers/net/softnic/rte_eth_softnic_pipeline.c  |  1 +\n drivers/net/softnic/rte_eth_softnic_thread.c    | 10 +++++\n 4 files changed, 65 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/softnic/rte_eth_softnic_internals.h b/drivers/net/softnic/rte_eth_softnic_internals.h\nindex 4b0f54c..78864e7 100644\n--- a/drivers/net/softnic/rte_eth_softnic_internals.h\n+++ b/drivers/net/softnic/rte_eth_softnic_internals.h\n@@ -464,6 +464,7 @@ struct softnic_table {\n \tstruct softnic_table_action_profile *ap;\n \tstruct rte_table_action *a;\n \tstruct flow_list flows;\n+\tstruct rte_table_action_dscp_table dscp_table;\n \tstruct softnic_table_meter_profile_list meter_profiles;\n };\n \ndiff --git a/drivers/net/softnic/rte_eth_softnic_meter.c b/drivers/net/softnic/rte_eth_softnic_meter.c\nindex 68daf8a..ed44767 100644\n--- a/drivers/net/softnic/rte_eth_softnic_meter.c\n+++ b/drivers/net/softnic/rte_eth_softnic_meter.c\n@@ -433,6 +433,58 @@ pmd_mtr_meter_profile_update(struct rte_eth_dev *dev,\n \treturn 0;\n }\n \n+/* MTR object meter DSCP table update */\n+static int\n+pmd_mtr_meter_dscp_table_update(struct rte_eth_dev *dev,\n+\tuint32_t mtr_id,\n+\tenum rte_mtr_color *dscp_table,\n+\tstruct rte_mtr_error *error)\n+{\n+\tstruct pmd_internals *p = dev->data->dev_private;\n+\tstruct rte_table_action_dscp_table dt;\n+\tstruct pipeline *pipeline;\n+\tstruct softnic_table *table;\n+\tstruct softnic_mtr *m;\n+\tuint32_t table_id, i;\n+\tint status;\n+\n+\t/* MTR object id must be valid */\n+\tm = softnic_mtr_find(p, mtr_id);\n+\tif (m == NULL)\n+\t\treturn -rte_mtr_error_set(error,\n+\t\t\tEEXIST,\n+\t\t\tRTE_MTR_ERROR_TYPE_MTR_ID,\n+\t\t\tNULL,\n+\t\t\t\"MTR object id not valid\");\n+\n+\t/* MTR object owner valid? */\n+\tif (m->flow == NULL)\n+\t\treturn 0;\n+\n+\tpipeline = m->flow->pipeline;\n+\ttable_id = m->flow->table_id;\n+\ttable = &pipeline->table[table_id];\n+\n+\tmemcpy(&dt, &table->dscp_table, sizeof(dt));\n+\tfor (i = 0; i < RTE_DIM(dt.entry); i++)\n+\t\tdt.entry[i].color = (enum rte_meter_color)dscp_table[i];\n+\n+\t/* Update table */\n+\tstatus = softnic_pipeline_table_dscp_table_update(p,\n+\t\t\tpipeline->name,\n+\t\t\ttable_id,\n+\t\t\tUINT64_MAX,\n+\t\t\t&dt);\n+\tif (status)\n+\t\treturn -rte_mtr_error_set(error,\n+\t\t\tEINVAL,\n+\t\t\tRTE_MTR_ERROR_TYPE_UNSPECIFIED,\n+\t\t\tNULL,\n+\t\t\t\"Table action dscp table update failed\");\n+\n+\treturn 0;\n+}\n+\n const struct rte_mtr_ops pmd_mtr_ops = {\n \t.capabilities_get = NULL,\n \n@@ -445,7 +497,7 @@ const struct rte_mtr_ops pmd_mtr_ops = {\n \t.meter_disable = NULL,\n \n \t.meter_profile_update = pmd_mtr_meter_profile_update,\n-\t.meter_dscp_table_update = NULL,\n+\t.meter_dscp_table_update = pmd_mtr_meter_dscp_table_update,\n \t.policer_actions_update = NULL,\n \t.stats_update = NULL,\n \ndiff --git a/drivers/net/softnic/rte_eth_softnic_pipeline.c b/drivers/net/softnic/rte_eth_softnic_pipeline.c\nindex 17830d3..3d37ba3 100644\n--- a/drivers/net/softnic/rte_eth_softnic_pipeline.c\n+++ b/drivers/net/softnic/rte_eth_softnic_pipeline.c\n@@ -1000,6 +1000,7 @@ softnic_pipeline_table_create(struct pmd_internals *softnic,\n \ttable->a = action;\n \tTAILQ_INIT(&table->flows);\n \tTAILQ_INIT(&table->meter_profiles);\n+\tmemset(&table->dscp_table, 0, sizeof(table->dscp_table));\n \tpipeline->n_tables++;\n \n \treturn 0;\ndiff --git a/drivers/net/softnic/rte_eth_softnic_thread.c b/drivers/net/softnic/rte_eth_softnic_thread.c\nindex 83cd07b..e93a355 100644\n--- a/drivers/net/softnic/rte_eth_softnic_thread.c\n+++ b/drivers/net/softnic/rte_eth_softnic_thread.c\n@@ -1902,6 +1902,11 @@ softnic_pipeline_table_dscp_table_update(struct pmd_internals *softnic,\n \t\t\t\tdscp_mask,\n \t\t\t\tdscp_table);\n \n+\t\t/* Update table dscp table */\n+\t\tif (!status)\n+\t\t\tmemcpy(&p->table[table_id].dscp_table, dscp_table,\n+\t\t\t\tsizeof(p->table[table_id].dscp_table));\n+\n \t\treturn status;\n \t}\n \n@@ -1925,6 +1930,11 @@ softnic_pipeline_table_dscp_table_update(struct pmd_internals *softnic,\n \t/* Read response */\n \tstatus = rsp->status;\n \n+\t/* Update table dscp table */\n+\tif (!status)\n+\t\tmemcpy(&p->table[table_id].dscp_table, dscp_table,\n+\t\t\tsizeof(p->table[table_id].dscp_table));\n+\n \t/* Free response */\n \tpipeline_msg_free(rsp);\n \n",
    "prefixes": [
        "v4",
        "07/10"
    ]
}