Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 44870,
    "url": "http://patches.dpdk.org/api/patches/44870/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180918165835.107593-5-jasvinder.singh@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180918165835.107593-5-jasvinder.singh@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180918165835.107593-5-jasvinder.singh@intel.com",
    "date": "2018-09-18T16:58:29",
    "name": "[v4,04/10] net/softnic: create meter object",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "b0e8a5339a21ae54691731fa1cc7023a5d6d9ee9",
    "submitter": {
        "id": 285,
        "url": "http://patches.dpdk.org/api/people/285/?format=api",
        "name": "Jasvinder Singh",
        "email": "jasvinder.singh@intel.com"
    },
    "delegate": {
        "id": 10018,
        "url": "http://patches.dpdk.org/api/users/10018/?format=api",
        "username": "cristian_dumitrescu",
        "first_name": "Cristian",
        "last_name": "Dumitrescu",
        "email": "cristian.dumitrescu@intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180918165835.107593-5-jasvinder.singh@intel.com/mbox/",
    "series": [
        {
            "id": 1374,
            "url": "http://patches.dpdk.org/api/series/1374/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1374",
            "date": "2018-09-18T16:58:25",
            "name": "net/softnic: implement metering and policing API",
            "version": 4,
            "mbox": "http://patches.dpdk.org/series/1374/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/44870/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/44870/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 585115B30;\n\tTue, 18 Sep 2018 18:58:53 +0200 (CEST)",
            "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 016AF56A3\n\tfor <dev@dpdk.org>; Tue, 18 Sep 2018 18:58:47 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Sep 2018 09:58:46 -0700",
            "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.222.149])\n\tby fmsmga002.fm.intel.com with ESMTP; 18 Sep 2018 09:58:39 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.53,390,1531810800\"; d=\"scan'208\";a=\"87193993\"",
        "From": "Jasvinder Singh <jasvinder.singh@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "cristian.dumitrescu@intel.com",
        "Date": "Tue, 18 Sep 2018 17:58:29 +0100",
        "Message-Id": "<20180918165835.107593-5-jasvinder.singh@intel.com>",
        "X-Mailer": "git-send-email 2.9.3",
        "In-Reply-To": "<20180918165835.107593-1-jasvinder.singh@intel.com>",
        "References": "<20180914174554.90135-2-jasvinder.singh@intel.com>\n\t<20180918165835.107593-1-jasvinder.singh@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v4 04/10] net/softnic: create meter object",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "implement meter object create function.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\n---\n drivers/net/softnic/rte_eth_softnic_internals.h |  15 +++\n drivers/net/softnic/rte_eth_softnic_meter.c     | 123 +++++++++++++++++++++++-\n 2 files changed, 137 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/softnic/rte_eth_softnic_internals.h b/drivers/net/softnic/rte_eth_softnic_internals.h\nindex 1db9310..50b7295 100644\n--- a/drivers/net/softnic/rte_eth_softnic_internals.h\n+++ b/drivers/net/softnic/rte_eth_softnic_internals.h\n@@ -82,8 +82,19 @@ struct softnic_mtr_meter_profile {\n \n TAILQ_HEAD(softnic_mtr_meter_profile_list, softnic_mtr_meter_profile);\n \n+/* MTR meter object */\n+struct softnic_mtr {\n+\tTAILQ_ENTRY(softnic_mtr) node;\n+\tuint32_t mtr_id;\n+\tstruct rte_mtr_params params;\n+\tstruct rte_flow *flow;\n+};\n+\n+TAILQ_HEAD(softnic_mtr_list, softnic_mtr);\n+\n struct mtr_internals {\n \tstruct softnic_mtr_meter_profile_list meter_profiles;\n+\tstruct softnic_mtr_list mtrs;\n };\n \n /**\n@@ -601,6 +612,10 @@ softnic_mtr_init(struct pmd_internals *p);\n void\n softnic_mtr_free(struct pmd_internals *p);\n \n+struct softnic_mtr *\n+softnic_mtr_find(struct pmd_internals *p,\n+\tuint32_t mtr_id);\n+\n struct softnic_mtr_meter_profile *\n softnic_mtr_meter_profile_find(struct pmd_internals *p,\n \tuint32_t meter_profile_id);\ndiff --git a/drivers/net/softnic/rte_eth_softnic_meter.c b/drivers/net/softnic/rte_eth_softnic_meter.c\nindex f3205bd..12dd79c 100644\n--- a/drivers/net/softnic/rte_eth_softnic_meter.c\n+++ b/drivers/net/softnic/rte_eth_softnic_meter.c\n@@ -17,12 +17,27 @@ softnic_mtr_init(struct pmd_internals *p)\n \t/* Initialize meter profiles list */\n \tTAILQ_INIT(&p->mtr.meter_profiles);\n \n+\t/* Initialize MTR objects list */\n+\tTAILQ_INIT(&p->mtr.mtrs);\n+\n \treturn 0;\n }\n \n void\n softnic_mtr_free(struct pmd_internals *p)\n {\n+\t/* Remove MTR objects */\n+\tfor ( ; ; ) {\n+\t\tstruct softnic_mtr *m;\n+\n+\t\tm = TAILQ_FIRST(&p->mtr.mtrs);\n+\t\tif (m == NULL)\n+\t\t\tbreak;\n+\n+\t\tTAILQ_REMOVE(&p->mtr.mtrs, m, node);\n+\t\tfree(m);\n+\t}\n+\n \t/* Remove meter profiles */\n \tfor ( ; ; ) {\n \t\tstruct softnic_mtr_meter_profile *mp;\n@@ -164,13 +179,119 @@ pmd_mtr_meter_profile_delete(struct rte_eth_dev *dev,\n \treturn 0;\n }\n \n+struct softnic_mtr *\n+softnic_mtr_find(struct pmd_internals *p, uint32_t mtr_id)\n+{\n+\tstruct softnic_mtr_list *ml = &p->mtr.mtrs;\n+\tstruct softnic_mtr *m;\n+\n+\tTAILQ_FOREACH(m, ml, node)\n+\t\tif (m->mtr_id == mtr_id)\n+\t\t\treturn m;\n+\n+\treturn NULL;\n+}\n+\n+\n+static int\n+mtr_check(struct pmd_internals *p,\n+\tuint32_t mtr_id,\n+\tstruct rte_mtr_params *params,\n+\tint shared,\n+\tstruct rte_mtr_error *error)\n+{\n+\t/* MTR id valid  */\n+\tif (softnic_mtr_find(p, mtr_id))\n+\t\treturn -rte_mtr_error_set(error,\n+\t\t\tEEXIST,\n+\t\t\tRTE_MTR_ERROR_TYPE_MTR_ID,\n+\t\t\tNULL,\n+\t\t\t\"MTR object already exists\");\n+\n+\t/* MTR params must not be NULL */\n+\tif (params == NULL)\n+\t\treturn -rte_mtr_error_set(error,\n+\t\t\tEINVAL,\n+\t\t\tRTE_MTR_ERROR_TYPE_MTR_PARAMS,\n+\t\t\tNULL,\n+\t\t\t\"MTR object params null\");\n+\n+\t/* Previous meter color not supported */\n+\tif (params->use_prev_mtr_color)\n+\t\treturn -rte_mtr_error_set(error,\n+\t\t\tEINVAL,\n+\t\t\tRTE_MTR_ERROR_TYPE_MTR_PARAMS,\n+\t\t\tNULL,\n+\t\t\t\"Previous meter color not supported\");\n+\n+\t/* Shared MTR object not supported */\n+\tif (shared)\n+\t\treturn -rte_mtr_error_set(error,\n+\t\t\tEINVAL,\n+\t\t\tRTE_MTR_ERROR_TYPE_SHARED,\n+\t\t\tNULL,\n+\t\t\t\"Shared MTR object not supported\");\n+\n+\treturn 0;\n+}\n+\n+/* MTR object create */\n+static int\n+pmd_mtr_create(struct rte_eth_dev *dev,\n+\tuint32_t mtr_id,\n+\tstruct rte_mtr_params *params,\n+\tint shared,\n+\tstruct rte_mtr_error *error)\n+{\n+\tstruct pmd_internals *p = dev->data->dev_private;\n+\tstruct softnic_mtr_list *ml = &p->mtr.mtrs;\n+\tstruct softnic_mtr_meter_profile *mp;\n+\tstruct softnic_mtr *m;\n+\tint status;\n+\n+\t/* Check parameters */\n+\tstatus = mtr_check(p, mtr_id, params, shared, error);\n+\tif (status)\n+\t\treturn status;\n+\n+\t/* Meter profile must exist */\n+\tmp = softnic_mtr_meter_profile_find(p, params->meter_profile_id);\n+\tif (mp == NULL)\n+\t\treturn -rte_mtr_error_set(error,\n+\t\t\tEINVAL,\n+\t\t\tRTE_MTR_ERROR_TYPE_METER_PROFILE_ID,\n+\t\t\tNULL,\n+\t\t\t\"Meter profile id not valid\");\n+\n+\t/* Memory allocation */\n+\tm = calloc(1, sizeof(struct softnic_mtr));\n+\tif (m == NULL)\n+\t\treturn -rte_mtr_error_set(error,\n+\t\t\tENOMEM,\n+\t\t\tRTE_MTR_ERROR_TYPE_UNSPECIFIED,\n+\t\t\tNULL,\n+\t\t\t\"Memory alloc failed\");\n+\n+\t/* Fill in */\n+\tm->mtr_id = mtr_id;\n+\tmemcpy(&m->params, params, sizeof(m->params));\n+\n+\t/* Add to list */\n+\tTAILQ_INSERT_TAIL(ml, m, node);\n+\n+\t/* Update dependencies */\n+\tmp->n_users++;\n+\n+\treturn 0;\n+}\n+\n const struct rte_mtr_ops pmd_mtr_ops = {\n \t.capabilities_get = NULL,\n \n \t.meter_profile_add = pmd_mtr_meter_profile_add,\n \t.meter_profile_delete = pmd_mtr_meter_profile_delete,\n \n-\t.create = NULL,\n+\t.create = pmd_mtr_create,\n \t.destroy = NULL,\n \t.meter_enable = NULL,\n \t.meter_disable = NULL,\n",
    "prefixes": [
        "v4",
        "04/10"
    ]
}