Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44842/?format=api
http://patches.dpdk.org/api/patches/44842/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180918131726.60303-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180918131726.60303-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180918131726.60303-2-bruce.richardson@intel.com", "date": "2018-09-18T13:17:26", "name": "[v2,2/2] net/avf: fix missing compiler error flags", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a5b5e5425c0a746f53c8ed14393d51f88195b5d2", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180918131726.60303-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 1370, "url": "http://patches.dpdk.org/api/series/1370/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1370", "date": "2018-09-18T13:17:25", "name": "[v2,1/2] net/avf: fix unused variables and label", "version": 2, "mbox": "http://patches.dpdk.org/series/1370/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/44842/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/44842/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6B7D3378B;\n\tTue, 18 Sep 2018 15:18:18 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id E651D137C;\n\tTue, 18 Sep 2018 15:18:16 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Sep 2018 06:18:16 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.223])\n\tby orsmga004.jf.intel.com with ESMTP; 18 Sep 2018 06:18:13 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,389,1531810800\"; d=\"scan'208\";a=\"233902214\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "Jingjing Wu <jingjing.wu@intel.com>,\n\tWenzhuo Lu <wenzhuo.lu@intel.com>", "Cc": "ferruh.yigit@intel.com, dev@dpdk.org, bluca@debian.org,\n\tZhang@dpdk.org, Qi Z <qi.z.zhang@intel.com>,\n\tBruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org", "Date": "Tue, 18 Sep 2018 14:17:26 +0100", "Message-Id": "<20180918131726.60303-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20180918131726.60303-1-bruce.richardson@intel.com>", "References": "<20180913144405.72772-1-bruce.richardson@intel.com>\n\t<20180918131726.60303-1-bruce.richardson@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 2/2] net/avf: fix missing compiler error flags", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The AVF driver was missing $(WERROR_FLAGS) in it's cflags, which means\nthat a number of compilation errors were getting missed. This patch adds\nin the flag and fixes most of the errors, just disabling the\nstrict-aliasing ones.\n\nFixes: 22b123a36d07 (\"net/avf: initialize PMD\")\nFixes: 69dd4c3d0898 (\"net/avf: enable queue and device\")\nFixes: a2b29a7733ef (\"net/avf: enable basic Rx Tx\")\nFixes: 319c421f3890 (\"net/avf: enable SSE Rx Tx\")\n\nCC: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/net/avf/Makefile | 2 +-\n drivers/net/avf/avf_ethdev.c | 2 +-\n drivers/net/avf/avf_rxtx.h | 2 +-\n drivers/net/avf/avf_rxtx_vec_sse.c | 2 +-\n 4 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/avf/Makefile b/drivers/net/avf/Makefile\nindex 3f815bbc4..0a142c104 100644\n--- a/drivers/net/avf/Makefile\n+++ b/drivers/net/avf/Makefile\n@@ -8,7 +8,7 @@ include $(RTE_SDK)/mk/rte.vars.mk\n #\n LIB = librte_pmd_avf.a\n \n-CFLAGS += -O3\n+CFLAGS += -O3 $(WERROR_FLAGS) -Wno-strict-aliasing\n LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring\n LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_hash\n LDLIBS += -lrte_bus_pci\ndiff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c\nindex 6b6ff7d55..549498477 100644\n--- a/drivers/net/avf/avf_ethdev.c\n+++ b/drivers/net/avf/avf_ethdev.c\n@@ -559,7 +559,7 @@ avf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n }\n \n static const uint32_t *\n-avf_dev_supported_ptypes_get(struct rte_eth_dev *dev)\n+avf_dev_supported_ptypes_get(struct rte_eth_dev *dev __rte_unused)\n {\n \tstatic const uint32_t ptypes[] = {\n \t\tRTE_PTYPE_L2_ETHER,\ndiff --git a/drivers/net/avf/avf_rxtx.h b/drivers/net/avf/avf_rxtx.h\nindex 297d0776d..c4120f8a4 100644\n--- a/drivers/net/avf/avf_rxtx.h\n+++ b/drivers/net/avf/avf_rxtx.h\n@@ -227,7 +227,7 @@ static inline\n void avf_dump_tx_descriptor(const struct avf_tx_queue *txq,\n \t\t\t const void *desc, uint16_t tx_id)\n {\n-\tchar *name;\n+\tconst char *name;\n \tconst struct avf_tx_desc *tx_desc = desc;\n \tenum avf_tx_desc_dtype_value type;\n \ndiff --git a/drivers/net/avf/avf_rxtx_vec_sse.c b/drivers/net/avf/avf_rxtx_vec_sse.c\nindex 8275100f3..343a6aac3 100644\n--- a/drivers/net/avf/avf_rxtx_vec_sse.c\n+++ b/drivers/net/avf/avf_rxtx_vec_sse.c\n@@ -621,7 +621,7 @@ avf_xmit_fixed_burst_vec(void *tx_queue, struct rte_mbuf **tx_pkts,\n \treturn nb_pkts;\n }\n \n-void __attribute__((cold))\n+static void __attribute__((cold))\n avf_rx_queue_release_mbufs_sse(struct avf_rx_queue *rxq)\n {\n \t_avf_rx_queue_release_mbufs_vec(rxq);\n", "prefixes": [ "v2", "2/2" ] }{ "id": 44842, "url": "