Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44820/?format=api
http://patches.dpdk.org/api/patches/44820/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1537249450-104375-1-git-send-email-beilei.xing@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1537249450-104375-1-git-send-email-beilei.xing@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1537249450-104375-1-git-send-email-beilei.xing@intel.com", "date": "2018-09-18T05:44:10", "name": "[v2] net/i40e: remove driver log", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "df8a36d92c473ff5a0f96fc6e083d8c94a7c4a2d", "submitter": { "id": 410, "url": "http://patches.dpdk.org/api/people/410/?format=api", "name": "Xing, Beilei", "email": "beilei.xing@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1537249450-104375-1-git-send-email-beilei.xing@intel.com/mbox/", "series": [ { "id": 1361, "url": "http://patches.dpdk.org/api/series/1361/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1361", "date": "2018-09-18T05:44:10", "name": "[v2] net/i40e: remove driver log", "version": 2, "mbox": "http://patches.dpdk.org/series/1361/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/44820/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/44820/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D7D9C2BF9;\n\tTue, 18 Sep 2018 07:45:18 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 184312BF7\n\tfor <dev@dpdk.org>; Tue, 18 Sep 2018 07:45:16 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Sep 2018 22:45:16 -0700", "from unknown (HELO dpdk9.sh.intel.com) ([10.67.118.52])\n\tby fmsmga007.fm.intel.com with ESMTP; 17 Sep 2018 22:44:54 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,388,1531810800\"; d=\"scan'208\";a=\"70858293\"", "From": "Beilei Xing <beilei.xing@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org", "Date": "Tue, 18 Sep 2018 13:44:10 +0800", "Message-Id": "<1537249450-104375-1-git-send-email-beilei.xing@intel.com>", "X-Mailer": "git-send-email 2.5.5", "In-Reply-To": "<1537248987-78304-1-git-send-email-beilei.xing@intel.com>", "References": "<1537248987-78304-1-git-send-email-beilei.xing@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] net/i40e: remove driver log", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Remove driver log when no interrupt event indicated\nin alarm handler for both PF and VF, otherwise there\nwill be lots of prints which makes console unusable.\n\nSigned-off-by: Beilei Xing <beilei.xing@intel.com>\n---\n\nv2 changes:\n - Also remove the driver log for VF.\n\n drivers/net/i40e/i40e_ethdev.c | 4 +---\n drivers/net/i40e/i40e_ethdev_vf.c | 4 +---\n 2 files changed, 2 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 24d73f2..974e6c6 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -6579,10 +6579,8 @@ i40e_dev_alarm_handler(void *param)\n \ticr0 = I40E_READ_REG(hw, I40E_PFINT_ICR0);\n \n \t/* No interrupt event indicated */\n-\tif (!(icr0 & I40E_PFINT_ICR0_INTEVENT_MASK)) {\n-\t\tPMD_DRV_LOG(INFO, \"No interrupt event\");\n+\tif (!(icr0 & I40E_PFINT_ICR0_INTEVENT_MASK))\n \t\tgoto done;\n-\t}\n \tif (icr0 & I40E_PFINT_ICR0_ECC_ERR_MASK)\n \t\tPMD_DRV_LOG(ERR, \"ICR0: unrecoverable ECC error\");\n \tif (icr0 & I40E_PFINT_ICR0_MAL_DETECT_MASK)\ndiff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c\nindex f9cedf5..42e5f4d 100644\n--- a/drivers/net/i40e/i40e_ethdev_vf.c\n+++ b/drivers/net/i40e/i40e_ethdev_vf.c\n@@ -1384,10 +1384,8 @@ i40evf_dev_alarm_handler(void *param)\n \ticr0 = I40E_READ_REG(hw, I40E_VFINT_ICR01);\n \n \t/* No interrupt event indicated */\n-\tif (!(icr0 & I40E_VFINT_ICR01_INTEVENT_MASK)) {\n-\t\tPMD_DRV_LOG(DEBUG, \"No interrupt event, nothing to do\");\n+\tif (!(icr0 & I40E_VFINT_ICR01_INTEVENT_MASK))\n \t\tgoto done;\n-\t}\n \n \tif (icr0 & I40E_VFINT_ICR01_ADMINQ_MASK) {\n \t\tPMD_DRV_LOG(DEBUG, \"ICR01_ADMINQ is reported\");\n", "prefixes": [ "v2" ] }{ "id": 44820, "url": "