Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44789/?format=api
{ "id": 44789, "url": "http://patches.dpdk.org/api/patches/44789/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180917092814.59921-3-xiaoyun.li@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180917092814.59921-3-xiaoyun.li@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180917092814.59921-3-xiaoyun.li@intel.com", "date": "2018-09-17T09:28:09", "name": "[v2,2/7] net/ixgbe/base: cleanup codes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "107730559c31f675788d4e7d593f52b9b0217a93", "submitter": { "id": 798, "url": "http://patches.dpdk.org/api/people/798/?format=api", "name": "Li, Xiaoyun", "email": "xiaoyun.li@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180917092814.59921-3-xiaoyun.li@intel.com/mbox/", "series": [ { "id": 1350, "url": "http://patches.dpdk.org/api/series/1350/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1350", "date": "2018-09-17T09:28:07", "name": "update ixgbe base code", "version": 2, "mbox": "http://patches.dpdk.org/series/1350/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/44789/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/44789/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 16E29559A;\n\tMon, 17 Sep 2018 11:36:55 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 782B834F3\n\tfor <dev@dpdk.org>; Mon, 17 Sep 2018 11:36:51 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Sep 2018 02:36:51 -0700", "from dpdk-xiaoyun3.sh.intel.com ([10.67.119.41])\n\tby fmsmga004.fm.intel.com with ESMTP; 17 Sep 2018 02:36:49 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,384,1531810800\"; d=\"scan'208\";a=\"89406530\"", "From": "Xiaoyun Li <xiaoyun.li@intel.com>", "To": "qi.z.zhang@intel.com,\n\twenzhuo.lu@intel.com,\n\tferruh.yigit@intel.com", "Cc": "dev@dpdk.org,\n\tXiaoyun Li <xiaoyun.li@intel.com>", "Date": "Mon, 17 Sep 2018 17:28:09 +0800", "Message-Id": "<20180917092814.59921-3-xiaoyun.li@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20180917092814.59921-1-xiaoyun.li@intel.com>", "References": "<20180910163753.85966-1-xiaoyun.li@intel.com>\n\t<20180917092814.59921-1-xiaoyun.li@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 2/7] net/ixgbe/base: cleanup codes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Cleanup UNREFERENCED_1PARAMETER() macro because \"hw\" is used.\nAnd remove Light Spring codes because the device was never\nproductised. And cleanup unused bypass codes.\n\nSigned-off-by: Xiaoyun Li <xiaoyun.li@intel.com>\n---\nv2:\n * Merge base code change and ethdev fix into 1 patch to avoid in\n * between build issue.\n---\n drivers/net/ixgbe/base/ixgbe_82599.c | 10 ----------\n drivers/net/ixgbe/base/ixgbe_api.c | 3 ---\n drivers/net/ixgbe/base/ixgbe_common.c | 6 ------\n drivers/net/ixgbe/base/ixgbe_phy.c | 1 -\n drivers/net/ixgbe/base/ixgbe_type.h | 9 ++-------\n drivers/net/ixgbe/ixgbe_ethdev.c | 1 -\n 6 files changed, 2 insertions(+), 28 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_82599.c b/drivers/net/ixgbe/base/ixgbe_82599.c\nindex 33d8c4a31..7de753fd3 100644\n--- a/drivers/net/ixgbe/base/ixgbe_82599.c\n+++ b/drivers/net/ixgbe/base/ixgbe_82599.c\n@@ -58,9 +58,6 @@ void ixgbe_init_mac_link_ops_82599(struct ixgbe_hw *hw)\n \t\tmac->ops.setup_mac_link = ixgbe_setup_mac_link_82599;\n \t\tmac->ops.set_rate_select_speed =\n \t\t\t\t\t ixgbe_set_hard_rate_select_speed;\n-\t\tif (ixgbe_get_media_type(hw) == ixgbe_media_type_fiber_fixed)\n-\t\t\tmac->ops.set_rate_select_speed =\n-\t\t\t\t\t ixgbe_set_soft_rate_select_speed;\n \t} else {\n \t\tif ((ixgbe_get_media_type(hw) == ixgbe_media_type_backplane) &&\n \t\t (hw->phy.smart_speed == ixgbe_smart_speed_auto ||\n@@ -532,16 +529,9 @@ enum ixgbe_media_type ixgbe_get_media_type_82599(struct ixgbe_hw *hw)\n \tcase IXGBE_DEV_ID_82599_T3_LOM:\n \t\tmedia_type = ixgbe_media_type_copper;\n \t\tbreak;\n-\tcase IXGBE_DEV_ID_82599_LS:\n-\t\tmedia_type = ixgbe_media_type_fiber_lco;\n-\t\tbreak;\n \tcase IXGBE_DEV_ID_82599_QSFP_SF_QP:\n \t\tmedia_type = ixgbe_media_type_fiber_qsfp;\n \t\tbreak;\n-\tcase IXGBE_DEV_ID_82599_BYPASS:\n-\t\tmedia_type = ixgbe_media_type_fiber_fixed;\n-\t\thw->phy.multispeed_fiber = true;\n-\t\tbreak;\n \tdefault:\n \t\tmedia_type = ixgbe_media_type_unknown;\n \t\tbreak;\ndiff --git a/drivers/net/ixgbe/base/ixgbe_api.c b/drivers/net/ixgbe/base/ixgbe_api.c\nindex a2eab1361..3450d401f 100644\n--- a/drivers/net/ixgbe/base/ixgbe_api.c\n+++ b/drivers/net/ixgbe/base/ixgbe_api.c\n@@ -148,8 +148,6 @@ s32 ixgbe_set_mac_type(struct ixgbe_hw *hw)\n \tcase IXGBE_DEV_ID_82599_QSFP_SF_QP:\n \tcase IXGBE_DEV_ID_82599EN_SFP:\n \tcase IXGBE_DEV_ID_82599_CX4:\n-\tcase IXGBE_DEV_ID_82599_LS:\n-\tcase IXGBE_DEV_ID_82599_BYPASS:\n \tcase IXGBE_DEV_ID_82599_T3_LOM:\n \t\thw->mac.type = ixgbe_mac_82599EB;\n \t\tbreak;\n@@ -164,7 +162,6 @@ s32 ixgbe_set_mac_type(struct ixgbe_hw *hw)\n \t\tbreak;\n \tcase IXGBE_DEV_ID_X540T:\n \tcase IXGBE_DEV_ID_X540T1:\n-\tcase IXGBE_DEV_ID_X540_BYPASS:\n \t\thw->mac.type = ixgbe_mac_X540;\n \t\thw->mvals = ixgbe_mvals_X540;\n \t\tbreak;\ndiff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c\nindex d7b63c656..b4a0d7003 100644\n--- a/drivers/net/ixgbe/base/ixgbe_common.c\n+++ b/drivers/net/ixgbe/base/ixgbe_common.c\n@@ -138,7 +138,6 @@ bool ixgbe_device_supports_autoneg_fc(struct ixgbe_hw *hw)\n \tDEBUGFUNC(\"ixgbe_device_supports_autoneg_fc\");\n \n \tswitch (hw->phy.media_type) {\n-\tcase ixgbe_media_type_fiber_fixed:\n \tcase ixgbe_media_type_fiber_qsfp:\n \tcase ixgbe_media_type_fiber:\n \t\t/* flow control autoneg black list */\n@@ -172,7 +171,6 @@ bool ixgbe_device_supports_autoneg_fc(struct ixgbe_hw *hw)\n \t\tcase IXGBE_DEV_ID_82599_T3_LOM:\n \t\tcase IXGBE_DEV_ID_X540T:\n \t\tcase IXGBE_DEV_ID_X540T1:\n-\t\tcase IXGBE_DEV_ID_X540_BYPASS:\n \t\tcase IXGBE_DEV_ID_X550T:\n \t\tcase IXGBE_DEV_ID_X550T1:\n \t\tcase IXGBE_DEV_ID_X550EM_X_10G_T:\n@@ -238,7 +236,6 @@ s32 ixgbe_setup_fc_generic(struct ixgbe_hw *hw)\n \t\t\tgoto out;\n \n \t\t/* fall through - only backplane uses autoc */\n-\tcase ixgbe_media_type_fiber_fixed:\n \tcase ixgbe_media_type_fiber_qsfp:\n \tcase ixgbe_media_type_fiber:\n \t\treg = IXGBE_READ_REG(hw, IXGBE_PCS1GANA);\n@@ -3098,7 +3095,6 @@ void ixgbe_fc_autoneg(struct ixgbe_hw *hw)\n \n \tswitch (hw->phy.media_type) {\n \t/* Autoneg flow control on fiber adapters */\n-\tcase ixgbe_media_type_fiber_fixed:\n \tcase ixgbe_media_type_fiber_qsfp:\n \tcase ixgbe_media_type_fiber:\n \t\tif (speed == IXGBE_LINK_SPEED_1GB_FULL)\n@@ -5238,7 +5234,6 @@ s32 ixgbe_setup_mac_link_multispeed_fiber(struct ixgbe_hw *hw,\n \n \t\t/* Set the module link speed */\n \t\tswitch (hw->phy.media_type) {\n-\t\tcase ixgbe_media_type_fiber_fixed:\n \t\tcase ixgbe_media_type_fiber:\n \t\t\tixgbe_set_rate_select_speed(hw,\n \t\t\t\t\t\t IXGBE_LINK_SPEED_10GB_FULL);\n@@ -5289,7 +5284,6 @@ s32 ixgbe_setup_mac_link_multispeed_fiber(struct ixgbe_hw *hw,\n \n \t\t/* Set the module link speed */\n \t\tswitch (hw->phy.media_type) {\n-\t\tcase ixgbe_media_type_fiber_fixed:\n \t\tcase ixgbe_media_type_fiber:\n \t\t\tixgbe_set_rate_select_speed(hw,\n \t\t\t\t\t\t IXGBE_LINK_SPEED_1GB_FULL);\ndiff --git a/drivers/net/ixgbe/base/ixgbe_phy.c b/drivers/net/ixgbe/base/ixgbe_phy.c\nindex 47451c982..6cdd8fbab 100644\n--- a/drivers/net/ixgbe/base/ixgbe_phy.c\n+++ b/drivers/net/ixgbe/base/ixgbe_phy.c\n@@ -2565,7 +2565,6 @@ STATIC bool ixgbe_get_i2c_data(struct ixgbe_hw *hw, u32 *i2cctl)\n {\n \tu32 data_oe_bit = IXGBE_I2C_DATA_OE_N_EN_BY_MAC(hw);\n \tbool data;\n-\tUNREFERENCED_1PARAMETER(hw);\n \n \tDEBUGFUNC(\"ixgbe_get_i2c_data\");\n \ndiff --git a/drivers/net/ixgbe/base/ixgbe_type.h b/drivers/net/ixgbe/base/ixgbe_type.h\nindex cc26496e3..ff3546ece 100644\n--- a/drivers/net/ixgbe/base/ixgbe_type.h\n+++ b/drivers/net/ixgbe/base/ixgbe_type.h\n@@ -17,8 +17,8 @@\n *\n * - IXGBE_ERROR_POLLING\n * This category is for errors related to polling/timeout issues and should be\n- * used in any case where the timeout occured, or a failure to obtain a lock, or\n- * failure to receive data within the time limit.\n+ * used in any case where the timeout occurred, or a failure to obtain a lock,\n+ * or failure to receive data within the time limit.\n *\n * - IXGBE_ERROR_CAUTION\n * This category should be used for reporting issues that may be the cause of\n@@ -93,12 +93,9 @@\n #define IXGBE_DEV_ID_82599_T3_LOM\t\t0x151C\n #define IXGBE_DEV_ID_82599_VF\t\t\t0x10ED\n #define IXGBE_DEV_ID_82599_VF_HV\t\t0x152E\n-#define IXGBE_DEV_ID_82599_LS\t\t\t0x154F\n-#define IXGBE_DEV_ID_82599_BYPASS\t\t0x155D\n #define IXGBE_DEV_ID_X540T\t\t\t0x1528\n #define IXGBE_DEV_ID_X540_VF\t\t\t0x1515\n #define IXGBE_DEV_ID_X540_VF_HV\t\t\t0x1530\n-#define IXGBE_DEV_ID_X540_BYPASS\t\t0x155C\n #define IXGBE_DEV_ID_X540T1\t\t\t0x1560\n #define IXGBE_DEV_ID_X550T\t\t\t0x1563\n #define IXGBE_DEV_ID_X550T1\t\t\t0x15D1\n@@ -3726,9 +3723,7 @@ enum ixgbe_sfp_type {\n enum ixgbe_media_type {\n \tixgbe_media_type_unknown = 0,\n \tixgbe_media_type_fiber,\n-\tixgbe_media_type_fiber_fixed,\n \tixgbe_media_type_fiber_qsfp,\n-\tixgbe_media_type_fiber_lco,\n \tixgbe_media_type_copper,\n \tixgbe_media_type_backplane,\n \tixgbe_media_type_cx4,\ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex cee886754..4c3f9a993 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -437,7 +437,6 @@ static const struct rte_pci_id pci_id_ixgbe_map[] = {\n \t{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599EN_SFP) },\n \t{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_XAUI_LOM) },\n \t{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_T3_LOM) },\n-\t{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_82599_LS) },\n \t{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_X540T) },\n \t{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_X540T1) },\n \t{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_X550EM_X_SFP) },\n", "prefixes": [ "v2", "2/7" ] }