Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44751/?format=api
http://patches.dpdk.org/api/patches/44751/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/153698883388.23049.2819933386635765768.stgit@T460/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<153698883388.23049.2819933386635765768.stgit@T460>", "list_archive_url": "https://inbox.dpdk.org/dev/153698883388.23049.2819933386635765768.stgit@T460", "date": "2018-09-15T05:20:33", "name": "[v3,2/5] vhost: make message handling functions prepare the reply", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f29e6e5ce10342942b0cf49db92d10119d1dc92b", "submitter": { "id": 1062, "url": "http://patches.dpdk.org/api/people/1062/?format=api", "name": "Nikolay Nikolaev", "email": "nicknickolaev@gmail.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/153698883388.23049.2819933386635765768.stgit@T460/mbox/", "series": [ { "id": 1332, "url": "http://patches.dpdk.org/api/series/1332/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1332", "date": "2018-09-15T05:20:19", "name": "vhost: vhost_user.c code cleanup", "version": 3, "mbox": "http://patches.dpdk.org/series/1332/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/44751/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/44751/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7DE0C4D27;\n\tSat, 15 Sep 2018 07:20:37 +0200 (CEST)", "from mail-wm1-f65.google.com (mail-wm1-f65.google.com\n\t[209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 721A44C92\n\tfor <dev@dpdk.org>; Sat, 15 Sep 2018 07:20:36 +0200 (CEST)", "by mail-wm1-f65.google.com with SMTP id o18-v6so3960256wmc.0\n\tfor <dev@dpdk.org>; Fri, 14 Sep 2018 22:20:36 -0700 (PDT)", "from [127.0.1.1] ([82.146.27.14]) by smtp.gmail.com with ESMTPSA id\n\tt4-v6sm9992573wrb.45.2018.09.14.22.20.34\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 14 Sep 2018 22:20:35 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:cc:date:message-id:in-reply-to:references\n\t:user-agent:mime-version:content-transfer-encoding;\n\tbh=YC7apfpVWRkYONJLYzDkVxmsBll9SrTnBZv3hr3PiPo=;\n\tb=gv9AHwN9n6VDox4ESFY59zoHyJ3VJiDHzQ+Uf1UkhGb8xJOD5xRt+YN86NUPgCa5Oc\n\tjndjiPFyY+V8yTEHq6Rz8MHZEofOAGSlpxc7BDXc9ltmj0efbdlMx69Ly4TApCWYstOT\n\t56FFRG9lkBXBZiQnWz5sumbgTRv2qH4CMNgp13euvhkL0RL9FsAgQd/mHLsjXpYVhhYo\n\tC0gENrDrAEKmoqdOTD6CQYecaCF/jLPz70Fd3NR6XBSi82yehBR4lREAxOtRnhf2gbzp\n\t8cnpN3GuPr/8BEWCfDQZjfXWfitn220Ph682R2AjDm3YRGz3zoWaSOW6lQEI9twMOuM+\n\tpZdQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=YC7apfpVWRkYONJLYzDkVxmsBll9SrTnBZv3hr3PiPo=;\n\tb=WRmRW9RYLoYR4KN9KMyy+mGScdWPS3P9pgcyU8F8sakdMhv/bsKeHmduBwqJtRKSE+\n\tiP7C0gWpNhfmwsNuibKJa1L2tooWi6EMXMVgBq/n4bXEcTfZW4k5/1bafJsow0AYWsai\n\t6jVZJXRn6fpk2C5R3pKklaD8GmpRFqulmN1+Nx3MzISKoZcfPgEbRDTBo1ogsuTqR8zD\n\tr1d1VNlnm/YPUNKxJIp/O4kz8t6SnN4j1Ykq3T7EfFbns2fC/OAi1iV0gzkEqzGS2ovn\n\tB0dZyNi9ZzvgYbXM41mmTZXIxt7zkbPxW6t0v8olPqtr1khLoILn3vY8V3zDc0Yitmxx\n\tJxPw==", "X-Gm-Message-State": "APzg51D/nyIGF7XqzxbMQOXJkHmFybiMj8jPytKwvA8HU2DjeDP6ImU9\n\th/8Wzuc6bW1oqOPlR0scISZmbma+nu9bAw==", "X-Google-Smtp-Source": "ANB0VdYetgnkMjqp83i2QuBYUN3d8zpPMCXGz4Kd+KuqQfDn8nuZrwicA/+rdYkXLqKEFzrr26Wqwg==", "X-Received": "by 2002:a1c:8587:: with SMTP id\n\th129-v6mr4688882wmd.105.1536988835983; \n\tFri, 14 Sep 2018 22:20:35 -0700 (PDT)", "From": "Nikolay Nikolaev <nicknickolaev@gmail.com>", "To": "maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com", "Cc": "dev@dpdk.org", "Date": "Sat, 15 Sep 2018 08:20:33 +0300", "Message-ID": "<153698883388.23049.2819933386635765768.stgit@T460>", "In-Reply-To": "<153698873346.23049.10966616323159180622.stgit@T460>", "References": "<153698873346.23049.10966616323159180622.stgit@T460>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Subject": "[dpdk-dev] [PATCH v3 2/5] vhost: make message handling functions\n\tprepare the reply", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As VhostUserMsg structure is reused to generate the reply, move the\nrelevant fields update into the respective message handling functions.\n\nSigned-off-by: Nikolay Nikolaev <nicknickolaev@gmail.com>\n---\n lib/librte_vhost/vhost_user.c | 24 ++++++++++++++++--------\n 1 file changed, 16 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex b05b57670..3a00d53cf 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -146,11 +146,15 @@ vhost_user_reset_owner(struct virtio_net *dev)\n * The features that we support are requested.\n */\n static uint64_t\n-vhost_user_get_features(struct virtio_net *dev)\n+vhost_user_get_features(struct virtio_net *dev, VhostUserMsg *msg)\n {\n \tuint64_t features = 0;\n \n \trte_vhost_driver_get_features(dev->ifname, &features);\n+\n+\tmsg->payload.u64 = features;\n+\tmsg->size = sizeof(msg->payload.u64);\n+\n \treturn features;\n }\n \n@@ -158,11 +162,15 @@ vhost_user_get_features(struct virtio_net *dev)\n * The queue number that we support are requested.\n */\n static uint32_t\n-vhost_user_get_queue_num(struct virtio_net *dev)\n+vhost_user_get_queue_num(struct virtio_net *dev, VhostUserMsg *msg)\n {\n \tuint32_t queue_num = 0;\n \n \trte_vhost_driver_get_queue_num(dev->ifname, &queue_num);\n+\n+\tmsg->payload.u64 = (uint64_t)queue_num;\n+\tmsg->size = sizeof(msg->payload.u64);\n+\n \treturn queue_num;\n }\n \n@@ -1117,6 +1125,8 @@ vhost_user_get_vring_base(struct virtio_net *dev,\n \trte_free(vq->batch_copy_elems);\n \tvq->batch_copy_elems = NULL;\n \n+\tmsg->size = sizeof(msg->payload.state);\n+\n \treturn 0;\n }\n \n@@ -1244,6 +1254,8 @@ vhost_user_set_log_base(struct virtio_net *dev, VhostUserMsg *msg)\n \tdev->log_base = dev->log_addr + off;\n \tdev->log_size = size;\n \n+\tmsg->size = sizeof(msg->payload.u64);\n+\n \treturn 0;\n }\n \n@@ -1657,8 +1669,7 @@ vhost_user_msg_handler(int vid, int fd)\n \n \tswitch (msg.request.master) {\n \tcase VHOST_USER_GET_FEATURES:\n-\t\tmsg.payload.u64 = vhost_user_get_features(dev);\n-\t\tmsg.size = sizeof(msg.payload.u64);\n+\t\tvhost_user_get_features(dev, &msg);\n \t\tsend_vhost_reply(fd, &msg);\n \t\tbreak;\n \tcase VHOST_USER_SET_FEATURES:\n@@ -1689,7 +1700,6 @@ vhost_user_msg_handler(int vid, int fd)\n \t\tif (ret)\n \t\t\tgoto skip_to_reply;\n \t\t/* it needs a reply */\n-\t\tmsg.size = sizeof(msg.payload.u64);\n \t\tsend_vhost_reply(fd, &msg);\n \t\tbreak;\n \tcase VHOST_USER_SET_LOG_FD:\n@@ -1711,7 +1721,6 @@ vhost_user_msg_handler(int vid, int fd)\n \t\tret = vhost_user_get_vring_base(dev, &msg);\n \t\tif (ret)\n \t\t\tgoto skip_to_reply;\n-\t\tmsg.size = sizeof(msg.payload.state);\n \t\tsend_vhost_reply(fd, &msg);\n \t\tbreak;\n \n@@ -1729,8 +1738,7 @@ vhost_user_msg_handler(int vid, int fd)\n \t\tbreak;\n \n \tcase VHOST_USER_GET_QUEUE_NUM:\n-\t\tmsg.payload.u64 = (uint64_t)vhost_user_get_queue_num(dev);\n-\t\tmsg.size = sizeof(msg.payload.u64);\n+\t\tvhost_user_get_queue_num(dev, &msg);\n \t\tsend_vhost_reply(fd, &msg);\n \t\tbreak;\n \n", "prefixes": [ "v3", "2/5" ] }{ "id": 44751, "url": "