Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 44601,
    "url": "http://patches.dpdk.org/api/patches/44601/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180911231417.17222-1-dg@adax.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180911231417.17222-1-dg@adax.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180911231417.17222-1-dg@adax.com",
    "date": "2018-09-11T23:14:17",
    "name": "[1/2] kni: add API to set link status on kernel interface",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "751977fb3d090094a7f21706e7d5058402fa0795",
    "submitter": {
        "id": 1040,
        "url": "http://patches.dpdk.org/api/people/1040/?format=api",
        "name": "Dan Gora",
        "email": "dg@adax.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180911231417.17222-1-dg@adax.com/mbox/",
    "series": [
        {
            "id": 1287,
            "url": "http://patches.dpdk.org/api/series/1287/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1287",
            "date": "2018-09-11T23:14:03",
            "name": "kni: add API to set link status on kernel interface",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/1287/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/44601/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/44601/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 998334CA1;\n\tWed, 12 Sep 2018 01:14:34 +0200 (CEST)",
            "from mail-qt0-f194.google.com (mail-qt0-f194.google.com\n\t[209.85.216.194]) by dpdk.org (Postfix) with ESMTP id 90A9E4C95\n\tfor <dev@dpdk.org>; Wed, 12 Sep 2018 01:14:33 +0200 (CEST)",
            "by mail-qt0-f194.google.com with SMTP id g44-v6so30115062qtb.12\n\tfor <dev@dpdk.org>; Tue, 11 Sep 2018 16:14:33 -0700 (PDT)",
            "from snappy.local.lan (189-46-164-241.dsl.telesp.net.br.\n\t[189.46.164.241]) by smtp.gmail.com with ESMTPSA id\n\tl87-v6sm12999066qki.82.2018.09.11.16.14.28\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tTue, 11 Sep 2018 16:14:31 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=brKgXRmAdYdNeL3uqBo0I3ImwvPWLgFWozo5r8fr8WE=;\n\tb=QbVzj3tE2DwRLfrpgVw7cgM0BzKD2Sqto3np8ee1VMPrryMjTgdvtTdpsmueRjqopn\n\t5kwLKZD8FSBYkZ9Vl2U9D4v7vYZt3stdoK6UzdJwORv4RfCpSt9l3TWRd+pHhucu3TwF\n\t2MFsHMS623uf4P5BWmmamDXS82eKD4w2iXIGBB73xkSGdcpu1v0egzIH4TtGXfZ7JAhn\n\t0ICDPHErfoImjkkDneiqef3holDDlNJZgU/UKLQE0fqul6Cc4XW7uM7HnN+uj2MEWiKd\n\tuW8nqTQ3TX7iEF+kD5ql7yeBFoQJTBwu6k+cJC4JWXyTTnjxGeZBHoVkNxFEm4ym7kp7\n\tFNvA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=brKgXRmAdYdNeL3uqBo0I3ImwvPWLgFWozo5r8fr8WE=;\n\tb=fCNpFZs8g0+ZeHvHkOdp8uK74QDoBIIj24n5OWa5VvkPsO0TfPIl9yL3gtNdBFcYXP\n\tkAM7NV7hMSklkcXpnGrndxUu8siRNSP6QBm6YNf4YC59TcXJSyEm0W2dZrO+Jjk/zAJz\n\tQEMFG9VWpNQZuq/AG6ObF3DatF/qzhMSOlXIxI4WSsu/lYqdD1hwJS7/0hSYjA6xh6Wi\n\tSwy0YN5b2a0ZIMlbFXtNOn4beI2bjisQIieP7QrrWxMVuO+AZFlSu7jMP9XN9Gri4CAv\n\t9TC/+0zd/kDMri2ePbIdaeV9Ap1gs3Fo8jz4VVg4idUsZvCC5LJPsn5/u50aLghWzGr7\n\trKJg==",
        "X-Gm-Message-State": "APzg51AJzzcOD0gPAr7Hm9+YSMerzoY4tf9Bvpo+DDJgxy70TxBCrwz7\n\tl42z8VfBsHRY41xmIFoLKhwMQjRN",
        "X-Google-Smtp-Source": "ANB0VdZ3sHTqQZvLM088tCK2rxBjOaD4EnGGehNcLOdDDOYGmgHUm64FCIG4vcw4UHGIot2Sfp2dHA==",
        "X-Received": "by 2002:ac8:2fa4:: with SMTP id\n\tl33-v6mr21567216qta.83.1536707672646; \n\tTue, 11 Sep 2018 16:14:32 -0700 (PDT)",
        "From": "Dan Gora <dg@adax.com>",
        "To": "dev@dpdk.org",
        "Cc": "Igor Ryzhov <iryzhov@nfware.com>,\n\tStephen Hemminger <stephen@networkplumber.org>,\n\tFerruh Yigit <ferruh.yigit@intel.com>, Dan Gora <dg@adax.com>",
        "Date": "Tue, 11 Sep 2018 20:14:17 -0300",
        "Message-Id": "<20180911231417.17222-1-dg@adax.com>",
        "X-Mailer": "git-send-email 2.19.0",
        "In-Reply-To": "<20180629015508.26599-11-dg@adax.com>",
        "References": "<20180629015508.26599-11-dg@adax.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 1/2] kni: add API to set link status on kernel\n\tinterface",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Add a new API function to KNI, rte_kni_update_link() to allow DPDK\napplications to update the link status for KNI network interfaces in\nthe linux kernel.\n\nSigned-off-by: Dan Gora <dg@adax.com>\n---\n lib/librte_kni/rte_kni.c | 57 ++++++++++++++++++++++++++++++++++++++++\n lib/librte_kni/rte_kni.h | 18 +++++++++++++\n 2 files changed, 75 insertions(+)",
    "diff": "diff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c\nindex 65f6a2b03..afe1d7410 100644\n--- a/lib/librte_kni/rte_kni.c\n+++ b/lib/librte_kni/rte_kni.c\n@@ -790,6 +790,63 @@ rte_kni_unregister_handlers(struct rte_kni *kni)\n \n \treturn 0;\n }\n+\n+int\n+rte_kni_update_link(struct rte_kni *kni, struct rte_eth_link *link)\n+{\n+\tchar path[64];\n+\tchar carrier[2];\n+\tconst char *new_carrier;\n+\tint fd, ret;\n+\n+\tif (kni == NULL || link == NULL)\n+\t\treturn -1;\n+\n+\tsnprintf(path, sizeof(path), \"/sys/devices/virtual/net/%s/carrier\",\n+\t\tkni->name);\n+\n+\tfd = open(path, O_RDWR);\n+\tif (fd == -1) {\n+\t\tRTE_LOG(ERR, KNI, \"Failed to open file: %s.\\n\", path);\n+\t\treturn -1;\n+\t}\n+\n+\tret = read(fd, carrier, 2);\n+\tif (ret < 1) {\n+\t\t/* Cannot read carrier until interface is marked\n+\t\t * 'up', so don't log an error.\n+\t\t */\n+\t\tclose(fd);\n+\t\treturn -1;\n+\t}\n+\n+\tnew_carrier = (link->link_status == ETH_LINK_UP) ? \"1\" : \"0\";\n+\tret = write(fd, new_carrier, 1);\n+\tif (ret < 1) {\n+\t\tRTE_LOG(ERR, KNI, \"Failed to write file: %s.\\n\", path);\n+\t\tclose(fd);\n+\t\treturn -1;\n+\t}\n+\n+\tif (strncmp(carrier, new_carrier, 1)) {\n+\t\tif (link->link_status == ETH_LINK_UP) {\n+\t\t\tRTE_LOG(INFO, KNI, \"%s NIC Link is Up %d Mbps %s %s.\\n\",\n+\t\t\t\tkni->name,\n+\t\t\t\tlink->link_speed,\n+\t\t\t\tlink->link_autoneg ? \"(Fixed)\" : \"(AutoNeg)\",\n+\t\t\t\tlink->link_duplex ?\n+\t\t\t\t\t\"Full Duplex\" : \"Half Duplex\");\n+\t\t} else {\n+\t\t\tRTE_LOG(INFO, KNI, \"%s NIC Link is Down.\\n\",\n+\t\t\t\tkni->name);\n+\t\t}\n+\t}\n+\n+\tclose(fd);\n+\n+\treturn 0;\n+}\n+\n void\n rte_kni_close(void)\n {\ndiff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h\nindex 99055e2c2..4118ae97a 100644\n--- a/lib/librte_kni/rte_kni.h\n+++ b/lib/librte_kni/rte_kni.h\n@@ -21,6 +21,7 @@\n #include <rte_memory.h>\n #include <rte_mempool.h>\n #include <rte_ether.h>\n+#include <rte_ethdev.h>\n \n #include <exec-env/rte_kni_common.h>\n \n@@ -228,6 +229,23 @@ int rte_kni_register_handlers(struct rte_kni *kni, struct rte_kni_ops *ops);\n  */\n int rte_kni_unregister_handlers(struct rte_kni *kni);\n \n+/**\n+ * Update link status info for KNI port.\n+ *\n+ * Update the linkup/linkdown status of a KNI interface in the kernel.\n+ *\n+ * @param kni\n+ *  pointer to struct rte_kni.\n+ * @param link\n+ *  pointer to struct rte_eth_link containing new interface status.\n+ *\n+ * @return\n+ *  On success: 0\n+ *  On failure: -1\n+ */\n+int __rte_experimental\n+rte_kni_update_link(struct rte_kni *kni, struct rte_eth_link *link);\n+\n /**\n  *  Close KNI device.\n  */\n",
    "prefixes": [
        "1/2"
    ]
}