Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44500/?format=api
{ "id": 44500, "url": "http://patches.dpdk.org/api/patches/44500/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1536572016-18134-36-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1536572016-18134-36-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1536572016-18134-36-git-send-email-arybchenko@solarflare.com", "date": "2018-09-10T09:33:34", "name": "[35/37] net/sfc/base: modify phy caps to indicate FEC request", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1b400ba72b5fdee582427049bdffa315551ca955", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1536572016-18134-36-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 1244, "url": "http://patches.dpdk.org/api/series/1244/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1244", "date": "2018-09-10T09:33:01", "name": "net/sfc: update base driver", "version": 1, "mbox": "http://patches.dpdk.org/series/1244/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/44500/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/44500/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E7EEC1B001;\n\tMon, 10 Sep 2018 11:34:44 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 253E24CA7\n\tfor <dev@dpdk.org>; Mon, 10 Sep 2018 11:33:55 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\t0F7D5780055 for <dev@dpdk.org>; Mon, 10 Sep 2018 09:33:54 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Mon, 10 Sep 2018 02:33:49 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Mon, 10 Sep 2018 02:33:48 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw8A9Xlas023891; Mon, 10 Sep 2018 10:33:47 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t45F8A1626D2; Mon, 10 Sep 2018 10:33:47 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Richard Houldsworth <rhouldsworth@solarflare.com>", "Date": "Mon, 10 Sep 2018 10:33:34 +0100", "Message-ID": "<1536572016-18134-36-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1536572016-18134-1-git-send-email-arybchenko@solarflare.com>", "References": "<1536572016-18134-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24084.005", "X-TM-AS-Result": "No-5.059700-4.000000-10", "X-TMASE-MatchedRID": "I0XPGJpOaREmcsJib2Ijae7KTDtx8CggZORgGu5KV7cs/uUAk6xP7F/2\n\tzKXxjR59nmkKx4n0E8gQEZaWew/4U200sCPwNg7wQ1OcCEvT+bdwG8b5skjkoPHFoBcOsKezpux\n\tEEXVQG1yw3CreLeI86IAy6p60ZV62fJ5/bZ6npdg7AFczfjr/7DiXiVQPFXqXeH0DzzuhHbY95n\n\tdQwWf+5iUX958IC9wHEJceb6pkk4Q=", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--5.059700-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24084.005", "X-MDID": "1536572034-S_n7_WdDVGuS", "Subject": "[dpdk-dev] [PATCH 35/37] net/sfc/base: modify phy caps to indicate\n\tFEC request", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Richard Houldsworth <rhouldsworth@solarflare.com>\n\nThe capability bits to request FEC modes are implicitly valid\nwhen the corresponding FEC mode is a supported capability.\nDrivers expect that it is only valid to advertise those\ncapabilities explicitly marked as supported. The capabilities\nreported by firmware is modified with the implicit capabilities\nto present the explicit model to drivers.\n\nSigned-off-by: Richard Houldsworth <rhouldsworth@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/base/ef10_nic.c | 15 +++++++++++++++\n drivers/net/sfc/base/efx_phy.c | 8 +-------\n 2 files changed, 16 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/sfc/base/ef10_nic.c b/drivers/net/sfc/base/ef10_nic.c\nindex 0a2474f3e..b54cd3940 100644\n--- a/drivers/net/sfc/base/ef10_nic.c\n+++ b/drivers/net/sfc/base/ef10_nic.c\n@@ -1772,6 +1772,21 @@ ef10_nic_board_cfg(\n \tif ((rc = efx_mcdi_get_phy_cfg(enp)) != 0)\n \t\tgoto fail6;\n \n+\t/*\n+\t * Firmware with support for *_FEC capability bits does not\n+\t * report that the corresponding *_FEC_REQUESTED bits are supported.\n+\t * Add them here so that drivers understand that they are supported.\n+\t */\n+\tif (epp->ep_phy_cap_mask & (1u << EFX_PHY_CAP_BASER_FEC))\n+\t\tepp->ep_phy_cap_mask |=\n+\t\t (1u << EFX_PHY_CAP_BASER_FEC_REQUESTED);\n+\tif (epp->ep_phy_cap_mask & (1u << EFX_PHY_CAP_RS_FEC))\n+\t\tepp->ep_phy_cap_mask |=\n+\t\t (1u << EFX_PHY_CAP_RS_FEC_REQUESTED);\n+\tif (epp->ep_phy_cap_mask & (1u << EFX_PHY_CAP_25G_BASER_FEC))\n+\t\tepp->ep_phy_cap_mask |=\n+\t\t (1u << EFX_PHY_CAP_25G_BASER_FEC_REQUESTED);\n+\n \t/* Obtain the default PHY advertised capabilities */\n \tif ((rc = ef10_phy_get_link(enp, &els)) != 0)\n \t\tgoto fail7;\ndiff --git a/drivers/net/sfc/base/efx_phy.c b/drivers/net/sfc/base/efx_phy.c\nindex 7c341e429..25059dfe1 100644\n--- a/drivers/net/sfc/base/efx_phy.c\n+++ b/drivers/net/sfc/base/efx_phy.c\n@@ -192,11 +192,6 @@ efx_phy_adv_cap_get(\n \t}\n }\n \n-#define\tEFX_PHY_CAP_FEC_REQ_MASK\t\t\t\\\n-\t(1U << EFX_PHY_CAP_BASER_FEC_REQUESTED)\t|\t\\\n-\t(1U << EFX_PHY_CAP_RS_FEC_REQUESTED)\t|\t\\\n-\t(1U << EFX_PHY_CAP_25G_BASER_FEC_REQUESTED)\n-\n \t__checkReturn\tefx_rc_t\n efx_phy_adv_cap_set(\n \t__in\t\tefx_nic_t *enp,\n@@ -210,8 +205,7 @@ efx_phy_adv_cap_set(\n \tEFSYS_ASSERT3U(enp->en_magic, ==, EFX_NIC_MAGIC);\n \tEFSYS_ASSERT3U(enp->en_mod_flags, &, EFX_MOD_PORT);\n \n-\t/* Ignore don't care bits of FEC (FEC EFX_PHY_CAP_*_REQUESTED) */\n-\tif ((mask & ~(epp->ep_phy_cap_mask | EFX_PHY_CAP_FEC_REQ_MASK)) != 0) {\n+\tif ((mask & ~epp->ep_phy_cap_mask) != 0) {\n \t\trc = ENOTSUP;\n \t\tgoto fail1;\n \t}\n", "prefixes": [ "35/37" ] }