Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44499/?format=api
{ "id": 44499, "url": "http://patches.dpdk.org/api/patches/44499/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1536572016-18134-34-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1536572016-18134-34-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1536572016-18134-34-git-send-email-arybchenko@solarflare.com", "date": "2018-09-10T09:33:32", "name": "[33/37] net/sfc/base: simplify the code to parse RSS hash type", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d56edfba38e5ddc6e6703ca4d7135eb85e872f88", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1536572016-18134-34-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 1244, "url": "http://patches.dpdk.org/api/series/1244/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1244", "date": "2018-09-10T09:33:01", "name": "net/sfc: update base driver", "version": 1, "mbox": "http://patches.dpdk.org/series/1244/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/44499/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/44499/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DBC6D1AEF4;\n\tMon, 10 Sep 2018 11:34:43 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 77EAD4CB3\n\tfor <dev@dpdk.org>; Mon, 10 Sep 2018 11:33:55 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id 90A4B780055; Mon, 10 Sep 2018 09:33:54 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Mon, 10 Sep 2018 02:33:49 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Mon, 10 Sep 2018 02:33:48 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw8A9XlbI023885; Mon, 10 Sep 2018 10:33:47 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t223DD1626D2; Mon, 10 Sep 2018 10:33:47 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Ivan Malov <Ivan.Malov@oktetlabs.ru>", "Date": "Mon, 10 Sep 2018 10:33:32 +0100", "Message-ID": "<1536572016-18134-34-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1536572016-18134-1-git-send-email-arybchenko@solarflare.com>", "References": "<1536572016-18134-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24084.005", "X-TM-AS-Result": "No-2.215000-4.000000-10", "X-TMASE-MatchedRID": "6iG0MA7tSw++we96uFZwvbThj82FPFSCGEfoClqBl87RLEyE6G4DRHB4\n\t4IkzjfYyR3nAM7y+sxFXWU94JlDpUxbOyg/35lfjnJ5tL+LbGOP0IUHuSVWDh/2lzSP0KbzPo8W\n\tMkQWv6iXBcIE78YqRWo6HM5rqDwqtyT34n2qugfeDS+m3Dx1vqTIUavXIByE/7fonoMi2ssYDi6\n\tMN9+6fUfYpQtNay/3F589qRnKM4ypYVkM/06LU1CudJgfqaSwKhdeYev6ImzWyrFieOBrhBjzcW\n\trt/fwYrRcB2ZpPnVjJuI9MGG9suFpRMZUCEHkRt", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--2.215000-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24084.005", "X-MDID": "1536572035-vWYtfWyK9OLa", "Subject": "[dpdk-dev] [PATCH 33/37] net/sfc/base: simplify the code to parse\n\tRSS hash type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Malov <Ivan.Malov@oktetlabs.ru>\n\nRSS mode bits can be accessed a lot easier in the hash\ntype value provided that the variable type is uint32_t.\nThe macro helper can be removed to enhance readability.\n\nSigned-off-by: Ivan Malov <Ivan.Malov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/base/ef10_rx.c | 24 ++++++++++--------------\n drivers/net/sfc/base/efx.h | 2 +-\n 2 files changed, 11 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/sfc/base/ef10_rx.c b/drivers/net/sfc/base/ef10_rx.c\nindex 17678b517..1444eca81 100644\n--- a/drivers/net/sfc/base/ef10_rx.c\n+++ b/drivers/net/sfc/base/ef10_rx.c\n@@ -377,12 +377,6 @@ efx_mcdi_rss_context_set_flags(\n \tif (encp->enc_rx_scale_additional_modes_supported == B_FALSE)\n \t\tmodes = 0;\n \n-#define\tEXTRACT_RSS_MODE(_type, _class)\t\t\\\n-\t(EFX_EXTRACT_NATIVE(_type, 0, 31,\t\\\n-\tEFX_LOW_BIT(EFX_RX_CLASS_##_class),\t\\\n-\tEFX_HIGH_BIT(EFX_RX_CLASS_##_class)) &\t\\\n-\tEFX_MASK32(EFX_RX_CLASS_##_class))\n-\n \tMCDI_IN_POPULATE_DWORD_10(req, RSS_CONTEXT_SET_FLAGS_IN_FLAGS,\n \t RSS_CONTEXT_SET_FLAGS_IN_TOEPLITZ_IPV4_EN,\n \t ((type & type_ipv4) == type_ipv4) ? 1 : 0,\n@@ -393,19 +387,21 @@ efx_mcdi_rss_context_set_flags(\n \t RSS_CONTEXT_SET_FLAGS_IN_TOEPLITZ_TCPV6_EN,\n \t ((type & type_ipv6_tcp) == type_ipv6_tcp) ? 1 : 0,\n \t RSS_CONTEXT_SET_FLAGS_IN_TCP_IPV4_RSS_MODE,\n-\t EXTRACT_RSS_MODE(modes, IPV4_TCP),\n+\t (modes >> EFX_RX_CLASS_IPV4_TCP_LBN) &\n+\t EFX_MASK32(EFX_RX_CLASS_IPV4_TCP),\n \t RSS_CONTEXT_SET_FLAGS_IN_UDP_IPV4_RSS_MODE,\n-\t EXTRACT_RSS_MODE(modes, IPV4_UDP),\n+\t (modes >> EFX_RX_CLASS_IPV4_UDP_LBN) &\n+\t EFX_MASK32(EFX_RX_CLASS_IPV4_UDP),\n \t RSS_CONTEXT_SET_FLAGS_IN_OTHER_IPV4_RSS_MODE,\n-\t EXTRACT_RSS_MODE(modes, IPV4),\n+\t (modes >> EFX_RX_CLASS_IPV4_LBN) & EFX_MASK32(EFX_RX_CLASS_IPV4),\n \t RSS_CONTEXT_SET_FLAGS_IN_TCP_IPV6_RSS_MODE,\n-\t EXTRACT_RSS_MODE(modes, IPV6_TCP),\n+\t (modes >> EFX_RX_CLASS_IPV6_TCP_LBN) &\n+\t EFX_MASK32(EFX_RX_CLASS_IPV6_TCP),\n \t RSS_CONTEXT_SET_FLAGS_IN_UDP_IPV6_RSS_MODE,\n-\t EXTRACT_RSS_MODE(modes, IPV6_UDP),\n+\t (modes >> EFX_RX_CLASS_IPV6_UDP_LBN) &\n+\t EFX_MASK32(EFX_RX_CLASS_IPV6_UDP),\n \t RSS_CONTEXT_SET_FLAGS_IN_OTHER_IPV6_RSS_MODE,\n-\t EXTRACT_RSS_MODE(modes, IPV6));\n-\n-#undef EXTRACT_RSS_MODE\n+\t (modes >> EFX_RX_CLASS_IPV6_LBN) & EFX_MASK32(EFX_RX_CLASS_IPV6));\n \n \tefx_mcdi_execute(enp, &req);\n \ndiff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h\nindex de62b7d50..62c56e6e1 100644\n--- a/drivers/net/sfc/base/efx.h\n+++ b/drivers/net/sfc/base/efx.h\n@@ -2267,7 +2267,7 @@ typedef enum efx_rx_hash_alg_e {\n * - a combination of legacy flags\n * - a combination of EFX_RX_HASH() flags\n */\n-typedef unsigned int efx_rx_hash_type_t;\n+typedef uint32_t efx_rx_hash_type_t;\n \n typedef enum efx_rx_hash_support_e {\n \tEFX_RX_HASH_UNAVAILABLE = 0,\t/* Hardware hash not inserted */\n", "prefixes": [ "33/37" ] }