Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44498/?format=api
{ "id": 44498, "url": "http://patches.dpdk.org/api/patches/44498/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1536572016-18134-32-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1536572016-18134-32-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1536572016-18134-32-git-send-email-arybchenko@solarflare.com", "date": "2018-09-10T09:33:30", "name": "[31/37] net/sfc/base: use simpler code to check hash algorithm type", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "89c8ad30d86c80c118952dd0d910b1fcc4f6af79", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1536572016-18134-32-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 1244, "url": "http://patches.dpdk.org/api/series/1244/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1244", "date": "2018-09-10T09:33:01", "name": "net/sfc: update base driver", "version": 1, "mbox": "http://patches.dpdk.org/series/1244/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/44498/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/44498/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0AF5D1AF03;\n\tMon, 10 Sep 2018 11:34:42 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id D57084CA0\n\tfor <dev@dpdk.org>; Mon, 10 Sep 2018 11:33:54 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id D962A780069; Mon, 10 Sep 2018 09:33:53 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Mon, 10 Sep 2018 02:33:48 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Mon, 10 Sep 2018 02:33:48 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw8A9XlOj023874; Mon, 10 Sep 2018 10:33:47 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t002E11626D2; Mon, 10 Sep 2018 10:33:46 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Ivan Malov <Ivan.Malov@oktetlabs.ru>", "Date": "Mon, 10 Sep 2018 10:33:30 +0100", "Message-ID": "<1536572016-18134-32-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1536572016-18134-1-git-send-email-arybchenko@solarflare.com>", "References": "<1536572016-18134-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24084.005", "X-TM-AS-Result": "No-1.160900-4.000000-10", "X-TMASE-MatchedRID": "qzE1kYnau5zRYRMEFHXEy0hwlOfYeSqxtjHGWON8yePB8Ugf1J6jaFYW\n\twxB9tw0TdYb+uDQF1i6hIfz5Pq8buGTCzF7UO28xHcQQBuf4ZFtV12TtAZAdp6/10BLkgzmJpiJ\n\tY/dpHPXyQ5zXuXE7cooAy6p60ZV62fJ5/bZ6npdirvtPKKgnMGNaeZbAxATevkR/OHyahsbGM+N\n\tRSJDfsQAP5H1dom/K7MqsRLpZZZHd2M/cyUIR8YD2Y1g3jaa8GTOp1wbXQ5HmO/nbihP/WFfDsn\n\tHBTQS9kyoRE4tv/7I7j/Qm+fSvAAma0vgPD7M1vY0tlcDylfpVWXGvUUmKP2w==", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10-1.160900-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24084.005", "X-MDID": "1536572034-Ef696y8kxSjz", "Subject": "[dpdk-dev] [PATCH 31/37] net/sfc/base: use simpler code to check\n\thash algorithm type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Malov <Ivan.Malov@oktetlabs.ru>\n\nThe API which is used to list supported hash flags verifies\nhash algorithm choice before writing the output. This check\nis based on a switch() statement which has only two options\nand no distinctive actions to be conducted for each of them.\nUse simpler code instead of switch() to improve readability.\n\nSigned-off-by: Ivan Malov <Ivan.Malov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/base/efx_rx.c | 39 ++++++++++++-----------------------\n 1 file changed, 13 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/net/sfc/base/efx_rx.c b/drivers/net/sfc/base/efx_rx.c\nindex 7b9f28664..dfd3974da 100644\n--- a/drivers/net/sfc/base/efx_rx.c\n+++ b/drivers/net/sfc/base/efx_rx.c\n@@ -312,6 +312,11 @@ efx_rx_scale_hash_flags_get(\n \t\tgoto fail1;\n \t}\n \n+\tif ((encp->enc_rx_scale_hash_alg_mask & (1U << hash_alg)) == 0) {\n+\t\t*nflagsp = 0;\n+\t\treturn 0;\n+\t}\n+\n \tl4 = encp->enc_rx_scale_l4_hash_supported;\n \tadditional_modes = encp->enc_rx_scale_additional_modes_supported;\n \n@@ -340,32 +345,17 @@ efx_rx_scale_hash_flags_get(\n \t\t_NOTE(CONSTANTCONDITION)\t\t\t\t\\\n \t} while (B_FALSE)\n \n-\tswitch (hash_alg) {\n-\tcase EFX_RX_HASHALG_PACKED_STREAM:\n-\t\tif ((encp->enc_rx_scale_hash_alg_mask & (1U << hash_alg)) == 0)\n-\t\t\tbreak;\n-\t\t/* FALLTHRU */\n-\tcase EFX_RX_HASHALG_TOEPLITZ:\n-\t\tif ((encp->enc_rx_scale_hash_alg_mask & (1U << hash_alg)) == 0)\n-\t\t\tbreak;\n+\tLIST_FLAGS(entryp, IPV4_TCP, l4, additional_modes);\n+\tLIST_FLAGS(entryp, IPV6_TCP, l4, additional_modes);\n \n-\t\tLIST_FLAGS(entryp, IPV4_TCP, l4, additional_modes);\n-\t\tLIST_FLAGS(entryp, IPV6_TCP, l4, additional_modes);\n-\n-\t\tif (additional_modes) {\n-\t\t\tLIST_FLAGS(entryp, IPV4_UDP, l4, additional_modes);\n-\t\t\tLIST_FLAGS(entryp, IPV6_UDP, l4, additional_modes);\n-\t\t}\n-\n-\t\tLIST_FLAGS(entryp, IPV4, B_FALSE, additional_modes);\n-\t\tLIST_FLAGS(entryp, IPV6, B_FALSE, additional_modes);\n-\t\tbreak;\n-\n-\tdefault:\n-\t\trc = EINVAL;\n-\t\tgoto fail2;\n+\tif (additional_modes) {\n+\t\tLIST_FLAGS(entryp, IPV4_UDP, l4, additional_modes);\n+\t\tLIST_FLAGS(entryp, IPV6_UDP, l4, additional_modes);\n \t}\n \n+\tLIST_FLAGS(entryp, IPV4, B_FALSE, additional_modes);\n+\tLIST_FLAGS(entryp, IPV6, B_FALSE, additional_modes);\n+\n #undef LIST_FLAGS\n \n \t*nflagsp = (unsigned int)(entryp - flagsp);\n@@ -373,9 +363,6 @@ efx_rx_scale_hash_flags_get(\n \n \treturn (0);\n \n-fail2:\n-\tEFSYS_PROBE(fail2);\n-\n fail1:\n \tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n \n", "prefixes": [ "31/37" ] }