Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44486/?format=api
{ "id": 44486, "url": "http://patches.dpdk.org/api/patches/44486/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1536572016-18134-20-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1536572016-18134-20-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1536572016-18134-20-git-send-email-arybchenko@solarflare.com", "date": "2018-09-10T09:33:18", "name": "[19/37] net/sfc/base: add accessor for default port mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d4f68f415abc5abe339b32f47a444c8fdb69fd59", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1536572016-18134-20-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 1244, "url": "http://patches.dpdk.org/api/series/1244/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1244", "date": "2018-09-10T09:33:01", "name": "net/sfc: update base driver", "version": 1, "mbox": "http://patches.dpdk.org/series/1244/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/44486/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/44486/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 86A035F65;\n\tMon, 10 Sep 2018 11:34:26 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id B3C924C94\n\tfor <dev@dpdk.org>; Mon, 10 Sep 2018 11:33:52 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\t12080780055 for <dev@dpdk.org>; Mon, 10 Sep 2018 09:33:52 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Mon, 10 Sep 2018 02:33:48 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Mon, 10 Sep 2018 02:33:47 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw8A9XkFM023821; Mon, 10 Sep 2018 10:33:46 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t1FD791626D2; Mon, 10 Sep 2018 10:33:46 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Richard Houldsworth <rhouldsworth@solarflare.com>", "Date": "Mon, 10 Sep 2018 10:33:18 +0100", "Message-ID": "<1536572016-18134-20-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1536572016-18134-1-git-send-email-arybchenko@solarflare.com>", "References": "<1536572016-18134-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24084.005", "X-TM-AS-Result": "No-2.215200-4.000000-10", "X-TMASE-MatchedRID": "XeU4418MOoGeLRbVigb0ae7KTDtx8CggB4Id7CiQcz+ZPzMOYxmoMVgn\n\ttRee4uHHA8+wLcXiwMrijpjet3oGSP9ibONAM1uxogGd8wIUGILljSRvSGpq3LHjjZhCJenCsqh\n\tobi8Z8tutyqZ+sAAvPaR+JS/M0xk86QBmN5sUVdXhG1IOMb7PsHJrB0Cu3DDnmyiLZetSf8mfop\n\t0ytGwvXiq2rl3dzGQ16kDg2UIcpVhomt0JW05dPraPeXhVGhF5g5SbqAIKyAf/VT89aXIBHtlzo\n\t8Yn5MYCAKTIBFS9s0Ot8Falv5d5wW4kQJ31kWk4EEbp7W79dNo4oGQUCbwY5Q+g7mdwjo656FtD\n\tZCmYBJ3KTLw/lNgw8g==", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--2.215200-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24084.005", "X-MDID": "1536572032-Tq-t9qj9DO4b", "Subject": "[dpdk-dev] [PATCH 19/37] net/sfc/base: add accessor for default\n\tport mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Richard Houldsworth <rhouldsworth@solarflare.com>\n\nExtend efx_mcdi_get_port_modes() to optionally pass on the default\nport mode field. This provides a more direct way of handling the case\nwhere the dynamic config does not specify the port mode than the\nalternative of a lookup table indexed by MCFW subtype.\n\nSigned-off-by: Richard Houldsworth <rhouldsworth@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/base/ef10_impl.h | 3 ++-\n drivers/net/sfc/base/ef10_nic.c | 13 ++++++++++---\n drivers/net/sfc/base/hunt_nic.c | 3 ++-\n drivers/net/sfc/base/medford2_nic.c | 2 +-\n drivers/net/sfc/base/medford_nic.c | 2 +-\n 5 files changed, 16 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/sfc/base/ef10_impl.h b/drivers/net/sfc/base/ef10_impl.h\nindex fb0d98875..2abd699a0 100644\n--- a/drivers/net/sfc/base/ef10_impl.h\n+++ b/drivers/net/sfc/base/ef10_impl.h\n@@ -1128,7 +1128,8 @@ extern\t__checkReturn\tefx_rc_t\n efx_mcdi_get_port_modes(\n \t__in\t\tefx_nic_t *enp,\n \t__out\t\tuint32_t *modesp,\n-\t__out_opt\tuint32_t *current_modep);\n+\t__out_opt\tuint32_t *current_modep,\n+\t__out_opt\tuint32_t *default_modep);\n \n extern\t__checkReturn\tefx_rc_t\n ef10_nic_get_port_mode_bandwidth(\ndiff --git a/drivers/net/sfc/base/ef10_nic.c b/drivers/net/sfc/base/ef10_nic.c\nindex d1985b3c5..9145c389c 100644\n--- a/drivers/net/sfc/base/ef10_nic.c\n+++ b/drivers/net/sfc/base/ef10_nic.c\n@@ -63,7 +63,8 @@ efx_mcdi_get_port_assignment(\n efx_mcdi_get_port_modes(\n \t__in\t\tefx_nic_t *enp,\n \t__out\t\tuint32_t *modesp,\n-\t__out_opt\tuint32_t *current_modep)\n+\t__out_opt\tuint32_t *current_modep,\n+\t__out_opt\tuint32_t *default_modep)\n {\n \tefx_mcdi_req_t req;\n \tuint8_t payload[MAX(MC_CMD_GET_PORT_MODES_IN_LEN,\n@@ -110,6 +111,11 @@ efx_mcdi_get_port_modes(\n \t\t\t\t\t GET_PORT_MODES_OUT_CURRENT_MODE);\n \t}\n \n+\tif (default_modep != NULL) {\n+\t\t*default_modep = MCDI_OUT_DWORD(req,\n+\t\t\t\t\t GET_PORT_MODES_OUT_DEFAULT_MODE);\n+\t}\n+\n \treturn (0);\n \n fail3:\n@@ -1635,13 +1641,14 @@ ef10_external_port_mapping(\n \tint32_t count = 1; /* Default 1-1 mapping */\n \tint32_t offset = 1; /* Default starting external port number */\n \n-\tif ((rc = efx_mcdi_get_port_modes(enp, &port_modes, ¤t)) != 0) {\n+\tif ((rc = efx_mcdi_get_port_modes(enp, &port_modes, ¤t,\n+\t\t NULL)) != 0) {\n \t\t/*\n \t\t * No current port mode information (i.e. Huntington)\n \t\t * - infer mapping from available modes\n \t\t */\n \t\tif ((rc = efx_mcdi_get_port_modes(enp,\n-\t\t\t &port_modes, NULL)) != 0) {\n+\t\t\t &port_modes, NULL, NULL)) != 0) {\n \t\t\t/*\n \t\t\t * No port mode information available\n \t\t\t * - use default mapping\ndiff --git a/drivers/net/sfc/base/hunt_nic.c b/drivers/net/sfc/base/hunt_nic.c\nindex 16ea81d23..1bec3c485 100644\n--- a/drivers/net/sfc/base/hunt_nic.c\n+++ b/drivers/net/sfc/base/hunt_nic.c\n@@ -30,7 +30,8 @@ hunt_nic_get_required_pcie_bandwidth(\n \t * capable mode is in use.\n \t */\n \n-\tif ((rc = efx_mcdi_get_port_modes(enp, &port_modes, NULL)) != 0) {\n+\tif ((rc = efx_mcdi_get_port_modes(enp, &port_modes,\n+\t\t NULL, NULL)) != 0) {\n \t\t/* No port mode info available */\n \t\tbandwidth = 0;\n \t\tgoto out;\ndiff --git a/drivers/net/sfc/base/medford2_nic.c b/drivers/net/sfc/base/medford2_nic.c\nindex 7f5ad1757..b36e54bab 100644\n--- a/drivers/net/sfc/base/medford2_nic.c\n+++ b/drivers/net/sfc/base/medford2_nic.c\n@@ -23,7 +23,7 @@ medford2_nic_get_required_pcie_bandwidth(\n \t/* FIXME: support new Medford2 dynamic port modes */\n \n \tif ((rc = efx_mcdi_get_port_modes(enp, &port_modes,\n-\t\t\t\t ¤t_mode)) != 0) {\n+\t\t\t\t ¤t_mode, NULL)) != 0) {\n \t\t/* No port mode info available. */\n \t\tbandwidth = 0;\n \t\tgoto out;\ndiff --git a/drivers/net/sfc/base/medford_nic.c b/drivers/net/sfc/base/medford_nic.c\nindex 6dc895f5b..96f3a1204 100644\n--- a/drivers/net/sfc/base/medford_nic.c\n+++ b/drivers/net/sfc/base/medford_nic.c\n@@ -21,7 +21,7 @@ medford_nic_get_required_pcie_bandwidth(\n \tefx_rc_t rc;\n \n \tif ((rc = efx_mcdi_get_port_modes(enp, &port_modes,\n-\t\t\t\t ¤t_mode)) != 0) {\n+\t\t\t\t ¤t_mode, NULL)) != 0) {\n \t\t/* No port mode info available. */\n \t\tbandwidth = 0;\n \t\tgoto out;\n", "prefixes": [ "19/37" ] }