Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44480/?format=api
{ "id": 44480, "url": "http://patches.dpdk.org/api/patches/44480/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1536572016-18134-15-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1536572016-18134-15-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1536572016-18134-15-git-send-email-arybchenko@solarflare.com", "date": "2018-09-10T09:33:13", "name": "[14/37] net/sfc/base: remove probes when a Tx queue is too full", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "edd4aad156eb597e14b6095987ca9f525bd2b2b7", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1536572016-18134-15-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 1244, "url": "http://patches.dpdk.org/api/series/1244/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1244", "date": "2018-09-10T09:33:01", "name": "net/sfc: update base driver", "version": 1, "mbox": "http://patches.dpdk.org/series/1244/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/44480/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/44480/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 853C85F14;\n\tMon, 10 Sep 2018 11:34:18 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id F2CA14C9D\n\tfor <dev@dpdk.org>; Mon, 10 Sep 2018 11:33:51 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\tEED6C780055 for <dev@dpdk.org>; Mon, 10 Sep 2018 09:33:50 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Mon, 10 Sep 2018 02:33:47 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Mon, 10 Sep 2018 02:33:47 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw8A9XjHh023800; Mon, 10 Sep 2018 10:33:45 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\tB980B1626D1; Mon, 10 Sep 2018 10:33:45 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Mark Spender <mspender@solarflare.com>", "Date": "Mon, 10 Sep 2018 10:33:13 +0100", "Message-ID": "<1536572016-18134-15-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1536572016-18134-1-git-send-email-arybchenko@solarflare.com>", "References": "<1536572016-18134-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24084.005", "X-TM-AS-Result": "No-5.704100-4.000000-10", "X-TMASE-MatchedRID": "zoFxOq+IDXPXldNKzKPlvUhwlOfYeSqxQKuv8uQBDjrDTXM3VzSaIpxz\n\t8+1dXyV4sgeCKo7aYMg4qIXltbvww9bms8wOrodvA9lly13c/gF+tO36GYDlslVHNq9zbw7oWyQ\n\tE1XGLouDLlfTm7xmbgoAy6p60ZV62fJ5/bZ6npdiyO81X3yak82Oa1QLkFhy9uuozkKFDufDTxN\n\tuZmpreMsI+Kstpsq59xHi+VM/h4GJ+3BndfXUhXQ==", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--5.704100-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24084.005", "X-MDID": "1536572031-fJ39Mpyk4S7q", "Subject": "[dpdk-dev] [PATCH 14/37] net/sfc/base: remove probes when a Tx\n\tqueue is too full", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Mark Spender <mspender@solarflare.com>\n\nNo need for probe messages when a TxQ is too full for a post to be done.\n\nExisting drivers check if there is room in the queue before posting\ndescriptors, even though efx_tx_qdesc_post() does the check itself.\n\nThe new SFN Windows driver doesn't perform the check before calling\nefx_tx_qdesc_post(), but that means these probes can get frequently\nprinted out. It's normal driver behaviour so there's no need to print\nan error.\n\nSigned-off-by: Mark Spender <mspender@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/base/ef10_tx.c | 12 ++----------\n drivers/net/sfc/base/efx_tx.c | 19 ++-----------------\n 2 files changed, 4 insertions(+), 27 deletions(-)", "diff": "diff --git a/drivers/net/sfc/base/ef10_tx.c b/drivers/net/sfc/base/ef10_tx.c\nindex e74d39540..4d77d76d7 100644\n--- a/drivers/net/sfc/base/ef10_tx.c\n+++ b/drivers/net/sfc/base/ef10_tx.c\n@@ -541,12 +541,9 @@ ef10_tx_qdesc_post(\n {\n \tunsigned int added = *addedp;\n \tunsigned int i;\n-\tefx_rc_t rc;\n \n-\tif (added - completed + ndescs > EFX_TXQ_LIMIT(etp->et_mask + 1)) {\n-\t\trc = ENOSPC;\n-\t\tgoto fail1;\n-\t}\n+\tif (added - completed + ndescs > EFX_TXQ_LIMIT(etp->et_mask + 1))\n+\t\treturn (ENOSPC);\n \n \tfor (i = 0; i < ndescs; i++) {\n \t\tefx_desc_t *edp = &ed[i];\n@@ -566,11 +563,6 @@ ef10_tx_qdesc_post(\n \n \t*addedp = added;\n \treturn (0);\n-\n-fail1:\n-\tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n-\n-\treturn (rc);\n }\n \n \tvoid\ndiff --git a/drivers/net/sfc/base/efx_tx.c b/drivers/net/sfc/base/efx_tx.c\nindex da37580a6..bf1180a1e 100644\n--- a/drivers/net/sfc/base/efx_tx.c\n+++ b/drivers/net/sfc/base/efx_tx.c\n@@ -572,19 +572,10 @@ efx_tx_qdesc_post(\n {\n \tefx_nic_t *enp = etp->et_enp;\n \tconst efx_tx_ops_t *etxop = enp->en_etxop;\n-\tefx_rc_t rc;\n \n \tEFSYS_ASSERT3U(etp->et_magic, ==, EFX_TXQ_MAGIC);\n \n-\tif ((rc = etxop->etxo_qdesc_post(etp, ed,\n-\t ndescs, completed, addedp)) != 0)\n-\t\tgoto fail1;\n-\n-\treturn (0);\n-\n-fail1:\n-\tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n-\treturn (rc);\n+\treturn (etxop->etxo_qdesc_post(etp, ed, ndescs, completed, addedp));\n }\n \n \tvoid\n@@ -763,10 +754,9 @@ siena_tx_qpost(\n {\n \tunsigned int added = *addedp;\n \tunsigned int i;\n-\tint rc = ENOSPC;\n \n \tif (added - completed + ndescs > EFX_TXQ_LIMIT(etp->et_mask + 1))\n-\t\tgoto fail1;\n+\t\treturn (ENOSPC);\n \n \tfor (i = 0; i < ndescs; i++) {\n \t\tefx_buffer_t *ebp = &eb[i];\n@@ -788,11 +778,6 @@ siena_tx_qpost(\n \n \t*addedp = added;\n \treturn (0);\n-\n-fail1:\n-\tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n-\n-\treturn (rc);\n }\n \n static\t\tvoid\n", "prefixes": [ "14/37" ] }