Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44477/?format=api
{ "id": 44477, "url": "http://patches.dpdk.org/api/patches/44477/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1536572016-18134-12-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1536572016-18134-12-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1536572016-18134-12-git-send-email-arybchenko@solarflare.com", "date": "2018-09-10T09:33:10", "name": "[11/37] net/sfc/base: move empty efsys definitions to EFX headers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "395752d99eceefc4599f035072e6cfd0336a2f97", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1536572016-18134-12-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 1244, "url": "http://patches.dpdk.org/api/series/1244/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1244", "date": "2018-09-10T09:33:01", "name": "net/sfc: update base driver", "version": 1, "mbox": "http://patches.dpdk.org/series/1244/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/44477/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/44477/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 08FBB5B2C;\n\tMon, 10 Sep 2018 11:34:14 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 50ED84C90\n\tfor <dev@dpdk.org>; Mon, 10 Sep 2018 11:33:51 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\t70739780055 for <dev@dpdk.org>; Mon, 10 Sep 2018 09:33:50 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Mon, 10 Sep 2018 02:33:47 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Mon, 10 Sep 2018 02:33:47 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw8A9Xj9C023790; Mon, 10 Sep 2018 10:33:45 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t6F05F1626D2; Mon, 10 Sep 2018 10:33:45 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Martin Harvey <mharvey@solarflare.com>, Andrew Lee <alee@solarflare.com>", "Date": "Mon, 10 Sep 2018 10:33:10 +0100", "Message-ID": "<1536572016-18134-12-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1536572016-18134-1-git-send-email-arybchenko@solarflare.com>", "References": "<1536572016-18134-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24084.005", "X-TM-AS-Result": "No-4.904600-4.000000-10", "X-TMASE-MatchedRID": "pw66t0jdljUkFVbXj/dAre7KTDtx8CggVBDQSDMig9Hfc2Xd6VJ+ygaT\n\talM8C773OxoI4BJbLh7KpWtpDsSS4FdI3z1FMme3wM5GqAoqJiqzy3IeH3LNTndWmDvFPih8FSd\n\tbd7Inc5nYHOC/v3JS19Dq8P9PcwDe9NDkghlX3z740JAO63QrhQkN8Uvsy+ntv8D7QPW2jo8HYI\n\taKxjkuVkHNY7W6Yix9gDLqnrRlXrZ8nn9tnqel2K6NVEWSRWyb9n3GJSasXOZESC1D+mZ6DoV0e\n\tuhab4u3BOprvqx/XZ9WHRI7DsMhAF6b7oAnBUAT4TaJa/uOlxlOVQeu/eQ+YOAZa4GNsAsF8Oyc\n\tcFNBL2TKhETi2//sjuP9Cb59K8ACZrS+A8PszW+YV38c4KFOjw==", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--4.904600-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24084.005", "X-MDID": "1536572031-6QiqPhfj5nGU", "Subject": "[dpdk-dev] [PATCH 11/37] net/sfc/base: move empty efsys definitions\n\tto EFX headers", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Martin Harvey <mharvey@solarflare.com>\n\nMove empty definitions for platform-specific annotations from efsys.h\nto EFX headers.\n\nSigned-off-by: Martin Harvey <mharvey@solarflare.com>\nSigned-off-by: Andrew Lee <alee@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/base/efx.h | 1 +\n drivers/net/sfc/base/efx_annote.h | 101 ++++++++++++++++++++++++++++++\n drivers/net/sfc/efsys.h | 38 -----------\n 3 files changed, 102 insertions(+), 38 deletions(-)\n create mode 100644 drivers/net/sfc/base/efx_annote.h", "diff": "diff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h\nindex baeffd934..4c8983387 100644\n--- a/drivers/net/sfc/base/efx.h\n+++ b/drivers/net/sfc/base/efx.h\n@@ -7,6 +7,7 @@\n #ifndef\t_SYS_EFX_H\n #define\t_SYS_EFX_H\n \n+#include \"efx_annote.h\"\n #include \"efsys.h\"\n #include \"efx_check.h\"\n #include \"efx_phy_ids.h\"\ndiff --git a/drivers/net/sfc/base/efx_annote.h b/drivers/net/sfc/base/efx_annote.h\nnew file mode 100644\nindex 000000000..603260e22\n--- /dev/null\n+++ b/drivers/net/sfc/base/efx_annote.h\n@@ -0,0 +1,101 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ *\n+ * Copyright (c) 2018 Solarflare Communications Inc.\n+ * All rights reserved.\n+ */\n+\n+#ifndef\t_SYS_EFX_ANNOTE_H\n+#define\t_SYS_EFX_ANNOTE_H\n+\n+#if defined(_WIN32) || defined(_WIN64)\n+#define\tEFX_HAVE_WINDOWS_ANNOTATIONS 1\n+#else\n+#define\tEFX_HAVE_WINDOWS_ANNOTATIONS 0\n+#endif\t/* defined(_WIN32) || defined(_WIN64) */\n+\n+#if defined(__sun)\n+#define\tEFX_HAVE_SOLARIS_ANNOTATIONS 1\n+#else\n+#define\tEFX_HAVE_SOLARIS_ANNOTATIONS 0\n+#endif\t/* defined(__sun) */\n+\n+#if !EFX_HAVE_WINDOWS_ANNOTATIONS\n+\n+/* Ignore Windows SAL annotations on other platforms */\n+#define\t__in\n+#define\t__in_opt\n+#define\t__in_ecount(_n)\n+#define\t__in_ecount_opt(_n)\n+#define\t__in_bcount(_n)\n+#define\t__in_bcount_opt(_n)\n+\n+#define\t__out\n+#define\t__out_opt\n+#define\t__out_ecount(_n)\n+#define\t__out_ecount_opt(_n)\n+#define\t__out_bcount(_n)\n+#define\t__out_bcount_opt(_n)\n+#define\t__out_bcount_part(_n, _l)\n+#define\t__out_bcount_part_opt(_n, _l)\n+\n+#define\t__deref_out\n+\n+#define\t__inout\n+#define\t__inout_opt\n+#define\t__inout_ecount(_n)\n+#define\t__inout_ecount_opt(_n)\n+#define\t__inout_bcount(_n)\n+#define\t__inout_bcount_opt(_n)\n+#define\t__inout_bcount_full_opt(_n)\n+\n+#define\t__deref_out_bcount_opt(n)\n+\n+#define\t__checkReturn\n+#define\t__success(_x)\n+\n+#define\t__drv_when(_p, _c)\n+\n+#endif\t/* !EFX_HAVE_WINDOWS_ANNOTATIONS */\n+\n+#if !EFX_HAVE_SOLARIS_ANNOTATIONS\n+\n+#if EFX_HAVE_WINDOWS_ANNOTATIONS\n+\n+/*\n+ * Support some SunOS/Solaris style _NOTE() annotations\n+ *\n+ * At present with the facilities provided in the WDL and the SAL we can only\n+ * easily act upon _NOTE(ARGUNUSED(arglist)) annotations.\n+ *\n+ * Intermediate macros to expand individual _NOTE annotation types into\n+ * something the WDK or SAL can understand. They shouldn't be used directly,\n+ * for example EFX_NOTE_ARGUNUSED() is only used as an intermediate step on the\n+ * transformation of _NOTE(ARGUNSED(arg1, arg2)) into\n+ * UNREFERENCED_PARAMETER((arg1, arg2));\n+ */\n+#define\tEFX_NOTE_ALIGNMENT(_fname, _n)\n+#define\tEFX_NOTE_ARGUNUSED(...)\t\tUNREFERENCED_PARAMETER((__VA_ARGS__));\n+#define\tEFX_NOTE_CONSTANTCONDITION\n+#define\tEFX_NOTE_CONSTCOND\n+#define\tEFX_NOTE_EMPTY\n+#define\tEFX_NOTE_FALLTHROUGH\n+#define\tEFX_NOTE_FALLTHRU\n+#define\tEFX_NOTE_LINTED(_msg)\n+#define\tEFX_NOTE_NOTREACHED\n+#define\tEFX_NOTE_PRINTFLIKE(_n)\n+#define\tEFX_NOTE_SCANFLIKE(_n)\n+#define\tEFX_NOTE_VARARGS(_n)\n+\n+#define\t_NOTE(_annotation)\t\tEFX_NOTE_ ## _annotation\n+\n+#else\n+\n+/* Ignore Solaris annotations on other platforms */\n+\n+#define\t_NOTE(_annotation)\n+\n+#endif\t/* EFX_HAVE_WINDOWS_ANNOTATIONS */\n+\n+#endif\t/* !EFX_HAVE_SOLARIS_ANNOTATIONS */\n+\n+#endif\t/* _SYS_EFX_ANNOTE_H */\ndiff --git a/drivers/net/sfc/efsys.h b/drivers/net/sfc/efsys.h\nindex b9d2df581..0b4795da1 100644\n--- a/drivers/net/sfc/efsys.h\n+++ b/drivers/net/sfc/efsys.h\n@@ -48,10 +48,6 @@ extern \"C\" {\n #include \"efx_types.h\"\n \n \n-#ifndef _NOTE\n-#define _NOTE(s)\n-#endif\n-\n typedef bool boolean_t;\n \n #ifndef B_FALSE\n@@ -106,40 +102,6 @@ prefetch_read_once(const volatile void *addr)\n \trte_prefetch_non_temporal(addr);\n }\n \n-/* Modifiers used for Windows builds */\n-#define __in\n-#define __in_opt\n-#define __in_ecount(_n)\n-#define __in_ecount_opt(_n)\n-#define __in_bcount(_n)\n-#define __in_bcount_opt(_n)\n-\n-#define __out\n-#define __out_opt\n-#define __out_ecount(_n)\n-#define __out_ecount_opt(_n)\n-#define __out_bcount(_n)\n-#define __out_bcount_opt(_n)\n-#define __out_bcount_part(_n, _l)\n-#define __out_bcount_part_opt(_n, _l)\n-\n-#define __deref_out\n-\n-#define __inout\n-#define __inout_opt\n-#define __inout_ecount(_n)\n-#define __inout_ecount_opt(_n)\n-#define __inout_bcount(_n)\n-#define __inout_bcount_opt(_n)\n-#define __inout_bcount_full_opt(_n)\n-\n-#define __deref_out_bcount_opt(n)\n-\n-#define __checkReturn\n-#define __success(_x)\n-\n-#define __drv_when(_p, _c)\n-\n /* Code inclusion options */\n \n \n", "prefixes": [ "11/37" ] }