Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44436/?format=api
http://patches.dpdk.org/api/patches/44436/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180907181357.23915-5-jasvinder.singh@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180907181357.23915-5-jasvinder.singh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180907181357.23915-5-jasvinder.singh@intel.com", "date": "2018-09-07T18:13:51", "name": "[04/10] net/softnic: create meter object", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "bf0c117773a4acd38bb46bf84ad57f30f69eff3d", "submitter": { "id": 285, "url": "http://patches.dpdk.org/api/people/285/?format=api", "name": "Jasvinder Singh", "email": "jasvinder.singh@intel.com" }, "delegate": { "id": 10018, "url": "http://patches.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180907181357.23915-5-jasvinder.singh@intel.com/mbox/", "series": [ { "id": 1234, "url": "http://patches.dpdk.org/api/series/1234/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1234", "date": "2018-09-07T18:13:49", "name": "net/softnic: implement metering and policing API", "version": 1, "mbox": "http://patches.dpdk.org/series/1234/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/44436/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/44436/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3593E5F48;\n\tFri, 7 Sep 2018 20:15:17 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 7BB8D5B2C\n\tfor <dev@dpdk.org>; Fri, 7 Sep 2018 20:15:06 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Sep 2018 11:15:03 -0700", "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.222.149])\n\tby fmsmga005.fm.intel.com with ESMTP; 07 Sep 2018 11:14:01 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,343,1531810800\"; d=\"scan'208\";a=\"260757195\"", "From": "Jasvinder Singh <jasvinder.singh@intel.com>", "To": "dev@dpdk.org", "Cc": "cristian.dumitrescu@intel.com", "Date": "Fri, 7 Sep 2018 19:13:51 +0100", "Message-Id": "<20180907181357.23915-5-jasvinder.singh@intel.com>", "X-Mailer": "git-send-email 2.9.3", "In-Reply-To": "<20180907181357.23915-1-jasvinder.singh@intel.com>", "References": "<20180907181357.23915-1-jasvinder.singh@intel.com>", "Subject": "[dpdk-dev] [PATCH 04/10] net/softnic: create meter object", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "implement meter object create function.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\n---\n drivers/net/softnic/rte_eth_softnic_internals.h | 4 ++\n drivers/net/softnic/rte_eth_softnic_meter.c | 92 ++++++++++++++++++++++++-\n 2 files changed, 95 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/softnic/rte_eth_softnic_internals.h b/drivers/net/softnic/rte_eth_softnic_internals.h\nindex 14ea57d..4e2ad56 100644\n--- a/drivers/net/softnic/rte_eth_softnic_internals.h\n+++ b/drivers/net/softnic/rte_eth_softnic_internals.h\n@@ -612,6 +612,10 @@ softnic_mtr_init(struct pmd_internals *p);\n void\n softnic_mtr_free(struct pmd_internals *p);\n \n+struct softnic_mtr *\n+softnic_mtr_find(struct pmd_internals *p,\n+\tuint32_t mtr_id);\n+\n struct softnic_mtr_meter_profile *\n softnic_mtr_meter_profile_find(struct pmd_internals *p,\n \tuint32_t meter_profile_id);\ndiff --git a/drivers/net/softnic/rte_eth_softnic_meter.c b/drivers/net/softnic/rte_eth_softnic_meter.c\nindex 1d6af0c..261a6a3 100644\n--- a/drivers/net/softnic/rte_eth_softnic_meter.c\n+++ b/drivers/net/softnic/rte_eth_softnic_meter.c\n@@ -179,13 +179,103 @@ pmd_mtr_meter_profile_delete(struct rte_eth_dev *dev,\n \treturn 0;\n }\n \n+struct softnic_mtr *\n+softnic_mtr_find(struct pmd_internals *p, uint32_t mtr_id)\n+{\n+\tstruct softnic_mtr_list *ml = &p->mtr.mtrs;\n+\tstruct softnic_mtr *m;\n+\n+\tTAILQ_FOREACH(m, ml, node)\n+\t\tif (m->mtr_id == mtr_id)\n+\t\t\treturn m;\n+\n+\treturn NULL;\n+}\n+\n+\n+/* MTR object create */\n+static int\n+pmd_mtr_create(struct rte_eth_dev *dev,\n+\tuint32_t mtr_id,\n+\tstruct rte_mtr_params *params,\n+\tint shared,\n+\tstruct rte_mtr_error *error)\n+{\n+\tstruct pmd_internals *p = dev->data->dev_private;\n+\tstruct softnic_mtr_list *ml = &p->mtr.mtrs;\n+\tstruct softnic_mtr_meter_profile *mp;\n+\tstruct softnic_mtr *m;\n+\n+\t/* MTR id valid */\n+\tif (softnic_mtr_find(p, mtr_id))\n+\t\treturn -rte_mtr_error_set(error,\n+\t\t\tEEXIST,\n+\t\t\tRTE_MTR_ERROR_TYPE_MTR_ID,\n+\t\t\tNULL,\n+\t\t\trte_strerror(EEXIST));\n+\n+\t/* MTR params must not be NULL */\n+\tif (params == NULL)\n+\t\treturn -rte_mtr_error_set(error,\n+\t\t\tEINVAL,\n+\t\t\tRTE_MTR_ERROR_TYPE_MTR_PARAMS,\n+\t\t\tNULL,\n+\t\t\trte_strerror(EINVAL));\n+\n+\t/* Meter profile must exist */\n+\tmp = softnic_mtr_meter_profile_find(p, params->meter_profile_id);\n+\tif (mp == NULL)\n+\t\treturn -rte_mtr_error_set(error,\n+\t\t\tEINVAL,\n+\t\t\tRTE_MTR_ERROR_TYPE_METER_PROFILE_ID,\n+\t\t\tNULL,\n+\t\t\trte_strerror(EINVAL));\n+\n+\t/* Previous meter color not supported */\n+\tif (params->use_prev_mtr_color)\n+\t\treturn -rte_mtr_error_set(error,\n+\t\t\tEINVAL,\n+\t\t\tRTE_MTR_ERROR_TYPE_MTR_PARAMS,\n+\t\t\tNULL,\n+\t\t\trte_strerror(EINVAL));\n+\n+\t/* Shared MTR object not supported */\n+\tif (shared)\n+\t\treturn -rte_mtr_error_set(error,\n+\t\t\tEINVAL,\n+\t\t\tRTE_MTR_ERROR_TYPE_SHARED,\n+\t\t\tNULL,\n+\t\t\trte_strerror(EINVAL));\n+\n+\t/* Memory allocation */\n+\tm = calloc(1, sizeof(struct softnic_mtr));\n+\tif (m == NULL)\n+\t\treturn -rte_mtr_error_set(error,\n+\t\t\tENOMEM,\n+\t\t\tRTE_MTR_ERROR_TYPE_UNSPECIFIED,\n+\t\t\tNULL,\n+\t\t\trte_strerror(ENOMEM));\n+\n+\t/* Fill in */\n+\tm->mtr_id = mtr_id;\n+\tmemcpy(&m->params, params, sizeof(m->params));\n+\n+\t/* Add to list */\n+\tTAILQ_INSERT_TAIL(ml, m, node);\n+\n+\t/* Update dependencies */\n+\tmp->n_users++;\n+\n+\treturn 0;\n+}\n+\n const struct rte_mtr_ops pmd_mtr_ops = {\n \t.capabilities_get = NULL,\n \n \t.meter_profile_add = pmd_mtr_meter_profile_add,\n \t.meter_profile_delete = pmd_mtr_meter_profile_delete,\n \n-\t.create = NULL,\n+\t.create = pmd_mtr_create,\n \t.destroy = NULL,\n \t.meter_enable = NULL,\n \t.meter_disable = NULL,\n", "prefixes": [ "04/10" ] }{ "id": 44436, "url": "