Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 44434,
    "url": "http://patches.dpdk.org/api/patches/44434/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180907181357.23915-9-jasvinder.singh@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180907181357.23915-9-jasvinder.singh@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180907181357.23915-9-jasvinder.singh@intel.com",
    "date": "2018-09-07T18:13:55",
    "name": "[08/10] net/softnic: update policer actions",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "ae5da30ded4d7a6dec3ba737bb2f224e87ae669f",
    "submitter": {
        "id": 285,
        "url": "http://patches.dpdk.org/api/people/285/?format=api",
        "name": "Jasvinder Singh",
        "email": "jasvinder.singh@intel.com"
    },
    "delegate": {
        "id": 10018,
        "url": "http://patches.dpdk.org/api/users/10018/?format=api",
        "username": "cristian_dumitrescu",
        "first_name": "Cristian",
        "last_name": "Dumitrescu",
        "email": "cristian.dumitrescu@intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180907181357.23915-9-jasvinder.singh@intel.com/mbox/",
    "series": [
        {
            "id": 1234,
            "url": "http://patches.dpdk.org/api/series/1234/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1234",
            "date": "2018-09-07T18:13:49",
            "name": "net/softnic: implement metering and policing API",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/1234/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/44434/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/44434/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id ECB1D5F2E;\n\tFri,  7 Sep 2018 20:15:14 +0200 (CEST)",
            "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 530DD5B26\n\tfor <dev@dpdk.org>; Fri,  7 Sep 2018 20:15:06 +0200 (CEST)",
            "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Sep 2018 11:15:03 -0700",
            "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.222.149])\n\tby fmsmga005.fm.intel.com with ESMTP; 07 Sep 2018 11:14:05 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.53,343,1531810800\"; d=\"scan'208\";a=\"260757395\"",
        "From": "Jasvinder Singh <jasvinder.singh@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "cristian.dumitrescu@intel.com",
        "Date": "Fri,  7 Sep 2018 19:13:55 +0100",
        "Message-Id": "<20180907181357.23915-9-jasvinder.singh@intel.com>",
        "X-Mailer": "git-send-email 2.9.3",
        "In-Reply-To": "<20180907181357.23915-1-jasvinder.singh@intel.com>",
        "References": "<20180907181357.23915-1-jasvinder.singh@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 08/10] net/softnic: update policer actions",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Implement meter object policer actions function.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\n---\n drivers/net/softnic/rte_eth_softnic_meter.c | 127 +++++++++++++++++++++++++++-\n 1 file changed, 126 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/softnic/rte_eth_softnic_meter.c b/drivers/net/softnic/rte_eth_softnic_meter.c\nindex 9344f37..41af9c7 100644\n--- a/drivers/net/softnic/rte_eth_softnic_meter.c\n+++ b/drivers/net/softnic/rte_eth_softnic_meter.c\n@@ -504,6 +504,131 @@ pmd_mtr_meter_dscp_table_update(struct rte_eth_dev *dev,\n \treturn 0;\n }\n \n+static int\n+softnic_table_policer_actions_update(struct pmd_internals *p,\n+\tstruct softnic_mtr *m,\n+\tuint32_t action_mask,\n+\tenum rte_mtr_policer_action *actions,\n+\tstruct rte_mtr_error *error)\n+{\n+\tstruct rte_flow *mflow = m->flow;\n+\tuint32_t i;\n+\tint status;\n+\n+\t/* Update meter policer actions */\n+\tfor (i = 0; i < RTE_MTR_COLORS; i++) {\n+\t\tif ((action_mask >> i) & 1)\n+\t\t\tmflow->action.mtr.mtr[0].policer[i] =\n+\t\t\t\t(enum rte_table_action_policer)actions[i];\n+\t}\n+\n+\t/* Re-add new rule */\n+\tstatus = softnic_pipeline_table_rule_add(p,\n+\t\tmflow->pipeline->name,\n+\t\tmflow->table_id,\n+\t\t&mflow->match,\n+\t\t&mflow->action,\n+\t\t&mflow->data);\n+\tif (status) {\n+\t\trte_mtr_error_set(error,\n+\t\t\tEINVAL,\n+\t\t\tRTE_MTR_ERROR_TYPE_UNSPECIFIED,\n+\t\t\tNULL,\n+\t\t\t\"Pipeline table rule re-add failed\");\n+\t\treturn -1;\n+\t}\n+\n+\t/* Reset the meter stats */\n+\tstruct pipeline *pipeline = mflow->pipeline;\n+\tstruct softnic_table *table = &pipeline->table[mflow->table_id];\n+\tuint32_t tc_mask = 1 << 0;\n+\n+\tstatus = rte_table_action_meter_read(table->a,\n+\t\tmflow->data,\n+\t\ttc_mask,\n+\t\tNULL,\n+\t\t1);\n+\tif (status) {\n+\t\trte_mtr_error_set(error,\n+\t\t\tEINVAL,\n+\t\t\tRTE_MTR_ERROR_TYPE_UNSPECIFIED,\n+\t\t\tNULL,\n+\t\t\t\"Meter stats reset failed\");\n+\t\treturn -1;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+/* MTR object policer action update */\n+static int\n+pmd_mtr_policer_actions_update(struct rte_eth_dev *dev,\n+\tuint32_t mtr_id,\n+\tuint32_t action_mask,\n+\tenum rte_mtr_policer_action *actions,\n+\tstruct rte_mtr_error *error)\n+{\n+\tstruct pmd_internals *p = dev->data->dev_private;\n+\tstruct softnic_mtr *m;\n+\tuint32_t i;\n+\tint status;\n+\n+\t/* MTR object id must be valid */\n+\tm = softnic_mtr_find(p, mtr_id);\n+\tif (m == NULL)\n+\t\treturn -rte_mtr_error_set(error,\n+\t\t\tEEXIST,\n+\t\t\tRTE_MTR_ERROR_TYPE_MTR_ID,\n+\t\t\tNULL,\n+\t\t\trte_strerror(EEXIST));\n+\n+\t/* Policer actions */\n+\tif (actions == NULL)\n+\t\treturn -rte_mtr_error_set(error,\n+\t\t\t\tEINVAL,\n+\t\t\t\tRTE_MTR_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\tNULL,\n+\t\t\t\trte_strerror(EINVAL));\n+\n+\t/* Valid Policer actions */\n+\tfor (i = 0; i < RTE_MTR_COLORS; i++) {\n+\t\tif ((action_mask >> i) & 1) {\n+\t\t\tif (actions[i] != MTR_POLICER_ACTION_COLOR_GREEN  &&\n+\t\t\t\tactions[i] != MTR_POLICER_ACTION_COLOR_YELLOW &&\n+\t\t\t\tactions[i] != MTR_POLICER_ACTION_COLOR_RED &&\n+\t\t\t\tactions[i] != MTR_POLICER_ACTION_DROP)\n+\t\t\t\treturn -rte_mtr_error_set(error,\n+\t\t\t\t\tEINVAL,\n+\t\t\t\t\tRTE_MTR_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\tNULL,\n+\t\t\t\t\trte_strerror(EINVAL));\n+\t\t}\n+\t}\n+\n+\t/* MTR object owner valid? */\n+\tif (m->flow) {\n+\t\tstatus = softnic_table_policer_actions_update(p,\n+\t\t\t\tm,\n+\t\t\t\taction_mask,\n+\t\t\t\tactions,\n+\t\t\t\terror);\n+\t\tif (status)\n+\t\t\treturn -rte_mtr_error_set(error,\n+\t\t\t\tEINVAL,\n+\t\t\t\tRTE_MTR_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\tNULL,\n+\t\t\t\trte_strerror(EINVAL));\n+\t}\n+\n+\t/* Update MTR object policer actions */\n+\tfor (i = 0; i < RTE_MTR_COLORS; i++) {\n+\t\tif ((action_mask >> i) & 1)\n+\t\t\tm->params.action[i] = actions[i];\n+\t}\n+\n+\treturn 0;\n+}\n+\n const struct rte_mtr_ops pmd_mtr_ops = {\n \t.capabilities_get = NULL,\n \n@@ -517,7 +642,7 @@ const struct rte_mtr_ops pmd_mtr_ops = {\n \n \t.meter_profile_update = pmd_mtr_meter_profile_update,\n \t.meter_dscp_table_update = pmd_mtr_meter_dscp_table_update,\n-\t.policer_actions_update = NULL,\n+\t.policer_actions_update = pmd_mtr_policer_actions_update,\n \t.stats_update = NULL,\n \n \t.stats_read = NULL,\n",
    "prefixes": [
        "08/10"
    ]
}