Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44246/?format=api
{ "id": 44246, "url": "http://patches.dpdk.org/api/patches/44246/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1536068953-9352-8-git-send-email-tdu@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1536068953-9352-8-git-send-email-tdu@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1536068953-9352-8-git-send-email-tdu@semihalf.com", "date": "2018-09-04T13:49:08", "name": "[v2,07/12] net/mvpp2: detach tx_qos from rx cls/qos config", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "276d430d4a3c05c7acc2b718bc7ede82ce21f2c6", "submitter": { "id": 846, "url": "http://patches.dpdk.org/api/people/846/?format=api", "name": "Tomasz Duszynski", "email": "tdu@semihalf.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1536068953-9352-8-git-send-email-tdu@semihalf.com/mbox/", "series": [ { "id": 1171, "url": "http://patches.dpdk.org/api/series/1171/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1171", "date": "2018-09-04T13:49:02", "name": "net/mvpp2: add new features", "version": 2, "mbox": "http://patches.dpdk.org/series/1171/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/44246/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/44246/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8545158FA;\n\tTue, 4 Sep 2018 15:49:36 +0200 (CEST)", "from mail-lj1-f174.google.com (mail-lj1-f174.google.com\n\t[209.85.208.174]) by dpdk.org (Postfix) with ESMTP id 23B3B2F4F\n\tfor <dev@dpdk.org>; Tue, 4 Sep 2018 15:49:31 +0200 (CEST)", "by mail-lj1-f174.google.com with SMTP id j19-v6so3206035ljc.7\n\tfor <dev@dpdk.org>; Tue, 04 Sep 2018 06:49:31 -0700 (PDT)", "from sh.semihalf.local (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173]) by smtp.gmail.com with ESMTPSA id\n\tq22-v6sm4057225lff.10.2018.09.04.06.49.29\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tTue, 04 Sep 2018 06:49:29 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=saXJDORWKb77RlWzNFSe18BbyNH46U4cBEul0wRwrRs=;\n\tb=wOWtIt8B3+69tGWGzL5gnyddKFlJ16dKw+5GCWTsrVfMnX87VLwE+IZzxkDPDAWHWJ\n\tdzKyQ8loO+eilXbbbQXqot+fZqxoVTnoZtio5t8I/o7TftWvKaGqJJ7eZigxpqIwLGkC\n\twKVy4DL2GRa2jL0OzUbJiVwpvVqk3i4YhbZKQaSX9wgxr7GqNIdBrN7IeIQuwgF+MKxB\n\tV4XEUfLe+6zsCnj+RUjwCbpi8rHrEAA7LwR2zPzYhl2FSjq7PEd3Zjwv2kbSWyZktYMv\n\tWdKt3chHJs8fvqoe4rPwL46O+0hH8mNY5Cm31IpG3EF5OvtXgspcFb24/wLRImac4ZSC\n\t+NQg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=saXJDORWKb77RlWzNFSe18BbyNH46U4cBEul0wRwrRs=;\n\tb=bYRVTuyKJA2PWB8meexr0a8zW8YQ2378cKGUfrmQ8MTJIYgWKpeq5gzKZbyWuqUQYA\n\tUQjfl08sljShpu98wkwE/qBJUic1ABCkXqlTFd9moQMpakxJMEz0OPRATfuYAf/XFfy5\n\tGYTRCWWF/jg3dru/KwL5arOoVuzr9aavPK7+ccJugRAfe2dozt5GqTkhA+qOz9yxXYwh\n\tiXCcCGe0IdgtffDwLVsg0RhibWDzCjFZXSscgaXOtkwOMZDz5Nc+b3D7IhQeDx0vIsQd\n\t147c4PVaA3fWUQK2sosDY26e2MkmJ6jWOv5iv/6KJaRbkR9qbkTdLdVXvxhVeOvP7S7L\n\t3Hdg==", "X-Gm-Message-State": "APzg51BvxgnrdRRwLyCDJzT5AtjXOsPAPGPUHt7XHaB58y8Jl7bgPoNr\n\txs4Wk4aRAlPu7yMTkNMAlNa5a6wUN/gdGA==", "X-Google-Smtp-Source": "ANB0VdZlEZ6lZabel4fj2daqIYQg1Us7gUf5yDQ3LTXll0EB9O/nAepS+erGlRD3suj2dH4SnYQpkA==", "X-Received": "by 2002:a2e:8e81:: with SMTP id\n\tz1-v6mr3156797ljk.156.1536068970611; \n\tTue, 04 Sep 2018 06:49:30 -0700 (PDT)", "From": "Tomasz Duszynski <tdu@semihalf.com>", "To": "dev@dpdk.org", "Cc": "nsamsono@marvell.com, mw@semihalf.com, Yuval Caduri <cyuval@marvell.com>", "Date": "Tue, 4 Sep 2018 15:49:08 +0200", "Message-Id": "<1536068953-9352-8-git-send-email-tdu@semihalf.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1536068953-9352-1-git-send-email-tdu@semihalf.com>", "References": "<1536045016-32008-1-git-send-email-tdu@semihalf.com>\n\t<1536068953-9352-1-git-send-email-tdu@semihalf.com>", "Subject": "[dpdk-dev] [PATCH v2 07/12] net/mvpp2: detach tx_qos from rx\n\tcls/qos config", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Yuval Caduri <cyuval@marvell.com>\n\nFunctional change:\nOpen receive cls/qos related features, only if the\nconfig file contains an rx_related configuration entry.\nThis allows to configure tx_related entries, w/o unintentionally\nopening rx cls/qos.\n\nCode:\n'use_global_defaults' is by default set to '1'.\nOnly if an rx_related entry was configured, it is updated to '0'.\nrx cls/qos is performed only if 'use_global_defaults' is '0'.\nDefault TC configuration is now only mandatory when\n'use_global_defaults' is '0'.\n\nSigned-off-by: Yuval Caduri <cyuval@marvell.com>\nReviewed-by: Natalie Samsonov <nsamsono@marvell.com>\nTested-by: Natalie Samsonov <nsamsono@marvell.com>\n---\n drivers/net/mvpp2/mrvl_ethdev.c | 3 ++-\n drivers/net/mvpp2/mrvl_qos.c | 41 +++++++++++++++++++++++------------------\n 2 files changed, 25 insertions(+), 19 deletions(-)", "diff": "diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c\nindex a1dc6b1..5643e7d 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.c\n+++ b/drivers/net/mvpp2/mrvl_ethdev.c\n@@ -602,7 +602,8 @@ mrvl_dev_start(struct rte_eth_dev *dev)\n \t}\n \n \t/* For default QoS config, don't start classifier. */\n-\tif (mrvl_qos_cfg) {\n+\tif (mrvl_qos_cfg &&\n+\t mrvl_qos_cfg->port[dev->data->port_id].use_global_defaults == 0) {\n \t\tret = mrvl_start_qos_mapping(priv);\n \t\tif (ret) {\n \t\t\tMRVL_LOG(ERR, \"Failed to setup QoS mapping\");\ndiff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c\nindex e039635..5d80c3e 100644\n--- a/drivers/net/mvpp2/mrvl_qos.c\n+++ b/drivers/net/mvpp2/mrvl_qos.c\n@@ -324,6 +324,7 @@ parse_tc_cfg(struct rte_cfgfile *file, int port, int tc,\n \tif (rte_cfgfile_num_sections(file, sec_name, strlen(sec_name)) <= 0)\n \t\treturn 0;\n \n+\tcfg->port[port].use_global_defaults = 0;\n \tentry = rte_cfgfile_get_entry(file, sec_name, MRVL_TOK_RXQ);\n \tif (entry) {\n \t\tn = get_entry_values(entry,\n@@ -421,7 +422,7 @@ parse_policer(struct rte_cfgfile *file, int port, const char *sec_name,\n \t\t\tcfg->port[port].policer_params.token_unit =\n \t\t\t\tPP2_CLS_PLCR_PACKETS_TOKEN_UNIT;\n \t\t} else {\n-\t\t\tRTE_LOG(ERR, PMD, \"Unknown token: %s\\n\", entry);\n+\t\t\tMRVL_LOG(ERR, \"Unknown token: %s\", entry);\n \t\t\treturn -1;\n \t\t}\n \t}\n@@ -438,7 +439,7 @@ parse_policer(struct rte_cfgfile *file, int port, const char *sec_name,\n \t\t\tcfg->port[port].policer_params.color_mode =\n \t\t\t\tPP2_CLS_PLCR_COLOR_AWARE_MODE;\n \t\t} else {\n-\t\t\tRTE_LOG(ERR, PMD, \"Error in parsing: %s\\n\", entry);\n+\t\t\tMRVL_LOG(ERR, \"Error in parsing: %s\", entry);\n \t\t\treturn -1;\n \t\t}\n \t}\n@@ -518,28 +519,15 @@ mrvl_get_qoscfg(const char *key __rte_unused, const char *path,\n \t\tsnprintf(sec_name, sizeof(sec_name), \"%s %d %s\",\n \t\t\tMRVL_TOK_PORT, n, MRVL_TOK_DEFAULT);\n \n+\t\t/* Use global defaults, unless an override occurs */\n+\t\t(*cfg)->port[n].use_global_defaults = 1;\n+\n \t\t/* Skip ports non-existing in configuration. */\n \t\tif (rte_cfgfile_num_sections(file, sec_name,\n \t\t\t\tstrlen(sec_name)) <= 0) {\n-\t\t\t(*cfg)->port[n].use_global_defaults = 1;\n-\t\t\t(*cfg)->port[n].mapping_priority =\n-\t\t\t\tPP2_CLS_QOS_TBL_VLAN_IP_PRI;\n \t\t\tcontinue;\n \t\t}\n \n-\t\tentry = rte_cfgfile_get_entry(file, sec_name,\n-\t\t\t\tMRVL_TOK_DEFAULT_TC);\n-\t\tif (entry) {\n-\t\t\tif (get_val_securely(entry, &val) < 0 ||\n-\t\t\t\tval > USHRT_MAX)\n-\t\t\t\treturn -1;\n-\t\t\t(*cfg)->port[n].default_tc = (uint8_t)val;\n-\t\t} else {\n-\t\t\tMRVL_LOG(ERR,\n-\t\t\t\t\"Default Traffic Class required in custom configuration!\");\n-\t\t\treturn -1;\n-\t\t}\n-\n \t\t/*\n \t\t * Read per-port rate limiting. Setting that will\n \t\t * disable per-queue rate limiting.\n@@ -573,6 +561,7 @@ mrvl_get_qoscfg(const char *key __rte_unused, const char *path,\n \t\tentry = rte_cfgfile_get_entry(file, sec_name,\n \t\t\t\tMRVL_TOK_MAPPING_PRIORITY);\n \t\tif (entry) {\n+\t\t\t(*cfg)->port[n].use_global_defaults = 0;\n \t\t\tif (!strncmp(entry, MRVL_TOK_VLAN_IP,\n \t\t\t\tsizeof(MRVL_TOK_VLAN_IP)))\n \t\t\t\t(*cfg)->port[n].mapping_priority =\n@@ -602,6 +591,7 @@ mrvl_get_qoscfg(const char *key __rte_unused, const char *path,\n \t\tentry = rte_cfgfile_get_entry(file, sec_name,\n \t\t\t\tMRVL_TOK_PLCR_DEFAULT);\n \t\tif (entry) {\n+\t\t\t(*cfg)->port[n].use_global_defaults = 0;\n \t\t\tif (get_val_securely(entry, &val) < 0)\n \t\t\t\treturn -1;\n \n@@ -627,6 +617,21 @@ mrvl_get_qoscfg(const char *key __rte_unused, const char *path,\n \t\t\t\t\t\"Error %d parsing port %d tc %d!\\n\",\n \t\t\t\t\tret, n, i);\n \t\t}\n+\n+\t\tentry = rte_cfgfile_get_entry(file, sec_name,\n+\t\t\t\t\t MRVL_TOK_DEFAULT_TC);\n+\t\tif (entry) {\n+\t\t\tif (get_val_securely(entry, &val) < 0 ||\n+\t\t\t val > USHRT_MAX)\n+\t\t\t\treturn -1;\n+\t\t\t(*cfg)->port[n].default_tc = (uint8_t)val;\n+\t\t} else {\n+\t\t\tif ((*cfg)->port[n].use_global_defaults == 0) {\n+\t\t\t\tMRVL_LOG(ERR,\n+\t\t\t\t\t \"Default Traffic Class required in custom configuration!\");\n+\t\t\t\treturn -1;\n+\t\t\t}\n+\t\t}\n \t}\n \n \treturn 0;\n", "prefixes": [ "v2", "07/12" ] }