Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44238/?format=api
http://patches.dpdk.org/api/patches/44238/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/061aee3ed230052b4714f4deacc2bedf8e611689.1536064999.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<061aee3ed230052b4714f4deacc2bedf8e611689.1536064999.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/061aee3ed230052b4714f4deacc2bedf8e611689.1536064999.git.anatoly.burakov@intel.com", "date": "2018-09-04T13:11:39", "name": "[04/16] mem: do not check for invalid socket ID", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ca534aab0f59437a65a8d18d733d762082e1b611", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/061aee3ed230052b4714f4deacc2bedf8e611689.1536064999.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 1170, "url": "http://patches.dpdk.org/api/series/1170/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1170", "date": "2018-09-04T13:11:35", "name": "Support externally allocated memory in DPDK", "version": 1, "mbox": "http://patches.dpdk.org/series/1170/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/44238/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/44238/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0221C4C88;\n\tTue, 4 Sep 2018 15:14:04 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 129AA4CBB\n\tfor <dev@dpdk.org>; Tue, 4 Sep 2018 15:14:01 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t04 Sep 2018 06:14:01 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga008.jf.intel.com with ESMTP; 04 Sep 2018 06:11:53 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw84DBqc1023356; Tue, 4 Sep 2018 14:11:52 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w84DBqJs024388;\n\tTue, 4 Sep 2018 14:11:52 +0100", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w84DBqIX024375;\n\tTue, 4 Sep 2018 14:11:52 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,329,1531810800\"; d=\"scan'208\";a=\"70456120\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "laszlo.madarassy@ericsson.com, laszlo.vadkerti@ericsson.com,\n\tandras.kovacs@ericsson.com, winnie.tian@ericsson.com,\n\tdaniel.andrasi@ericsson.com, janos.kobor@ericsson.com,\n\tsrinath.mannam@broadcom.com, scott.branden@broadcom.com,\n\tajit.khaparde@broadcom.com, keith.wiles@intel.com,\n\tbruce.richardson@intel.com, thomas@monjalon.net", "Date": "Tue, 4 Sep 2018 14:11:39 +0100", "Message-Id": "<061aee3ed230052b4714f4deacc2bedf8e611689.1536064999.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": [ "<cover.1536064999.git.anatoly.burakov@intel.com>", "<cover.1536064999.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1536064999.git.anatoly.burakov@intel.com>", "<cover.1536064999.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH 04/16] mem: do not check for invalid socket ID", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "We will be assigning \"invalid\" socket ID's to external heap, and\nmalloc will now be able to verify if a supplied socket ID is in\nfact a valid one, rendering parameter checks for sockets\nobsolete.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/common/eal_common_memzone.c | 8 +++++---\n lib/librte_eal/common/rte_malloc.c | 4 ----\n 2 files changed, 5 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_memzone.c b/lib/librte_eal/common/eal_common_memzone.c\nindex 7300fe05d..b7081afbf 100644\n--- a/lib/librte_eal/common/eal_common_memzone.c\n+++ b/lib/librte_eal/common/eal_common_memzone.c\n@@ -120,13 +120,15 @@ memzone_reserve_aligned_thread_unsafe(const char *name, size_t len,\n \t\treturn NULL;\n \t}\n \n-\tif ((socket_id != SOCKET_ID_ANY) &&\n-\t (socket_id >= RTE_MAX_NUMA_NODES || socket_id < 0)) {\n+\tif ((socket_id != SOCKET_ID_ANY) && socket_id < 0) {\n \t\trte_errno = EINVAL;\n \t\treturn NULL;\n \t}\n \n-\tif (!rte_eal_has_hugepages())\n+\t/* only set socket to SOCKET_ID_ANY if we aren't allocating for an\n+\t * external heap.\n+\t */\n+\tif (!rte_eal_has_hugepages() && socket_id < RTE_MAX_NUMA_NODES)\n \t\tsocket_id = SOCKET_ID_ANY;\n \n \tcontig = (flags & RTE_MEMZONE_IOVA_CONTIG) != 0;\ndiff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c\nindex dfcdf380a..458c44ba6 100644\n--- a/lib/librte_eal/common/rte_malloc.c\n+++ b/lib/librte_eal/common/rte_malloc.c\n@@ -47,10 +47,6 @@ rte_malloc_socket(const char *type, size_t size, unsigned int align,\n \tif (!rte_eal_has_hugepages())\n \t\tsocket_arg = SOCKET_ID_ANY;\n \n-\t/* Check socket parameter */\n-\tif (socket_arg >= RTE_MAX_NUMA_NODES)\n-\t\treturn NULL;\n-\n \treturn malloc_heap_alloc(type, size, socket_arg, 0,\n \t\t\talign == 0 ? 1 : align, 0, false);\n }\n", "prefixes": [ "04/16" ] }{ "id": 44238, "url": "