Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 44210,
    "url": "http://patches.dpdk.org/api/patches/44210/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1536045016-32008-2-git-send-email-tdu@semihalf.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1536045016-32008-2-git-send-email-tdu@semihalf.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1536045016-32008-2-git-send-email-tdu@semihalf.com",
    "date": "2018-09-04T07:10:09",
    "name": "[1/8] net/mvpp2: initialize ppio only once",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "27df13bbc2ff306efaf032e33f37b0baa4524bf0",
    "submitter": {
        "id": 846,
        "url": "http://patches.dpdk.org/api/people/846/?format=api",
        "name": "Tomasz Duszynski",
        "email": "tdu@semihalf.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1536045016-32008-2-git-send-email-tdu@semihalf.com/mbox/",
    "series": [
        {
            "id": 1165,
            "url": "http://patches.dpdk.org/api/series/1165/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1165",
            "date": "2018-09-04T07:10:08",
            "name": "net/mvpp2: add new features",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/1165/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/44210/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/44210/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8CC822BF3;\n\tTue,  4 Sep 2018 09:10:35 +0200 (CEST)",
            "from mail-pl1-f195.google.com (mail-pl1-f195.google.com\n\t[209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 727E42B92\n\tfor <dev@dpdk.org>; Tue,  4 Sep 2018 09:10:33 +0200 (CEST)",
            "by mail-pl1-f195.google.com with SMTP id f6-v6so1197696plo.1\n\tfor <dev@dpdk.org>; Tue, 04 Sep 2018 00:10:33 -0700 (PDT)",
            "from sh.semihalf.local (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173]) by smtp.gmail.com with ESMTPSA id\n\tl79-v6sm31229451pfb.111.2018.09.04.00.10.30\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tTue, 04 Sep 2018 00:10:31 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=y8U6gYDQP9+l7c5h3ZcJ0DaVjlhx9ObAKd++8V34sQU=;\n\tb=YaumliVrDs29UOniOzM8VEhunldBjFsSVzYihKA8EYZCiXTHsUbKFyI+qI5gjq3f9b\n\tQyUALTIo4JioMjnuOzpvRnH4pJi6OcamJ40AX5ig27Kl2eYSt4nplPE01/A/rOI9o65w\n\tHxN/e47Wr106xpRfHYjGdZgczc8fCJ9s3MWTa0y9bIdAyKPON+hWgicvTZCAozOna594\n\tQBA67JV06AXnUVKQGlXO0rNoLV10zfotaiHeymdQd3v9dSBWIgNLznsaRLN1M0wVIqrE\n\tdGDccVaBZhpt4rF5hISa8a7ilreLED1n1iFXCaNRPCwIHkZuYY1WLmYxcXBsSS71W/Kv\n\totXw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=y8U6gYDQP9+l7c5h3ZcJ0DaVjlhx9ObAKd++8V34sQU=;\n\tb=d/pSpf/GMP/0TQbjhgV6GqDMdTHK4VYdWJUZ+sEiYB8s2MTwUcS0Ockgn0faAfv1R+\n\t5q2x6ImiQc97wjta10rUB5fOOGPqwP7DXrgjjES24trMJK/X1f/qpnaZxY37iFPp30pL\n\tEHUhBF+rdteEUzO2iZCdgIain6MR0CCKPkFLwU/UplhwHvliT8U3oNKCXf03S8m1E45o\n\tKHMAS6uv4y1nBdTYt8j0/9GthNouNlOsBjdsJMeHRfIAAs4Uon8tnLRyBkAW5I76MvU/\n\tAbOCIEmm7XTyWcY2u9zbfah5wxgfjX6DitV5ysFgkqBYOHBGUqJH8+TrzdcuvViNVBNO\n\tCFbw==",
        "X-Gm-Message-State": "APzg51D57KoTBSg94SKpJCODp7WB+eQNvmGnlR2rmb6xsH3l10sXEGIa\n\tt3lEjpz15BiirisfyEnkpiXfgVDmzvkX0g==",
        "X-Google-Smtp-Source": "ANB0VdaSOV5sE8oedz7AXfmfdMC6a7Bt4btYlDbNcnTQJ4ZN9yxK2BLZ4Gl2eg5pm3FuYPJJPvY1cg==",
        "X-Received": "by 2002:a17:902:8bc4:: with SMTP id\n\tr4-v6mr31261181plo.124.1536045032200; \n\tTue, 04 Sep 2018 00:10:32 -0700 (PDT)",
        "From": "Tomasz Duszynski <tdu@semihalf.com>",
        "To": "dev@dpdk.org",
        "Cc": "nsamsono@marvell.com,\n\tmw@semihalf.com",
        "Date": "Tue,  4 Sep 2018 09:10:09 +0200",
        "Message-Id": "<1536045016-32008-2-git-send-email-tdu@semihalf.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1536045016-32008-1-git-send-email-tdu@semihalf.com>",
        "References": "<1536045016-32008-1-git-send-email-tdu@semihalf.com>",
        "Subject": "[dpdk-dev] [PATCH 1/8] net/mvpp2: initialize ppio only once",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Natalie Samsonov <nsamsono@marvell.com>\n\nThis changes stop/start/configure behavior due to issue in MUSDK\nlibrary itself.  From now on, ppio can be reconfigured only after interface\nis closed.\n\nSigned-off-by: Natalie Samsonov <nsamsono@marvell.com>\nReviewed-by: Yuval Caduri <cyuval@marvell.com>\n---\n drivers/net/mvpp2/mrvl_ethdev.c | 53 +++++++++++++++++++++++++----------------\n 1 file changed, 32 insertions(+), 21 deletions(-)",
    "diff": "diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c\nindex 6824445..f022cad 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.c\n+++ b/drivers/net/mvpp2/mrvl_ethdev.c\n@@ -304,6 +304,11 @@ mrvl_dev_configure(struct rte_eth_dev *dev)\n \tstruct mrvl_priv *priv = dev->data->dev_private;\n \tint ret;\n \n+\tif (priv->ppio) {\n+\t\tMRVL_LOG(INFO, \"Device reconfiguration is not supported\");\n+\t\treturn -EINVAL;\n+\t}\n+\n \tif (dev->data->dev_conf.rxmode.mq_mode != ETH_MQ_RX_NONE &&\n \t    dev->data->dev_conf.rxmode.mq_mode != ETH_MQ_RX_RSS) {\n \t\tMRVL_LOG(INFO, \"Unsupported rx multi queue mode %d\",\n@@ -525,6 +530,9 @@ mrvl_dev_start(struct rte_eth_dev *dev)\n \tchar match[MRVL_MATCH_LEN];\n \tint ret = 0, i, def_init_size;\n \n+\tif (priv->ppio)\n+\t\treturn mrvl_dev_set_link_up(dev);\n+\n \tsnprintf(match, sizeof(match), \"ppio-%d:%d\",\n \t\t priv->pp_id, priv->ppio_id);\n \tpriv->ppio_params.match = match;\n@@ -749,28 +757,7 @@ mrvl_flush_bpool(struct rte_eth_dev *dev)\n static void\n mrvl_dev_stop(struct rte_eth_dev *dev)\n {\n-\tstruct mrvl_priv *priv = dev->data->dev_private;\n-\n \tmrvl_dev_set_link_down(dev);\n-\tmrvl_flush_rx_queues(dev);\n-\tmrvl_flush_tx_shadow_queues(dev);\n-\tif (priv->cls_tbl) {\n-\t\tpp2_cls_tbl_deinit(priv->cls_tbl);\n-\t\tpriv->cls_tbl = NULL;\n-\t}\n-\tif (priv->qos_tbl) {\n-\t\tpp2_cls_qos_tbl_deinit(priv->qos_tbl);\n-\t\tpriv->qos_tbl = NULL;\n-\t}\n-\tif (priv->ppio)\n-\t\tpp2_ppio_deinit(priv->ppio);\n-\tpriv->ppio = NULL;\n-\n-\t/* policer must be released after ppio deinitialization */\n-\tif (priv->policer) {\n-\t\tpp2_cls_plcr_deinit(priv->policer);\n-\t\tpriv->policer = NULL;\n-\t}\n }\n \n /**\n@@ -785,6 +772,9 @@ mrvl_dev_close(struct rte_eth_dev *dev)\n \tstruct mrvl_priv *priv = dev->data->dev_private;\n \tsize_t i;\n \n+\tmrvl_flush_rx_queues(dev);\n+\tmrvl_flush_tx_shadow_queues(dev);\n+\n \tfor (i = 0; i < priv->ppio_params.inqs_params.num_tcs; ++i) {\n \t\tstruct pp2_ppio_tc_params *tc_params =\n \t\t\t&priv->ppio_params.inqs_params.tcs_params[i];\n@@ -795,7 +785,28 @@ mrvl_dev_close(struct rte_eth_dev *dev)\n \t\t}\n \t}\n \n+\tif (priv->cls_tbl) {\n+\t\tpp2_cls_tbl_deinit(priv->cls_tbl);\n+\t\tpriv->cls_tbl = NULL;\n+\t}\n+\n+\tif (priv->qos_tbl) {\n+\t\tpp2_cls_qos_tbl_deinit(priv->qos_tbl);\n+\t\tpriv->qos_tbl = NULL;\n+\t}\n+\n \tmrvl_flush_bpool(dev);\n+\n+\tif (priv->ppio) {\n+\t\tpp2_ppio_deinit(priv->ppio);\n+\t\tpriv->ppio = NULL;\n+\t}\n+\n+\t/* policer must be released after ppio deinitialization */\n+\tif (priv->policer) {\n+\t\tpp2_cls_plcr_deinit(priv->policer);\n+\t\tpriv->policer = NULL;\n+\t}\n }\n \n /**\n",
    "prefixes": [
        "1/8"
    ]
}