Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44140/?format=api
http://patches.dpdk.org/api/patches/44140/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1535731778-28288-2-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1535731778-28288-2-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1535731778-28288-2-git-send-email-arybchenko@solarflare.com", "date": "2018-08-31T16:09:37", "name": "[1/2] net/failsafe: support runtime Rx queues setup", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6332913efd0f83f92c481f9aa5ff3a80c56d516b", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1535731778-28288-2-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 1145, "url": "http://patches.dpdk.org/api/series/1145/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1145", "date": "2018-08-31T16:09:36", "name": "net/failsafe: support runtime queue setup", "version": 1, "mbox": "http://patches.dpdk.org/series/1145/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/44140/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/44140/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AEAF47CE7;\n\tFri, 31 Aug 2018 18:09:55 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 2D13B5F2E\n\tfor <dev@dpdk.org>; Fri, 31 Aug 2018 18:09:52 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id B1374B40057; Fri, 31 Aug 2018 16:09:49 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Fri, 31 Aug 2018 09:09:46 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Fri, 31 Aug 2018 09:09:46 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw7VG9jhb028072; Fri, 31 Aug 2018 17:09:45 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t3116A1626D2; Fri, 31 Aug 2018 17:09:45 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Gaetan Rivet <gaetan.rivet@6wind.com>", "CC": "<dev@dpdk.org>, Ian Dolzhansky <Ian.Dolzhansky@oktetlabs.ru>", "Date": "Fri, 31 Aug 2018 17:09:37 +0100", "Message-ID": "<1535731778-28288-2-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1535731778-28288-1-git-send-email-arybchenko@solarflare.com>", "References": "<1535731778-28288-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24064.005", "X-TM-AS-Result": "No-1.444900-4.000000-10", "X-TMASE-MatchedRID": "8hqU3tU3q+CAiWRjG7Ut6R+WEMjoO9WWTJDl9FKHbrkYSjzp7efq+r6Y\n\tVRYkPkYC7lGe7/57bl8VmqZXmnc/Uhm45uWXWpVB7spMO3HwKCDDHSNFHFxB820eIjMMK3Pp81o\n\t1+gWZiThMmm8bxtFZ3cfr4HrQmLildWSASb0lZx1/OBWacv+iVe3+iQEtoSj4EvoxTu3fj1tt31\n\tnTPUZUNtp9a0LxKCm8gnq2nFD88n6PaFHMfVTC4BRFJJyf5BJerSFs54Y4wbX6C0ePs7A07Rf2u\n\tkFm4ENtOC0zMc03QTs42WJ0/M0Frs6Oh+jgzTiD5xknrYrnGHi+Qq45Ks+9rnfgFX+MNA89G2CT\n\tFjzNc6etFqtU0iIXMxAKtHFGNW/22kC7SwvGlKhDwb7Jglhh1lFkOwaJdCKgGObbx/Uctjc=", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--1.444900-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24064.005", "X-MDID": "1535731790-aJJfAZ_F3HLe", "Subject": "[dpdk-dev] [PATCH 1/2] net/failsafe: support runtime Rx queues setup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ian Dolzhansky <Ian.Dolzhansky@oktetlabs.ru>\n\nSigned-off-by: Ian Dolzhansky <Ian.Dolzhansky@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n doc/guides/nics/features/failsafe.ini | 1 +\n doc/guides/rel_notes/release_18_11.rst | 1 +\n drivers/net/failsafe/failsafe_intr.c | 2 +-\n drivers/net/failsafe/failsafe_ops.c | 8 ++++++--\n 4 files changed, 9 insertions(+), 3 deletions(-)", "diff": "diff --git a/doc/guides/nics/features/failsafe.ini b/doc/guides/nics/features/failsafe.ini\nindex 74eae4a62..8bb2cac4c 100644\n--- a/doc/guides/nics/features/failsafe.ini\n+++ b/doc/guides/nics/features/failsafe.ini\n@@ -8,6 +8,7 @@ Link status = Y\n Link status event = Y\n Rx interrupt = Y\n Queue start/stop = Y\n+Runtime Rx queue setup = Y\n MTU update = Y\n Jumbo frame = Y\n Promiscuous mode = Y\ndiff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst\nindex ad08a204f..85561dacd 100644\n--- a/doc/guides/rel_notes/release_18_11.rst\n+++ b/doc/guides/rel_notes/release_18_11.rst\n@@ -60,6 +60,7 @@ New Features\n \n * Support for Rx and Tx queues start and stop.\n * Support for Rx and Tx queues deferred start.\n+ * Support for runtime Rx queues setup.\n \n * **Added ability to switch queue deferred start flag on testpmd app.**\n \ndiff --git a/drivers/net/failsafe/failsafe_intr.c b/drivers/net/failsafe/failsafe_intr.c\nindex fc6ec37fc..1c2cb71c4 100644\n--- a/drivers/net/failsafe/failsafe_intr.c\n+++ b/drivers/net/failsafe/failsafe_intr.c\n@@ -372,7 +372,7 @@ void failsafe_rx_intr_uninstall_subdevice(struct sub_device *sdev)\n \tfor (qid = 0; qid < ETH(sdev)->data->nb_rx_queues; qid++) {\n \t\tif (qid < fsdev->data->nb_rx_queues) {\n \t\t\tfsrxq = fsdev->data->rx_queues[qid];\n-\t\t\tif (fsrxq->enable_events)\n+\t\t\tif (fsrxq != NULL && fsrxq->enable_events)\n \t\t\t\trte_eth_dev_rx_intr_disable(PORT_ID(sdev),\n \t\t\t\t\t\t\t qid);\n \t\t}\ndiff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c\nindex b2a5fe4d9..5374d0597 100644\n--- a/drivers/net/failsafe/failsafe_ops.c\n+++ b/drivers/net/failsafe/failsafe_ops.c\n@@ -88,6 +88,8 @@ static struct rte_eth_dev_info default_infos = {\n \t\t\tETH_RSS_IP |\n \t\t\tETH_RSS_UDP |\n \t\t\tETH_RSS_TCP,\n+\t.dev_capa =\n+\t\tRTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP,\n };\n \n static int\n@@ -179,7 +181,7 @@ fs_set_queues_state_start(struct rte_eth_dev *dev)\n \n \tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n \t\trxq = dev->data->rx_queues[i];\n-\t\tif (!rxq->info.conf.rx_deferred_start)\n+\t\tif (rxq != NULL && !rxq->info.conf.rx_deferred_start)\n \t\t\tdev->data->rx_queue_state[i] =\n \t\t\t\t\t\tRTE_ETH_QUEUE_STATE_STARTED;\n \t}\n@@ -240,7 +242,9 @@ fs_set_queues_state_stop(struct rte_eth_dev *dev)\n \tuint16_t i;\n \n \tfor (i = 0; i < dev->data->nb_rx_queues; i++)\n-\t\tdev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;\n+\t\tif (dev->data->rx_queues[i] != NULL)\n+\t\t\tdev->data->rx_queue_state[i] =\n+\t\t\t\t\t\tRTE_ETH_QUEUE_STATE_STOPPED;\n \tfor (i = 0; i < dev->data->nb_tx_queues; i++)\n \t\tdev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;\n }\n", "prefixes": [ "1/2" ] }{ "id": 44140, "url": "