Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 44058,
    "url": "http://patches.dpdk.org/api/patches/44058/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180830223512.21297-4-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180830223512.21297-4-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180830223512.21297-4-stephen@networkplumber.org",
    "date": "2018-08-30T22:35:10",
    "name": "[3/5] net/netvsc: exhausting transmit descriptors is not an error",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "2c385e1049ba2e2f22460bebcdc2fff67baf2267",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180830223512.21297-4-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 1120,
            "url": "http://patches.dpdk.org/api/series/1120/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1120",
            "date": "2018-08-30T22:35:07",
            "name": "netvsc changes for 18.11",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/1120/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/44058/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/44058/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 090C15F28;\n\tFri, 31 Aug 2018 00:35:30 +0200 (CEST)",
            "from mail-pg1-f195.google.com (mail-pg1-f195.google.com\n\t[209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 371335F13\n\tfor <dev@dpdk.org>; Fri, 31 Aug 2018 00:35:24 +0200 (CEST)",
            "by mail-pg1-f195.google.com with SMTP id m4-v6so4510553pgv.12\n\tfor <dev@dpdk.org>; Thu, 30 Aug 2018 15:35:24 -0700 (PDT)",
            "from xeon-e3.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tr19-v6sm11746033pgg.39.2018.08.30.15.35.21\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 30 Aug 2018 15:35:21 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=L4ktxJPjB/Y1XpT72mehhDh8nDvh+zTinSBNqVlq2Rg=;\n\tb=OmMx7oc8BgXvpKe5ucCJYbgb5d+ASpvKqVJxejed3Awm4KEhyte8zGKNEviRr0eSaK\n\teG14qWdJDxPGRQ0bj8nWYnlGk2l7D74phZ0qJCcygXgvi9KUUSFu4ByiKYlUo7GfqyXm\n\tPAQEPOtlAm9qSMadmeCXy+uGlmS2JIer0H2JzVDPuWOAoWqRm0Tp0g3yyBelNx2/wQvG\n\teyDSb3Vn/SYQN4RojardwzBkX/9bAuKHsPmRcg8npjaLT2g9kBwoqmhAP2z4vm9z7BHH\n\tyoDt4ZvsQn4ssFZh4IDWnfC11UGwnDKno5vFY6khP1k+FZ3+IjysdYM2qMPhaMYIL1eo\n\tKVQg==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=L4ktxJPjB/Y1XpT72mehhDh8nDvh+zTinSBNqVlq2Rg=;\n\tb=mp0wywCqm9I6MQyg36kGkxIi42sjFbos/f2QzcDePlKxJQRBuM9DCHyCSjyKMqUyIW\n\tdCJ0kZUdGGKUo1UnffuEEhMJFSD9bm+jCtBSHci91ZAJ7FTDJOVeaVcIDJjdtniJs5qR\n\tMC9DZsCHvq8W/invaJReWK2zkt1Bf39OwJt2n1U9fmFZ/VOVs2ybEpfzYZ+ODtQPdQ5q\n\tPvDal8etV2AQeY3Yd73+1g5lBlzxdWe8+QTZiyxIDMFpN81nUJhXHjaQj1Swgr6Ybh3v\n\tBv/E1U3yP1zCvWaReKPAfiS6MjKWE20kab+xpLmY/3JrSiL4RdhjFwRZbltgLWRbQ6c4\n\tECgQ==",
        "X-Gm-Message-State": "APzg51C3yoNm29OqooE2s4hmMKe0JZRkaMhj3n7TY0xLueL2F4+1Ealt\n\tWHk03f9hEbndSwe+1hQB7BP78vLnWHMFkA==",
        "X-Google-Smtp-Source": "ANB0Vdb+Tc9Kyers1MPKG+6GbR5vfqYeaFD0u9KHyaZ327lHw+FyBRzPI379rzi3bs27apDaVsRiYA==",
        "X-Received": "by 2002:a63:f344:: with SMTP id\n\tt4-v6mr11794302pgj.428.1535668523074; \n\tThu, 30 Aug 2018 15:35:23 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <sthemmin@microsoft.com>",
        "Date": "Thu, 30 Aug 2018 15:35:10 -0700",
        "Message-Id": "<20180830223512.21297-4-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.18.0",
        "In-Reply-To": "<20180830223512.21297-1-stephen@networkplumber.org>",
        "References": "<20180830223512.21297-1-stephen@networkplumber.org>",
        "Subject": "[dpdk-dev] [PATCH 3/5] net/netvsc: exhausting transmit descriptors\n\tis not an error",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Stephen Hemminger <sthemmin@microsoft.com>\n\nIf application sends faster than vswitch can keep up, then the\ntransmit descriptor pool will be exhausted. This is not a failure\nso change the name statistic and don't include it in oerrors.\n\nSigned-off-by: Stephen Hemminger <sthemmin@microsoft.com>\n---\n drivers/net/netvsc/hn_ethdev.c | 7 +++----\n drivers/net/netvsc/hn_rxtx.c   | 4 ++--\n drivers/net/netvsc/hn_var.h    | 3 +--\n 3 files changed, 6 insertions(+), 8 deletions(-)",
    "diff": "diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c\nindex 97e4b0da4410..8643e0b3c057 100644\n--- a/drivers/net/netvsc/hn_ethdev.c\n+++ b/drivers/net/netvsc/hn_ethdev.c\n@@ -57,7 +57,7 @@ static const struct hn_xstats_name_off hn_stat_strings[] = {\n \t{ \"good_packets\",           offsetof(struct hn_stats, packets) },\n \t{ \"good_bytes\",             offsetof(struct hn_stats, bytes) },\n \t{ \"errors\",                 offsetof(struct hn_stats, errors) },\n-\t{ \"allocation_failed\",      offsetof(struct hn_stats, nomemory) },\n+\t{ \"ring full\",              offsetof(struct hn_stats, ring_full) },\n \t{ \"multicast_packets\",      offsetof(struct hn_stats, multicast) },\n \t{ \"broadcast_packets\",      offsetof(struct hn_stats, broadcast) },\n \t{ \"undersize_packets\",      offsetof(struct hn_stats, size_bins[0]) },\n@@ -407,7 +407,7 @@ static int hn_dev_stats_get(struct rte_eth_dev *dev,\n \n \t\tstats->opackets += txq->stats.packets;\n \t\tstats->obytes += txq->stats.bytes;\n-\t\tstats->oerrors += txq->stats.errors + txq->stats.nomemory;\n+\t\tstats->oerrors += txq->stats.errors;\n \n \t\tif (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {\n \t\t\tstats->q_opackets[i] = txq->stats.packets;\n@@ -424,7 +424,7 @@ static int hn_dev_stats_get(struct rte_eth_dev *dev,\n \t\tstats->ipackets += rxq->stats.packets;\n \t\tstats->ibytes += rxq->stats.bytes;\n \t\tstats->ierrors += rxq->stats.errors;\n-\t\tstats->imissed += rxq->ring_full;\n+\t\tstats->imissed += rxq->stats.ring_full;\n \n \t\tif (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {\n \t\t\tstats->q_ipackets[i] = rxq->stats.packets;\n@@ -458,7 +458,6 @@ hn_dev_stats_reset(struct rte_eth_dev *dev)\n \t\t\tcontinue;\n \n \t\tmemset(&rxq->stats, 0, sizeof(struct hn_stats));\n-\t\trxq->ring_full = 0;\n \t}\n }\n \ndiff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c\nindex cb5bc6029ce7..92de5d09e442 100644\n--- a/drivers/net/netvsc/hn_rxtx.c\n+++ b/drivers/net/netvsc/hn_rxtx.c\n@@ -534,7 +534,7 @@ static void hn_rxpkt(struct hn_rx_queue *rxq, struct hn_rx_bufinfo *rxb,\n \thn_update_packet_stats(&rxq->stats, m);\n \n \tif (unlikely(rte_ring_sp_enqueue(rxq->rx_ring, m) != 0)) {\n-\t\t++rxq->ring_full;\n+\t\t++rxq->stats.ring_full;\n \t\trte_pktmbuf_free(m);\n \t}\n }\n@@ -1007,7 +1007,7 @@ static struct hn_txdesc *hn_new_txd(struct hn_data *hv,\n \tstruct hn_txdesc *txd;\n \n \tif (rte_mempool_get(hv->tx_pool, (void **)&txd)) {\n-\t\t++txq->stats.nomemory;\n+\t\t++txq->stats.ring_full;\n \t\tPMD_TX_LOG(DEBUG, \"tx pool exhausted!\");\n \t\treturn NULL;\n \t}\ndiff --git a/drivers/net/netvsc/hn_var.h b/drivers/net/netvsc/hn_var.h\nindex f188f6360f79..ff722560d9d9 100644\n--- a/drivers/net/netvsc/hn_var.h\n+++ b/drivers/net/netvsc/hn_var.h\n@@ -39,7 +39,7 @@ struct hn_stats {\n \tuint64_t\tpackets;\n \tuint64_t\tbytes;\n \tuint64_t\terrors;\n-\tuint64_t\tnomemory;\n+\tuint64_t\tring_full;\n \tuint64_t\tmulticast;\n \tuint64_t\tbroadcast;\n \t/* Size bins in array as RFC 2819, undersized [0], 64 [1], etc */\n@@ -78,7 +78,6 @@ struct hn_rx_queue {\n \tuint16_t port_id;\n \tuint16_t queue_id;\n \tstruct hn_stats stats;\n-\tuint64_t ring_full;\n \n \tvoid *event_buf;\n };\n",
    "prefixes": [
        "3/5"
    ]
}