Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44031/?format=api
{ "id": 44031, "url": "http://patches.dpdk.org/api/patches/44031/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/f5ff987f415710bbc11032f34686a5ec0119da2a.1535633784.git.gaetan.rivet@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<f5ff987f415710bbc11032f34686a5ec0119da2a.1535633784.git.gaetan.rivet@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/f5ff987f415710bbc11032f34686a5ec0119da2a.1535633784.git.gaetan.rivet@6wind.com", "date": "2018-08-30T13:42:00", "name": "[v1,09/13] bus/pci: pre-process declarative PCI devargs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "001705ed3c88af82a1367c6dc85740c1bc73313f", "submitter": { "id": 269, "url": "http://patches.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/f5ff987f415710bbc11032f34686a5ec0119da2a.1535633784.git.gaetan.rivet@6wind.com/mbox/", "series": [ { "id": 1115, "url": "http://patches.dpdk.org/api/series/1115/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1115", "date": "2018-08-30T13:41:51", "name": "Implement new devargs framework", "version": 1, "mbox": "http://patches.dpdk.org/series/1115/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/44031/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/44031/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C05065B12;\n\tThu, 30 Aug 2018 15:42:57 +0200 (CEST)", "from mail-wm0-f68.google.com (mail-wm0-f68.google.com\n\t[74.125.82.68]) by dpdk.org (Postfix) with ESMTP id F03D94F98\n\tfor <dev@dpdk.org>; Thu, 30 Aug 2018 15:42:43 +0200 (CEST)", "by mail-wm0-f68.google.com with SMTP id b19-v6so2051579wme.3\n\tfor <dev@dpdk.org>; Thu, 30 Aug 2018 06:42:43 -0700 (PDT)", "from bidouze.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tw10-v6sm5247731wrp.31.2018.08.30.06.42.42\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 30 Aug 2018 06:42:42 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Y8K45UJQ09MUdfAKjo3IIq4OhsoAko2Z85k+Px7chNw=;\n\tb=ucdjm+n1rmg/+xwpEERH17kTVUj3lO6QqQnWWabjtvuK56PQPDPcz01CUoAEgwFs54\n\tiZe1Mcqq21+CnatCd155yXUTP83Hi9nKIPNCHIrfncAi4lciaKE4OZSl5aGoLqQ3rIqd\n\tTZdmanlgu+LJSxgoyaCHYGRh097rdXJdaBpxGvWhuklHjA5S4VVmGMkHl2W04LugMbff\n\t9H+evxs6uU+eLEvyT0xwH0lyKOYQeMc/bEKGIEydvjYmYj3Q30b+7f04z+R1slxDwlLv\n\tCCJFEXTxWFcp0kjNtXWubG5kqWCHhRjZy+6Zfs0y0ToXTHcQKiNlrIgYIB/D12zH6E+T\n\tC19A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Y8K45UJQ09MUdfAKjo3IIq4OhsoAko2Z85k+Px7chNw=;\n\tb=JQgWbMCVuXNErVy/CAeGOq98736fee3Odf0Vw7VfUjDQ4XAe006XKWHSNSCptHxwRK\n\tVPEAx7X91xz3Fk/gZp/eiL9JFmKh2K28G46BgVATJZqpdcv5nHPt5UMwfAORKFrMieus\n\tb1HXeV8ls0yOnnKAEpaukrsIpTSYkhZE+JfQwLjV1/16vw6o9HK0jebUTB3Ea41iaN8G\n\tLYwAMs001IfSkOXwXmXnzi87QoY2N6n/qPal25BLvfA0lyf4oy2l5nqL/oQF6MTXOJPK\n\tfM8o9r89viSqfMoz+SZsmS7TvUlRg9HCyiFQOiRTZhfVllXzx+dJuxMSyAWDybByZM/S\n\t1HXQ==", "X-Gm-Message-State": "APzg51AsxPOeVMTF/RAzUCuwN2ieRbR5g5/URnaUn8LbHThkMXigFIsj\n\tTM94inQHRXioal0JZ+1oHFlvj7DuF8A=", "X-Google-Smtp-Source": "ANB0VdabVoRoCxv9gMDUD5xThnT3fBlsNnDEIrIH2uUEqfdUfNEYu7gGuzSPuXdk8X9b/E0I857DJw==", "X-Received": "by 2002:a1c:889:: with SMTP id\n\t131-v6mr1794237wmi.142.1535636563278; \n\tThu, 30 Aug 2018 06:42:43 -0700 (PDT)", "From": "Gaetan Rivet <gaetan.rivet@6wind.com>", "To": "dev@dpdk.org", "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Date": "Thu, 30 Aug 2018 15:42:00 +0200", "Message-Id": "<f5ff987f415710bbc11032f34686a5ec0119da2a.1535633784.git.gaetan.rivet@6wind.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<cover.1535633783.git.gaetan.rivet@6wind.com>", "References": "<cover.1535633783.git.gaetan.rivet@6wind.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1 09/13] bus/pci: pre-process declarative PCI\n\tdevargs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The new devargs format does not recognize a particular device name.\nEach bus uses its specific format.\n\nInstead of introducing a new bus API, process those devargs privately\nfor the moment. Prepare them for matching during scan against the\nbus devices.\n\nSigned-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n drivers/bus/pci/bsd/pci.c | 5 ++++\n drivers/bus/pci/linux/pci.c | 5 ++++\n drivers/bus/pci/pci_params.c | 51 ++++++++++++++++++++++++++++++++++++\n drivers/bus/pci/private.h | 16 +++++++++++\n 4 files changed, 77 insertions(+)", "diff": "diff --git a/drivers/bus/pci/bsd/pci.c b/drivers/bus/pci/bsd/pci.c\nindex 655b34b7e..046cd11d5 100644\n--- a/drivers/bus/pci/bsd/pci.c\n+++ b/drivers/bus/pci/bsd/pci.c\n@@ -327,6 +327,7 @@ pci_scan_one(int dev_pci_fd, struct pci_conf *conf)\n int\n rte_pci_scan(void)\n {\n+\tstruct rte_devargs *devargs;\n \tint fd;\n \tunsigned dev_count = 0;\n \tstruct pci_conf matches[16];\n@@ -342,6 +343,10 @@ rte_pci_scan(void)\n \tif (!rte_eal_has_pci())\n \t\treturn 0;\n \n+\tRTE_EAL_DEVARGS_FOREACH(\"pci\", devargs)\n+\t\tif (rte_pci_devargs_prepare(devargs))\n+\t\t\tcontinue;\n+\n \tfd = open(\"/dev/pci\", O_RDONLY);\n \tif (fd < 0) {\n \t\tRTE_LOG(ERR, EAL, \"%s(): error opening /dev/pci\\n\", __func__);\ndiff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c\nindex 04648ac93..12f246089 100644\n--- a/drivers/bus/pci/linux/pci.c\n+++ b/drivers/bus/pci/linux/pci.c\n@@ -429,6 +429,7 @@ parse_pci_addr_format(const char *buf, int bufsize, struct rte_pci_addr *addr)\n int\n rte_pci_scan(void)\n {\n+\tstruct rte_devargs *devargs;\n \tstruct dirent *e;\n \tDIR *dir;\n \tchar dirname[PATH_MAX];\n@@ -438,6 +439,10 @@ rte_pci_scan(void)\n \tif (!rte_eal_has_pci())\n \t\treturn 0;\n \n+\tRTE_EAL_DEVARGS_FOREACH(\"pci\", devargs)\n+\t\tif (rte_pci_devargs_prepare(devargs))\n+\t\t\tcontinue;\n+\n #ifdef VFIO_PRESENT\n \tif (!pci_vfio_is_enabled())\n \t\tRTE_LOG(DEBUG, EAL, \"VFIO PCI modules not loaded\\n\");\ndiff --git a/drivers/bus/pci/pci_params.c b/drivers/bus/pci/pci_params.c\nindex 7630d4845..a09af3b1c 100644\n--- a/drivers/bus/pci/pci_params.c\n+++ b/drivers/bus/pci/pci_params.c\n@@ -2,9 +2,12 @@\n * Copyright 2018 Gaëtan Rivet\n */\n \n+#include <string.h>\n+\n #include <rte_bus.h>\n #include <rte_bus_pci.h>\n #include <rte_dev.h>\n+#include <rte_devargs.h>\n #include <rte_errno.h>\n #include <rte_kvargs.h>\n #include <rte_pci.h>\n@@ -76,3 +79,51 @@ rte_pci_dev_iterate(const void *start,\n \trte_kvargs_free(kvargs);\n \treturn dev;\n }\n+\n+static int\n+pci_addr_kv_parse(const char *key __rte_unused,\n+\t\t const char *value,\n+\t\t void *_devargs)\n+{\n+\tstruct rte_devargs *devargs = _devargs;\n+\tstruct rte_pci_addr addr;\n+\n+\t/* Verify address is valid. */\n+\tif (rte_pci_addr_parse(value, &addr)) {\n+\t\trte_errno = ENODEV;\n+\t\treturn -1;\n+\t}\n+\t/* Write down the address as the devargs name. */\n+\trte_pci_device_name(&addr, devargs->name, sizeof(devargs->name));\n+\treturn 0;\n+}\n+\n+int\n+rte_pci_devargs_prepare(struct rte_devargs *devargs)\n+{\n+\tstruct rte_kvargs *kvargs = NULL;\n+\tchar *args;\n+\tint ret;\n+\n+\tif (devargs->bus_str == NULL)\n+\t\treturn 0;\n+\n+\targs = strchr(devargs->bus_str, ',');\n+\tif (args == NULL)\n+\t\treturn 0;\n+\targs++;\n+\n+\tkvargs = rte_kvargs_parse(args, pci_params_keys);\n+\tif (kvargs == NULL) {\n+\t\tRTE_LOG(ERR, EAL, \"unable to parse parameter list: %s\\n\",\n+\t\t\tdevargs->bus_str);\n+\t\trte_errno = EINVAL;\n+\t\treturn -1;\n+\t}\n+\n+\tret = rte_kvargs_process(kvargs, \"id\",\n+\t\t\t\t &pci_addr_kv_parse, devargs);\n+\n+\trte_kvargs_free(kvargs);\n+\treturn ret;\n+}\ndiff --git a/drivers/bus/pci/private.h b/drivers/bus/pci/private.h\nindex 0e689fa74..9beb24c6a 100644\n--- a/drivers/bus/pci/private.h\n+++ b/drivers/bus/pci/private.h\n@@ -191,4 +191,20 @@ rte_pci_dev_iterate(const void *start,\n \t\t const char *str,\n \t\t const struct rte_dev_iterator *it);\n \n+/*\n+ * Prepare a devargs meant for this bus.\n+ * This function is only used for a transitory period,\n+ * to translate the new devargs format in one\n+ * compatible with the old form.\n+ *\n+ * @param da\n+ * Devargs to process.\n+ *\n+ * @return\n+ * 0 on success.\n+ * <0 on error.\n+ */\n+int\n+rte_pci_devargs_prepare(struct rte_devargs *da);\n+\n #endif /* _PCI_PRIVATE_H_ */\n", "prefixes": [ "v1", "09/13" ] }