Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43945/?format=api
{ "id": 43945, "url": "http://patches.dpdk.org/api/patches/43945/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1535528134-20319-2-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1535528134-20319-2-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1535528134-20319-2-git-send-email-arybchenko@solarflare.com", "date": "2018-08-29T07:35:34", "name": "[2/2] net/sfc: support runtime Tx queue setup", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5fe31d4cf4861c8fc26fb45cdf6935142afedc29", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1535528134-20319-2-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 1083, "url": "http://patches.dpdk.org/api/series/1083/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1083", "date": "2018-08-29T07:35:33", "name": "[1/2] net/sfc: support runtime Rx queue setup", "version": 1, "mbox": "http://patches.dpdk.org/series/1083/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43945/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/43945/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E35634CAF;\n\tWed, 29 Aug 2018 09:36:08 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 7C5184C96\n\tfor <dev@dpdk.org>; Wed, 29 Aug 2018 09:36:05 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id 3DAF0600056; Wed, 29 Aug 2018 07:36:04 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Wed, 29 Aug 2018 00:36:01 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Wed, 29 Aug 2018 00:36:00 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw7T7Zxuu025599; Wed, 29 Aug 2018 08:35:59 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t591A11626D2; Wed, 29 Aug 2018 08:35:59 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Igor Romanov <igor.romanov@oktetlabs.ru>", "Date": "Wed, 29 Aug 2018 08:35:34 +0100", "Message-ID": "<1535528134-20319-2-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1535528134-20319-1-git-send-email-arybchenko@solarflare.com>", "References": "<1535528134-20319-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24060.005", "X-TM-AS-Result": "No-1.208000-4.000000-10", "X-TMASE-MatchedRID": "rsJmA+R6AF/Ot+/gOYaZxQPZZctd3P4BXru95hSuhjRZVbxJogyhUzK2\n\tieu8M5yx7lGe7/57bl+/08jbUug8/BCR6UNmPZVEoprTEHvewADqorGIcSSE7hL6MU7t349bd6W\n\tKiwhZWBjGSqxW6PLJadC4I7fLwdY3IkVsNYB2lkueAiCmPx4NwBnUJ0Ek6yhjxEHRux+uk8ifEz\n\tJ5hPndGXuX+WmqT1txbOzqsvcNAwpM6kGVKj0nS57Vr9UbZBhL5TipTElZFHqiRruO+BeHftniO\n\tmvqLC3NwrWhkQwlwjuvwgcN+u+WEpN1JFeUKeMEiOOUXfTkScBZSbxIRLLN37zfneGoTKOTw8g2\n\tHBNcF5k=", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10-1.208000-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24060.005", "X-MDID": "1535528164-IdIw7TzenuyO", "Subject": "[dpdk-dev] [PATCH 2/2] net/sfc: support runtime Tx queue setup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Igor Romanov <igor.romanov@oktetlabs.ru>\n\nSigned-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n doc/guides/nics/features/sfc_efx.ini | 1 +\n drivers/net/sfc/sfc_ethdev.c | 7 ++++++-\n drivers/net/sfc/sfc_tx.c | 8 +++++---\n 3 files changed, 12 insertions(+), 4 deletions(-)", "diff": "diff --git a/doc/guides/nics/features/sfc_efx.ini b/doc/guides/nics/features/sfc_efx.ini\nindex 5d2e90102..d1aa83313 100644\n--- a/doc/guides/nics/features/sfc_efx.ini\n+++ b/doc/guides/nics/features/sfc_efx.ini\n@@ -10,6 +10,7 @@ Link status event = Y\n Fast mbuf free = Y\n Queue start/stop = Y\n Runtime Rx queue setup = Y\n+Runtime Tx queue setup = Y\n MTU update = Y\n Jumbo frame = Y\n Scattered Rx = Y\ndiff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex 9b5324ca6..435bde67f 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -172,7 +172,8 @@ sfc_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \tif (sa->dp_tx->get_dev_info != NULL)\n \t\tsa->dp_tx->get_dev_info(dev_info);\n \n-\tdev_info->dev_capa = RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP;\n+\tdev_info->dev_capa = RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP |\n+\t\t\t RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP;\n }\n \n static const uint32_t *\n@@ -1197,6 +1198,9 @@ sfc_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id)\n \tif (sa->state != SFC_ADAPTER_STARTED)\n \t\tgoto fail_not_started;\n \n+\tif (sa->txq_info[tx_queue_id].txq == NULL)\n+\t\tgoto fail_not_setup;\n+\n \trc = sfc_tx_qstart(sa, tx_queue_id);\n \tif (rc != 0)\n \t\tgoto fail_tx_qstart;\n@@ -1208,6 +1212,7 @@ sfc_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id)\n \n fail_tx_qstart:\n \n+fail_not_setup:\n fail_not_started:\n \tsfc_adapter_unlock(sa);\n \tSFC_ASSERT(rc > 0);\ndiff --git a/drivers/net/sfc/sfc_tx.c b/drivers/net/sfc/sfc_tx.c\nindex 6d42a1a65..8af08b37c 100644\n--- a/drivers/net/sfc/sfc_tx.c\n+++ b/drivers/net/sfc/sfc_tx.c\n@@ -421,6 +421,7 @@ sfc_tx_qstart(struct sfc_adapter *sa, unsigned int sw_index)\n \n \ttxq = txq_info->txq;\n \n+\tSFC_ASSERT(txq != NULL);\n \tSFC_ASSERT(txq->state == SFC_TXQ_INITIALIZED);\n \n \tevq = txq->evq;\n@@ -501,7 +502,7 @@ sfc_tx_qstop(struct sfc_adapter *sa, unsigned int sw_index)\n \n \ttxq = txq_info->txq;\n \n-\tif (txq->state == SFC_TXQ_INITIALIZED)\n+\tif (txq == NULL || txq->state == SFC_TXQ_INITIALIZED)\n \t\treturn;\n \n \tSFC_ASSERT(txq->state & SFC_TXQ_STARTED);\n@@ -578,8 +579,9 @@ sfc_tx_start(struct sfc_adapter *sa)\n \t\tgoto fail_efx_tx_init;\n \n \tfor (sw_index = 0; sw_index < sa->txq_count; ++sw_index) {\n-\t\tif (!(sa->txq_info[sw_index].deferred_start) ||\n-\t\t sa->txq_info[sw_index].deferred_started) {\n+\t\tif (sa->txq_info[sw_index].txq != NULL &&\n+\t\t (!(sa->txq_info[sw_index].deferred_start) ||\n+\t\t sa->txq_info[sw_index].deferred_started)) {\n \t\t\trc = sfc_tx_qstart(sa, sw_index);\n \t\t\tif (rc != 0)\n \t\t\t\tgoto fail_tx_qstart;\n", "prefixes": [ "2/2" ] }