Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43901/?format=api
{ "id": 43901, "url": "http://patches.dpdk.org/api/patches/43901/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1535372574-18950-3-git-send-email-tdu@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1535372574-18950-3-git-send-email-tdu@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1535372574-18950-3-git-send-email-tdu@semihalf.com", "date": "2018-08-27T12:22:53", "name": "[2/3] crypto/mvsam: use common initialization", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "41be1cbada6654bcf9edb2efcaa475db5c4fc8b4", "submitter": { "id": 846, "url": "http://patches.dpdk.org/api/people/846/?format=api", "name": "Tomasz Duszynski", "email": "tdu@semihalf.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1535372574-18950-3-git-send-email-tdu@semihalf.com/mbox/", "series": [ { "id": 1063, "url": "http://patches.dpdk.org/api/series/1063/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1063", "date": "2018-08-27T12:22:51", "name": "crypto/mvsam: yet another round of features", "version": 1, "mbox": "http://patches.dpdk.org/series/1063/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43901/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/43901/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B3A675B20;\n\tMon, 27 Aug 2018 14:23:11 +0200 (CEST)", "from mail-lf1-f66.google.com (mail-lf1-f66.google.com\n\t[209.85.167.66]) by dpdk.org (Postfix) with ESMTP id 7C9315911\n\tfor <dev@dpdk.org>; Mon, 27 Aug 2018 14:23:05 +0200 (CEST)", "by mail-lf1-f66.google.com with SMTP id z11-v6so11747749lff.9\n\tfor <dev@dpdk.org>; Mon, 27 Aug 2018 05:23:05 -0700 (PDT)", "from sh.semihalf.local (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173]) by smtp.gmail.com with ESMTPSA id\n\tt14-v6sm2454756ljg.17.2018.08.27.05.23.03\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 27 Aug 2018 05:23:04 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=kYti1FjV5bWeLtRDf6pr2vNlIrX4YqVWdCM5Co9Yfhs=;\n\tb=Lf+hK8oJf/d1qRLw91NWOgzUWxyRzY39uRiPkPeGgJs0r9xj8/235gRthBurrljsgS\n\twJPF0Ywi03VQZ/cCoVZoPoeXrZ6s/4Y7SJtnwcmEOrhOC6ezpq+qtM5jAjjp3jPPkCTz\n\tpCYhpRJQUChU2D7p+nxTf7GVPaUXHGxhHXEmogBOev+kxyBnjuFXTZJ97jDVHcwPba+S\n\tfAUvpbQCfwR9GIPSlEkWmzXhCxYXk9N7tnvqJSyf/6Xoojm0CXVvAMcVztq/QKR8oXtW\n\tU8ysmKSnh6/9oWGOKhiCccrBUlOyJiODIT5fcBv4F3aXToIE+mmkjmnLictbrjQeBMtl\n\t/HQA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=kYti1FjV5bWeLtRDf6pr2vNlIrX4YqVWdCM5Co9Yfhs=;\n\tb=WaMDjVqV8OrNbLyj9tK+GhTqtYs1T/fYd/8uhnkvbjDng9VSnNpHoSgofkpCG+mWb4\n\teEtO/sD/zM0NwFEoVYu1ehrbVc0ZMCfv7Xhp/J6MNxmaACTHrPUT8kIVz4j3UfcdIGsF\n\tOiWAMTcoU3Y/ea85SLEzkq8z9CMqBn8dLFzRt1t0LBYWAcmIjm8HCuyLMNcCZmkzMIqD\n\tyIjPGiATmL4ZXl9xMKJZXdcEYWxoQ+cghO19ao2kPZXyYXLjYo6mbQlXvWAoHgan1lBw\n\tTDTylyjn9ZY8kbqw+8VhqQa0Lsx9Nhf9NybNmuLizcMYES2qx0PYWGR1btxClP+ZUdKW\n\tKd6A==", "X-Gm-Message-State": "APzg51DhspVnzR9Hvt8jNNSS8XqrDtcuutOn8Si5u87hnAYtfxdckd7P\n\t4k8LFffOLT3D2swzksaEoqzWv4zciJw=", "X-Google-Smtp-Source": "ANB0VdZIddrZ2pXNcI3ok+GlGBhOiMrruGCKeC46cxXtJf3Sb8yk33HeSuy36A4unO+TMfiCmupMZg==", "X-Received": "by 2002:a19:430d:: with SMTP id\n\tq13-v6mr8102777lfa.77.1535372584943; \n\tMon, 27 Aug 2018 05:23:04 -0700 (PDT)", "From": "Tomasz Duszynski <tdu@semihalf.com>", "To": "dev@dpdk.org", "Cc": "nsamsono@marvell.com, mw@semihalf.com, Dmitri Epshtein <dima@marvell.com>,\n\tTomasz Duszynski <tdu@semihalf.com>", "Date": "Mon, 27 Aug 2018 14:22:53 +0200", "Message-Id": "<1535372574-18950-3-git-send-email-tdu@semihalf.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1535372574-18950-1-git-send-email-tdu@semihalf.com>", "References": "<1535372574-18950-1-git-send-email-tdu@semihalf.com>", "Subject": "[dpdk-dev] [PATCH 2/3] crypto/mvsam: use common initialization", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Dmitri Epshtein <dima@marvell.com>\n\nUse common initialization to reduce boilerplate code.\n\nSigned-off-by: Dmitri Epshtein <dima@marvell.com>\nSigned-off-by: Tomasz Duszynski <tdu@semihalf.com>\nReviewed-by: Natalie Samsonov <nsamsono@marvell.com>\n---\n drivers/common/Makefile | 4 +++-\n drivers/crypto/mvsam/Makefile | 3 ++-\n drivers/crypto/mvsam/meson.build | 2 +-\n drivers/crypto/mvsam/rte_mrvl_pmd.c | 30 +++++++++++++-----------------\n mk/rte.app.mk | 4 +++-\n 5 files changed, 22 insertions(+), 21 deletions(-)\n\n--\n2.7.4", "diff": "diff --git a/drivers/common/Makefile b/drivers/common/Makefile\nindex 5f72da0..5bcff17 100644\n--- a/drivers/common/Makefile\n+++ b/drivers/common/Makefile\n@@ -8,7 +8,9 @@ ifeq ($(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF)$(CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOO\n DIRS-y += octeontx\n endif\n\n-ifeq ($(CONFIG_RTE_LIBRTE_MVPP2_PMD),y)\n+MVEP-y += $(CONFIG_RTE_LIBRTE_MVPP2_PMD)\n+MVEP-y += $(CONFIG_RTE_LIBRTE_PMD_MVSAM_CRYPTO)\n+ifneq (,$(filter y,$(MVEP-y)))\n DIRS-y += mvep\n endif\n\ndiff --git a/drivers/crypto/mvsam/Makefile b/drivers/crypto/mvsam/Makefile\nindex 3290147..2b4d036 100644\n--- a/drivers/crypto/mvsam/Makefile\n+++ b/drivers/crypto/mvsam/Makefile\n@@ -19,6 +19,7 @@ LIB = librte_pmd_mvsam_crypto.a\n # build flags\n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\n+CFLAGS += -I$(RTE_SDK)/drivers/common/mvep\n CFLAGS += -I$(LIBMUSDK_PATH)/include\n CFLAGS += -DMVCONF_TYPES_PUBLIC\n CFLAGS += -DMVCONF_DMA_PHYS_ADDR_T_PUBLIC\n@@ -33,7 +34,7 @@ EXPORT_MAP := rte_pmd_mvsam_version.map\n LDLIBS += -L$(LIBMUSDK_PATH)/lib -lmusdk\n LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_kvargs\n LDLIBS += -lrte_cryptodev\n-LDLIBS += -lrte_bus_vdev\n+LDLIBS += -lrte_bus_vdev -lrte_common_mvep\n\n # library source files\n SRCS-$(CONFIG_RTE_LIBRTE_PMD_MVSAM_CRYPTO) += rte_mrvl_pmd.c\ndiff --git a/drivers/crypto/mvsam/meson.build b/drivers/crypto/mvsam/meson.build\nindex 3c8ea3c..f1c8796 100644\n--- a/drivers/crypto/mvsam/meson.build\n+++ b/drivers/crypto/mvsam/meson.build\n@@ -18,4 +18,4 @@ endif\n\n sources = files('rte_mrvl_pmd.c', 'rte_mrvl_pmd_ops.c')\n\n-deps += ['bus_vdev']\n+deps += ['bus_vdev', 'common_mvep']\ndiff --git a/drivers/crypto/mvsam/rte_mrvl_pmd.c b/drivers/crypto/mvsam/rte_mrvl_pmd.c\nindex 001aa28..9c3bb91 100644\n--- a/drivers/crypto/mvsam/rte_mrvl_pmd.c\n+++ b/drivers/crypto/mvsam/rte_mrvl_pmd.c\n@@ -12,11 +12,10 @@\n #include <rte_malloc.h>\n #include <rte_cpuflags.h>\n #include <rte_kvargs.h>\n+#include <rte_mvep_common.h>\n\n #include \"rte_mrvl_pmd_private.h\"\n\n-#define MRVL_MUSDK_DMA_MEMSIZE 41943040\n-\n #define MRVL_PMD_MAX_NB_SESS_ARG\t\t(\"max_nb_sessions\")\n #define MRVL_PMD_DEFAULT_MAX_NB_SESSIONS\t2048\n\n@@ -767,7 +766,7 @@ cryptodev_mrvl_crypto_create(const char *name,\n \tstruct rte_cryptodev *dev;\n \tstruct mrvl_crypto_private *internals;\n \tstruct sam_init_params\tsam_params;\n-\tint ret;\n+\tint ret = -EINVAL;\n\n \tdev = rte_cryptodev_pmd_create(name, &vdev->device,\n \t\t\t&init_params->common);\n@@ -793,30 +792,26 @@ cryptodev_mrvl_crypto_create(const char *name,\n \tinternals->max_nb_qpairs = init_params->common.max_nb_queue_pairs;\n \tinternals->max_nb_sessions = init_params->max_nb_sessions;\n\n-\t/*\n-\t * ret == -EEXIST is correct, it means DMA\n-\t * has been already initialized.\n-\t */\n-\tret = mv_sys_dma_mem_init(MRVL_MUSDK_DMA_MEMSIZE);\n-\tif (ret < 0) {\n-\t\tif (ret != -EEXIST)\n-\t\t\treturn ret;\n-\n-\t\tMRVL_CRYPTO_LOG_INFO(\n-\t\t\t\"DMA memory has been already initialized by a different driver.\");\n-\t}\n+\tret = rte_mvep_init(MVEP_MOD_T_SAM, NULL);\n+\tif (ret)\n+\t\tgoto init_error;\n\n \tsam_params.max_num_sessions = internals->max_nb_sessions;\n\n \t/* sam_set_debug_flags(3); */\n-\treturn sam_init(&sam_params);\n+\n+\tret = sam_init(&sam_params);\n+\tif (ret)\n+\t\tgoto init_error;\n+\n+\treturn 0;\n\n init_error:\n \tMRVL_CRYPTO_LOG_ERR(\n \t\t\"driver %s: %s failed\", init_params->common.name, __func__);\n\n \tcryptodev_mrvl_crypto_uninit(vdev);\n-\treturn -EFAULT;\n+\treturn ret;\n }\n\n /** Parse integer from integer argument */\n@@ -966,6 +961,7 @@ cryptodev_mrvl_crypto_uninit(struct rte_vdev_device *vdev)\n \t\tname, rte_socket_id());\n\n \tsam_deinit();\n+\trte_mvep_deinit(MVEP_MOD_T_SAM);\n\n \tcryptodev = rte_cryptodev_pmd_get_named_dev(name);\n \tif (cryptodev == NULL)\ndiff --git a/mk/rte.app.mk b/mk/rte.app.mk\nindex 899d51a..c8a261e 100644\n--- a/mk/rte.app.mk\n+++ b/mk/rte.app.mk\n@@ -98,7 +98,9 @@ ifeq ($(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF)$(CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOO\n _LDLIBS-y += -lrte_common_octeontx\n endif\n\n-ifeq ($(CONFIG_RTE_LIBRTE_MVPP2_PMD),y)\n+MVEP-y += $(CONFIG_RTE_LIBRTE_MVPP2_PMD)\n+MVEP-y += $(CONFIG_RTE_LIBRTE_PMD_MVSAM_CRYPTO)\n+ifneq (,$(filter y,$(MVEP-y)))\n _LDLIBS-y += -lrte_common_mvep -L$(LIBMUSDK_PATH)/lib -lmusdk\n endif\n\n", "prefixes": [ "2/3" ] }